Add propertybag to parsed tsconfig.json file.#8469
Merged
Conversation
This allows consumers of the LS to read properties added to the tsconfig.json without having to worry about dealing with comments.
Contributor
|
so what is the context for this change? and can we do the same for typingsOptions as well? |
| const knownProperties = ["compilerOptions", "typingOptions", "files", "exclude"]; | ||
|
|
||
| for (const prop in json) { | ||
| if (knownProperties.indexOf(prop) >= 0) { |
Contributor
Author
|
@mhegazy This is to make the handling of |
Contributor
|
how about "raw" instead of other, and that has a copy of the tsconfig.json parsed content? |
| options: CompilerOptions; | ||
| typingOptions?: TypingOptions; | ||
| fileNames: string[]; | ||
| raw?: any; |
Contributor
There was a problem hiding this comment.
why it is optional if you always set it?
Contributor
Author
There was a problem hiding this comment.
not set in commandLineParser.parseStrings
Contributor
|
👍 after comments are addressed |
Contributor
|
👍 |
paulvanbrenk
pushed a commit
that referenced
this pull request
Jun 7, 2016
And fix tslint and typescript compiler versions
paulvanbrenk
added a commit
that referenced
this pull request
Jun 7, 2016
Merge pull request #8469 from Microsoft/tsconfigParsingImprovements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.