Skip to content

Fix #8130: Do not fail if the resources for the specified locale does not exisit #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 2 commits into from
Apr 20, 2016
+3 −5
Merged

Fix #8130: Do not fail if the resources for the specified locale does not exisit #8193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cc9a99
Fix #8130: Do not fail if the resources for the specified locale does…
mhegazy Apr 19, 2016
c53612d
Add missing semicolon
mhegazy Apr 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/compiler/tsc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,9 @@ namespace ts {
const territory = matchResult[3];

// First try the entire locale, then fall back to just language if that's all we have.
if (!trySetLanguageAndTerritory(language, territory, errors) &&
!trySetLanguageAndTerritory(language, undefined, errors)) {

errors.push(createCompilerDiagnostic(Diagnostics.Unsupported_locale_0, locale));
return false;
// Either ways do not fail, and fallback to the English diagnostic strings.
if (!trySetLanguageAndTerritory(language, territory, errors)) {
trySetLanguageAndTerritory(language, undefined, errors);
}

return true;
Expand Down