Add API support for LS host to specify script kind of a file to open#7954
Merged
Conversation
| * Used to specify the script kind of the file explicitly. It could be one of the following: | ||
| * ".ts", ".js", ".tsx", ".jsx" | ||
| */ | ||
| scriptKindName?: string; |
Contributor
There was a problem hiding this comment.
i would keep this insync with ScriptKind. so JS, JSX, TS, TSX.
also i would use string literal types, now that we have them instead of string. so:
scriptKindName?: "JS" | "JSX" | "TS" | "TSX";
Contributor
|
👍 with comments on the values of the scriptkind in the protocol. |
| break; | ||
| case "JSX": | ||
| scriptKind = ScriptKind.JSX; | ||
| break; |
Contributor
There was a problem hiding this comment.
Shouldn't this be like scriptKind = ScriptKind[openArgs.scriptKindName] ?
I mean how many places will you need to touch if you create a new ScriptKind? You want to make it less error-prone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7291 and #7720