Skip to content

Don't error on duplicate prototype property assignments #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanCavanaugh merged 2 commits into from
Mar 1, 2016
Merged

Don't error on duplicate prototype property assignments #7268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8334aea
Don't error on duplicate prototype property assignments
RyanCavanaugh Feb 26, 2016
766439e
Update comment
RyanCavanaugh Mar 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/compiler/binder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,8 @@ namespace ts {
}

// Declare the method/property
declareSymbol(funcSymbol.members, funcSymbol, leftSideOfAssignment, SymbolFlags.Property, SymbolFlags.PropertyExcludes);
// It's acceptable for multiple prototype property assignments of the same identifier to occur
declareSymbol(funcSymbol.members, funcSymbol, leftSideOfAssignment, SymbolFlags.Property, SymbolFlags.PropertyExcludes & ~SymbolFlags.Property);

@DanielRosenwasser DanielRosenwasser Feb 26, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapt the above comment:

// It's acceptable for multiple 'Foo.prototype' assignments of the same prototype to occur

or something like that

}

function bindCallExpression(node: CallExpression) {
Expand Down
28 changes: 28 additions & 0 deletions tests/cases/fourslash/jsDocClasses1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
///<reference path="fourslash.ts" />

// @allowNonTsExtensions: true

@mhegazy mhegazy Feb 26, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not think you needed the fourslash test here. a compiler baseline test would have been more appropriate.

// @Filename: Foo.js

//// function fn() {
//// this.foo = 10;
//// }
//// fn.prototype.foo = 14;
//// var x = new fn();
////
//// function fn2() {
//// this.foo = 10;
//// this.foo = 10;
//// }
//// fn2.prototype.foo = 14;
//// fn2.prototype.foo = 14;
//// var y = new fn2();
////
//// function fn3() {
//// this.foo = 10;
//// }
//// fn3.prototype.foo = 14;
//// fn3.prototype.foo = 14;
//// var z = new fn3();

verify.numberOfErrorsInCurrentFile(0);