Super inside inner class crashes#7144
Merged
Merged
Conversation
In a class nested inside a constructor, `super` refers to the outer class' `super`, but when resolving a super call its containing class is identified as the immediately containing class. Previously, the compiler crashed, preventing the error from being reported correctly. Now it handles this disparity and correctly reports the error.
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Member
|
Any idea why GitHub thinks the testcase is binary? |
Member
Author
|
Emacs says it's UTF-16. I think the normal encoding is UTF-8. I'll reencode as UTF8 and see what happens. The reason it's UTF16 is that I was trying to make an equivalent of |
Member
Author
|
Yep. I guess git doesn't like UTF16. |
sandersn
added a commit
that referenced
this pull request
Feb 19, 2016
Super inside inner class crashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue: #6859
In a class nested inside a constructor,
superrefers to the outerclass'
super, but when resolving a super call its containing class isidentified as the immediately containing class. Previously, the compiler
crashed, preventing the error from being reported correctly. Now it
handles this disparity and correctly reports the error.