Fix ES6 decorated class double binding.#6684
Merged
Merged
Conversation
…uble binding. Fixes #5386.
Contributor
There was a problem hiding this comment.
getExportSymbolOfValueSymbolIfExported returns either a value that was initially passed or a merged symbol for an associated exported symbol so to me localSymbol is a bit misleading. In other places we call it similar values localOrExportedSymbol
Contributor
There was a problem hiding this comment.
when declaration kind might not be ClassDeclaration? I think that if checker has set BodyScopedClassBinding flag it should be enough to state that referenced declaration is class
Contributor
Author
There was a problem hiding this comment.
I added the BodyScopedClassBinding flag after adding this, and neglected to simplify the logic here.
Contributor
|
👍 with a few suggestions |
rbuckton
added a commit
that referenced
this pull request
Jan 30, 2016
Fix ES6 decorated class double binding.
Contributor
Author
|
Merged into master and cherry-picked into release-1.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a class body scoped alias to the class to avoid class name double binding.
Fixes #5386.