Repository navigation
fix: share in-flight getSourceFile requests in native-preview async API (#65503) - #65511
Open
刘亦达 (zhengdaodeguL) wants to merge 1 commit into
Open
刘亦达 (zhengdaodeguL) wants to merge 1 commit into
刘亦达 (zhengdaodeguL) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
|
刘亦达 (@zhengdaodeguL) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65503
Concurrent
Program.getSourceFilecalls for the same file each fetched the whole file from the server instead of sharing one in-flight request. This mirrors the in-flight promise-sharing pattern already used bygetSourceFileMetadata:getSourceFileandgetSourceFileByPathnow share a per-path promise held in aProgram-local map, removed infinallyso a failed fetch is retried on the next call. Retained-cache hits still return before consulting the in-flight map.Verification
concurrent getSourceFile calls share an in-flight request(10 overlapping calls against a deferred fetch): 1 underlying request. Before the fix the same test observes 10 requests.node --conditions @typescript/source --test --test-name-pattern='concurrent getSourceFile calls share an in-flight request' ./test/async/api.test.ts(1 pass, 0 fail).npm run -w @typescript/typescript buildpasses;npx hereby check:formatpasses.npx hereby test(requires building the native compiler with Go, unavailable in this environment) andnpx hereby lint. The full API integration tests needbuilt/local/tscand cannot launch here; the targeted regression test does not need it.Checklist
Backlogmilestone (required) — API client: concurrentProgram.getSourceFilecalls for one file stampede the cache, each fetching the file whole #65503 exists but has no milestone assigned yetmainbranchnpx hereby test— see the note abovenpx hereby lintnpx hereby check:format