Repository navigation
Fix incorrect last bytes sent API timing data from nested requests - #65449
Open
Andrew Branch (andrewbranch) wants to merge 1 commit into
Open
Andrew Branch (andrewbranch) wants to merge 1 commit into
Andrew Branch (andrewbranch) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the nested-request sent-byte timing fix.
No open issues 🎉
What changed in this PR
Fixes sent-byte timing data in the synchronous TypeScript API when a callback issues a nested request.
Changes:
- Restores the outer request’s sent-byte count when its response arrives.
- Adds a regression test verifying that a larger nested request does not overwrite the outer request’s recorded size.
| File | Description |
|---|---|
packages/typescript/test/sync/timing.test.ts |
Tests sent-byte timing for nested synchronous requests. |
packages/typescript/src/api/syncChannel.ts |
Recalculates sent bytes from the current request payload before returning its response. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while working on something totally unrelated