Move Iterable/AsyncIterable into main DOM/WebWorker libs by jakebailey · Pull Request #62111 · microsoft/TypeScript

jakebailey · 2025-07-23T16:47:03Z

This PR moves the contents of DOM.Iterable and DOM.AsyncIterable into DOM. DOM now references es2015 and es2018.asynciterable. DOM is now effectively evergreen.

(Same applies to webworker)

TODO:

Update DOM-lib-generator to do this
~~Double check to see if es2015 is too broad~~ Min target in 7.0 is es2015, es5 is deprecated in 6.0, so I'm not going to fuss with this
Merge Move iterables into main d.ts files in 6.0, reference es2015 and es2018.asynciterable TypeScript-DOM-lib-generator#2168

jakebailey · 2025-07-23T16:49:45Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2025-07-23T16:49:50Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-07-23T16:54:31Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/165729/artifacts?artifactName=tgz&fileId=850BA94CBF29B1799E021F58C6D50FAEA15105D55C1C30A291718B1340BEEDF502&fileName=/typescript-5.9.0-insiders.20250723.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.9.0-pr-62111-2".;

typescript-bot · 2025-07-23T17:14:02Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: es6-collections
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-collections/index.d.ts
  16:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  41:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  47:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  61:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  67:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  96:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  97:47  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 11 problems (11 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250723/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250723/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: es6-shim
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-shim/index.d.ts
    1:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  240:5   error  TypeScript@local compile error: 
All declarations of 'EPSILON' must have identical modifiers                                                                                                    @definitelytyped/expect
  275:5   error  TypeScript@local compile error: 
All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  282:5   error  TypeScript@local compile error: 
All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  338:5   error  TypeScript@local compile error: 
All declarations of 'flags' must have identical modifiers                                                                                                      @definitelytyped/expect
  502:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  567:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  576:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  587:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  597:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  624:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  625:48  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 16 problems (16 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250723/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250723/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

typescript-bot · 2025-07-23T17:16:32Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62111/merge:

Everything looks good!

typescript-bot · 2025-07-23T17:36:38Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,994k (± 0.09%)}	_{194,258k (± 0.91%)}	_~	_192,910k	_196,553k	_{p=0.173 n=6}
_{Parse Time}	_{1.31s (± 0.48%)}	_{1.30s (± 0.69%)}	_~	_1.29s	_1.31s	_{p=0.070 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.73s (± 0.31%)}	_{9.75s (± 0.22%)}	_~	_9.72s	_9.78s	_{p=0.418 n=6}
_{Emit Time}	_{2.74s (± 0.48%)}	_{2.74s (± 1.00%)}	_~	_2.71s	_2.78s	_{p=0.868 n=6}
_{Total Time}	_{14.51s (± 0.16%)}	_{14.52s (± 0.22%)}	_~	_14.47s	_14.55s	_{p=0.570 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,914	_948,717	_{-197 (- 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,884	_410,884	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,383k (± 0.00%)}	_{1,226,332k (± 0.00%)}	_~	_1,226,267k	_1,226,372k	_{p=0.128 n=6}
_{Parse Time}	_{6.51s (± 0.49%)}	_{6.52s (± 1.01%)}	_~	_6.45s	_6.62s	_{p=0.872 n=6}
_{Bind Time}	_{1.87s (± 0.28%)}	_{1.88s (± 0.27%)}	_~	_1.87s	_1.88s	_{p=0.311 n=6}
_{Check Time}	_{32.01s (± 0.25%)}	_{32.05s (± 0.54%)}	_~	_31.84s	_32.30s	_{p=0.687 n=6}
_{Emit Time}	_{14.80s (± 0.89%)}	_{14.79s (± 0.41%)}	_~	_14.70s	_14.86s	_{p=0.471 n=6}
_{Total Time}	_{55.20s (± 0.20%)}	_{55.24s (± 0.37%)}	_~	_54.92s	_55.45s	_{p=0.521 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,542,818	_2,542,538	_{-280 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_900,360	_900,360	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,829,317k (± 0.01%)}	_{2,829,140k (± 0.01%)}	_~	_2,828,874k	_2,829,347k	_{p=0.173 n=6}
_{Parse Time}	_{8.74s (± 0.27%)}	_{8.75s (± 0.28%)}	_~	_8.72s	_8.79s	_{p=0.295 n=6}
_{Bind Time}	_{2.25s (± 0.33%)}	_{2.25s (± 0.37%)}	_~	_2.25s	_2.27s	_{p=0.652 n=6}
_{Check Time}	_{85.86s (± 0.43%)}	_{85.86s (± 0.80%)}	_~	_84.93s	_86.97s	_{p=0.810 n=6}
_{Emit Time}	_{1.32s (±84.36%)}	_{0.99s (±96.40%)}	_~	_0.30s	_2.37s	_{p=0.624 n=6}
_{Total Time}	_{98.17s (± 1.15%)}	_{97.87s (± 1.46%)}	_~	_96.27s	_100.07s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,048	_1,227,048	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,470	_267,470	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,423,932k (± 6.14%)}	_{2,667,832k (±13.45%)}	_~	_2,362,968k	_3,095,006k	_{p=0.173 n=6}
_{Parse Time}	_{5.22s (± 1.09%)}	_{5.27s (± 0.94%)}	_~	_5.21s	_5.33s	_{p=0.128 n=6}
_{Bind Time}	_{1.78s (± 1.36%)}	_{1.78s (± 1.16%)}	_~	_1.74s	_1.80s	_{p=1.000 n=6}
_{Check Time}	_{35.25s (± 0.61%)}	_{35.43s (± 0.83%)}	_~	_35.05s	_35.84s	_{p=0.335 n=6}
_{Emit Time}	_{3.00s (± 0.74%)}	_{2.96s (± 2.03%)}	_~	_2.86s	_3.02s	_{p=0.295 n=6}
_{Total Time}	_{45.27s (± 0.41%)}	_{45.44s (± 0.67%)}	_~	_45.09s	_45.88s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,048	_1,227,048	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,470	_267,470	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,797,186k (±14.25%)}	_{2,676,014k (±14.05%)}	_~	_2,431,948k	_3,161,939k	_{p=1.000 n=6}
_{Parse Time}	_{6.81s (± 1.38%)}	_{6.76s (± 1.56%)}	_~	_6.68s	_6.92s	_{p=0.575 n=6}
_{Bind Time}	_{2.23s (± 2.58%)}	_{2.20s (± 2.61%)}	_~	_2.11s	_2.26s	_{p=0.377 n=6}
_{Check Time}	_{42.93s (± 1.05%)}	_{42.82s (± 0.54%)}	_~	_42.55s	_43.03s	_{p=0.471 n=6}
_{Emit Time}	_{3.54s (± 2.51%)}	_{3.56s (± 2.92%)}	_~	_3.45s	_3.73s	_{p=0.748 n=6}
_{Total Time}	_{55.50s (± 0.96%)}	_{55.36s (± 0.53%)}	_~	_54.93s	_55.62s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,548	_262,548	_~	_~	_~	_{p=1.000 n=6}
_Types	_107,156	_107,156	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,936k (± 0.02%)}	_{441,918k (± 0.02%)}	_~	_441,804k	_441,999k	_{p=0.689 n=6}
_{Parse Time}	_{4.40s (± 1.04%)}	_{4.36s (± 0.43%)}	_~	_4.33s	_4.38s	_{p=0.077 n=6}
_{Bind Time}	_{1.63s (± 0.67%)}	_{1.62s (± 0.50%)}	_~	_1.61s	_1.63s	_{p=0.383 n=6}
_{Check Time}	_{23.46s (± 0.36%)}	_{23.41s (± 0.29%)}	_~	_23.33s	_23.53s	_{p=0.423 n=6}
_{Emit Time}	_{1.91s (± 0.39%)}	_{1.89s (± 1.04%)}	_~	_1.86s	_1.91s	_{p=0.054 n=6}
_{Total Time}	_{31.40s (± 0.39%)}	_{31.28s (± 0.20%)}	_~	_31.18s	_31.35s	_{p=0.149 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,134k (± 0.01%)}	_{371,108k (± 0.01%)}	_~	_371,068k	_371,181k	_{p=0.575 n=6}
_{Parse Time}	_{2.90s (± 1.36%)}	_{2.88s (± 0.92%)}	_~	_2.84s	_2.91s	_{p=0.574 n=6}
_{Bind Time}	_{1.60s (± 0.88%)}	_{1.60s (± 1.55%)}	_~	_1.57s	_1.64s	_{p=0.746 n=6}
_{Check Time}	_{16.43s (± 0.36%)}	_{16.46s (± 0.21%)}	_~	_16.40s	_16.50s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.92s (± 0.29%)}	_{20.94s (± 0.28%)}	_~	_20.87s	_21.01s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,530,678	_3,530,396	_{-282 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,191,846	_1,191,846	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,579,300k (± 0.00%)}	_{3,579,141k (± 0.00%)}	_{-159k (- 0.00%)}	_3,579,033k	_3,579,203k	_{p=0.013 n=6}
_{Parse Time}	_{15.13s (± 0.46%)}	_{15.21s (± 0.74%)}	_~	_15.06s	_15.35s	_{p=0.192 n=6}
_{Bind Time}	_{4.90s (± 0.29%)}	_{5.14s (±12.65%)}	_~	_4.86s	_6.47s	_{p=0.295 n=6}
_{Check Time}	_{101.02s (± 1.65%)}	_{100.41s (± 4.12%)}	_~	_95.95s	_105.91s	_{p=0.378 n=6}
_{Emit Time}	_{33.05s (±17.79%)}	_{30.63s (± 1.00%)}	_~	_30.25s	_31.00s	_{p=0.689 n=6}
_{Total Time}	_{154.09s (± 4.08%)}	_{151.40s (± 2.53%)}	_~	_147.85s	_156.77s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_320,544	_321,546	_{+1,002 (+ 0.31%)}	_~	_~	_{p=0.001 n=6}
_Types	_140,017	_140,553	_{+536 (+ 0.38%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{476,545k (± 0.04%)}	_{477,783k (± 0.01%)}	_{+1,238k (+ 0.26%)}	_477,692k	_477,857k	_{p=0.005 n=6}
_{Parse Time}	_{4.29s (± 0.34%)}	_{4.30s (± 0.61%)}	_~	_4.26s	_4.33s	_{p=0.291 n=6}
_{Bind Time}	_{1.78s (± 1.35%)}	_{1.79s (± 0.76%)}	_~	_1.78s	_1.81s	_{p=0.292 n=6}
_{Check Time}	_{20.56s (± 0.58%)}	_{20.67s (± 0.70%)}	_~	_20.45s	_20.80s	_{p=0.199 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{26.64s (± 0.45%)}	_{26.76s (± 0.55%)}	_~	_26.57s	_26.91s	_{p=0.108 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_662,663	_663,032	_{+369 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_Types	_197,635	_197,637	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{569,753k (± 0.03%)}	_{570,525k (± 0.03%)}	_{+772k (+ 0.14%)}	_570,334k	_570,663k	_{p=0.005 n=6}
_{Parse Time}	_{4.28s (± 0.71%)}	_{4.27s (± 0.65%)}	_~	_4.23s	_4.31s	_{p=0.570 n=6}
_{Bind Time}	_{1.33s (± 1.46%)}	_{1.33s (± 0.78%)}	_~	_1.31s	_1.34s	_{p=0.512 n=6}
_{Check Time}	_{20.03s (± 1.85%)}	_{20.13s (± 1.82%)}	_~	_19.84s	_20.60s	_{p=0.229 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.64s (± 1.44%)}	_{25.73s (± 1.54%)}	_~	_25.41s	_26.24s	_{p=0.378 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-07-23T18:38:50Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62111/merge:

Something interesting changed - please have a look.

Details

BuilderIO/mitosis

17 of 25 projects failed to build with the old tsc and were ignored

packages/core/tsconfig.build.json

error TS2345: Argument of type '{ code: { bindings: Record<string, string>; actions: { [key: string]: string; }; }; properties: Dictionary<any> | undefined; bindings: Record<string, string>; ... 7 more ...; tagName: string | undefined; }' is not assignable to parameter of type 'Partial<BuilderElement>'.
- packages/core/src/generators/builder/generator.ts#L784 in packages/core/tsconfig.build.json

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2536: Type 'T' cannot be used to index type 'DOMStringMap'.
- src/BootstrapModalManager.tsx#L32
- src/BootstrapModalManager.tsx#L34

test/tsconfig.json

error TS2536: Type 'T' cannot be used to index type 'DOMStringMap'.
- src/BootstrapModalManager.tsx#L32
- src/BootstrapModalManager.tsx#L34

jakebailey · 2025-09-26T18:53:08Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2025-09-26T18:53:13Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-09-26T18:57:42Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/166122/artifacts?artifactName=tgz&fileId=7B6A18782044AA0878CE0A4D17063B28412FDB4CE2EA3B982ABD6A9D2B9ECE1A02&fileName=/typescript-6.0.0-insiders.20250926.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@6.0.0-pr-62111-9".;

typescript-bot · 2025-09-26T19:15:28Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: es6-shim
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-shim/index.d.ts
    1:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  240:5   error  TypeScript@local compile error: 
All declarations of 'EPSILON' must have identical modifiers                                                                                                    @definitelytyped/expect
  275:5   error  TypeScript@local compile error: 
All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  282:5   error  TypeScript@local compile error: 
All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  338:5   error  TypeScript@local compile error: 
All declarations of 'flags' must have identical modifiers                                                                                                      @definitelytyped/expect
  502:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  567:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  576:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  587:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  597:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  624:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  625:48  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 16 problems (16 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: wicg-file-system-access
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/index.d.ts
  149:9  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property '[Symbol.asyncIterator]' must be of type '() => FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>', but here has type '{ (): FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>; (): AsyncIterableIterator<[string, FileSystemFileHandle | FileSystemDirectoryHandle]>; }'  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/wicg-file-system-access-tests.ts
  56:30  error  TypeScript@local compile error: 
Property 'getFile' does not exist on type 'FileSystemHandle'                                                                                                                                                                                                                      @definitelytyped/expect
  58:43  error  TypeScript@local compile error: 
Argument of type 'FileSystemHandle' is not assignable to parameter of type 'FileSystemDirectoryHandle'.
  Type 'FileSystemHandle' is missing the following properties from type 'FileSystemDirectoryHandle': getDirectoryHandle, getFileHandle, removeEntry, resolve, and 7 more  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: es6-collections
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-collections/index.d.ts
  16:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  41:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  47:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  61:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  67:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  96:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  97:47  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 11 problems (11 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

typescript-bot · 2025-09-26T19:18:38Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62111/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2025-09-26T19:41:10Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,188k (± 1.04%)}	_{195,785k (± 0.72%)}	_~	_192,897k	_196,455k	_{p=0.810 n=6}
_{Parse Time}	_{1.57s (± 1.48%)}	_{1.61s (± 1.14%)}	_{+0.04s (+ 2.22%)}	_1.58s	_1.63s	_{p=0.028 n=6}
_{Bind Time}	_{0.88s (± 1.18%)}	_{0.87s (± 0.93%)}	_~	_0.86s	_0.88s	_{p=0.546 n=6}
_{Check Time}	_{11.72s (± 0.45%)}	_{11.72s (± 0.52%)}	_~	_11.67s	_11.81s	_{p=1.000 n=6}
_{Emit Time}	_{3.43s (± 4.38%)}	_{3.39s (± 4.74%)}	_~	_3.27s	_3.61s	_{p=0.936 n=6}
_{Total Time}	_{17.60s (± 1.00%)}	_{17.59s (± 0.77%)}	_~	_17.46s	_17.78s	_{p=0.688 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,914	_948,766	_{-148 (- 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,884	_410,928	_{+44 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,245,615k (± 0.00%)}	_{1,245,563k (± 0.01%)}	_~	_1,245,440k	_1,245,681k	_{p=0.128 n=6}
_{Parse Time}	_{6.54s (± 0.62%)}	_{6.53s (± 0.83%)}	_~	_6.46s	_6.59s	_{p=1.000 n=6}
_{Bind Time}	_{1.87s (± 0.28%)}	_{1.87s (± 0.52%)}	_~	_1.86s	_1.89s	_{p=0.504 n=6}
_{Check Time}	_{32.21s (± 0.35%)}	_{32.16s (± 0.25%)}	_~	_32.06s	_32.27s	_{p=0.422 n=6}
_{Emit Time}	_{14.80s (± 0.35%)}	_{14.78s (± 0.43%)}	_~	_14.67s	_14.84s	_{p=0.748 n=6}
_{Total Time}	_{55.42s (± 0.17%)}	_{55.34s (± 0.23%)}	_~	_55.15s	_55.48s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,544,618	_2,544,351	_{-267 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_903,213	_903,216	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,830,018k (± 0.00%)}	_{2,829,930k (± 0.01%)}	_~	_2,829,635k	_2,830,063k	_{p=0.471 n=6}
_{Parse Time}	_{8.72s (± 0.37%)}	_{8.71s (± 0.34%)}	_~	_8.68s	_8.75s	_{p=0.462 n=6}
_{Bind Time}	_{2.21s (± 0.67%)}	_{2.19s (± 0.24%)}	_{-0.02s (- 0.98%)}	_2.18s	_2.19s	_{p=0.010 n=6}
_{Check Time}	_{86.51s (± 0.98%)}	_{86.52s (± 0.95%)}	_~	_85.73s	_88.05s	_{p=1.000 n=6}
_{Emit Time}	_{0.62s (±124.58%)}	_{0.31s (± 1.68%)}	_~	_0.30s	_0.31s	_{p=0.784 n=6}
_{Total Time}	_{98.06s (± 1.20%)}	_{97.73s (± 0.84%)}	_~	_96.95s	_99.23s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,064	_1,237,064	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,743	_259,743	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,364,171k (± 0.01%)}	_{2,485,784k (±11.94%)}	_~	_2,364,361k	_3,092,216k	_{p=0.066 n=6}
_{Parse Time}	_{5.12s (± 1.05%)}	_{5.14s (± 1.32%)}	_~	_5.03s	_5.24s	_{p=0.687 n=6}
_{Bind Time}	_{1.77s (± 0.62%)}	_{1.78s (± 0.77%)}	_~	_1.76s	_1.80s	_{p=0.357 n=6}
_{Check Time}	_{35.14s (± 0.29%)}	_{35.28s (± 0.46%)}	_~	_35.07s	_35.57s	_{p=0.054 n=6}
_{Emit Time}	_{3.01s (± 1.31%)}	_{3.00s (± 1.00%)}	_~	_2.96s	_3.04s	_{p=0.747 n=6}
_{Total Time}	_{45.05s (± 0.29%)}	_{45.20s (± 0.51%)}	_~	_44.98s	_45.64s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,064	_1,237,064	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,743	_259,743	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,158,255k (± 0.01%)}	_{3,157,422k (± 0.02%)}	_{-833k (- 0.03%)}	_3,156,561k	_3,158,576k	_{p=0.045 n=6}
_{Parse Time}	_{6.87s (± 1.05%)}	_{6.79s (± 0.66%)}	_{-0.08s (- 1.12%)}	_6.73s	_6.85s	_{p=0.045 n=6}
_{Bind Time}	_{2.14s (± 0.87%)}	_{2.15s (± 0.90%)}	_~	_2.12s	_2.17s	_{p=0.373 n=6}
_{Check Time}	_{42.57s (± 0.24%)}	_{42.54s (± 0.44%)}	_~	_42.34s	_42.83s	_{p=0.936 n=6}
_{Emit Time}	_{3.53s (± 1.85%)}	_{3.54s (± 1.31%)}	_~	_3.49s	_3.61s	_{p=1.000 n=6}
_{Total Time}	_{55.10s (± 0.25%)}	_{55.03s (± 0.28%)}	_~	_54.88s	_55.28s	_{p=0.336 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,412	_262,412	_~	_~	_~	_{p=1.000 n=6}
_Types	_103,924	_103,924	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,564k (± 0.04%)}	_{440,471k (± 0.02%)}	_~	_440,349k	_440,545k	_{p=0.689 n=6}
_{Parse Time}	_{2.87s (± 0.65%)}	_{2.88s (± 0.36%)}	_~	_2.86s	_2.89s	_{p=0.684 n=6}
_{Bind Time}	_{1.11s (± 0.73%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.929 n=6}
_{Check Time}	_{15.85s (± 0.27%)}	_{15.87s (± 0.17%)}	_~	_15.84s	_15.90s	_{p=0.685 n=6}
_{Emit Time}	_{1.32s (± 0.78%)}	_{1.31s (± 0.92%)}	_~	_1.30s	_1.33s	_{p=0.675 n=6}
_{Total Time}	_{21.16s (± 0.13%)}	_{21.17s (± 0.10%)}	_~	_21.14s	_21.20s	_{p=0.293 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,072k (± 0.05%)}	_{370,013k (± 0.05%)}	_~	_369,881k	_370,342k	_{p=0.575 n=6}
_{Parse Time}	_{2.85s (± 0.54%)}	_{2.84s (± 0.73%)}	_~	_2.81s	_2.86s	_{p=0.250 n=6}
_{Bind Time}	_{1.61s (± 1.09%)}	_{1.59s (± 1.41%)}	_~	_1.56s	_1.63s	_{p=0.255 n=6}
_{Check Time}	_{16.47s (± 0.18%)}	_{16.44s (± 0.42%)}	_~	_16.36s	_16.54s	_{p=0.335 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{20.93s (± 0.18%)}	_{20.88s (± 0.41%)}	_~	_20.79s	_21.01s	_{p=0.229 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₄	_{🔻+1 (+33.33%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_3,884,524	_3,884,386	_{-138 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,222,624	_1,222,727	_{+103 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,700,830k (± 0.01%)}	_{3,700,824k (± 0.01%)}	_~	_3,700,446k	_3,701,079k	_{p=0.873 n=6}
_{Parse Time}	_{15.11s (± 0.68%)}	_{15.27s (± 0.49%)}	_{+0.16s (+ 1.06%)}	_15.15s	_15.35s	_{p=0.031 n=6}
_{Bind Time}	_{4.94s (± 0.59%)}	_{4.91s (± 0.54%)}	_~	_4.87s	_4.94s	_{p=0.076 n=6}
_{Check Time}	_{102.40s (± 3.21%)}	_{102.29s (± 3.66%)}	_~	_98.86s	_108.10s	_{p=0.810 n=6}
_{Emit Time}	_{35.58s (±17.79%)}	_{33.23s (±12.25%)}	_~	_30.45s	_39.60s	_{p=0.689 n=6}
_{Total Time}	_{158.03s (± 3.37%)}	_{155.70s (± 4.55%)}	_~	_149.97s	_167.93s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₃₈	₃₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_361,753	_362,835	_{+1,082 (+ 0.30%)}	_~	_~	_{p=0.001 n=6}
_Types	_158,862	_159,472	_{+610 (+ 0.38%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{516,461k (± 0.01%)}	_{519,853k (± 0.02%)}	_{+3,392k (+ 0.66%)}	_519,784k	_519,971k	_{p=0.005 n=6}
_{Parse Time}	_{4.43s (± 0.48%)}	_{4.45s (± 1.02%)}	_~	_4.40s	_4.52s	_{p=0.517 n=6}
_{Bind Time}	_{1.92s (± 1.89%)}	_{1.94s (± 1.75%)}	_~	_1.90s	_1.98s	_{p=0.517 n=6}
_{Check Time}	_{21.80s (± 0.35%)}	_{21.97s (± 0.42%)}	_{+0.17s (+ 0.76%)}	_21.83s	_22.09s	_{p=0.020 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{28.16s (± 0.39%)}	_{28.36s (± 0.40%)}	_{+0.21s (+ 0.73%)}	_28.21s	_28.48s	_{p=0.020 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_672,791	_673,174	_{+383 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_Types	_201,962	_201,964	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{574,873k (± 0.02%)}	_{575,586k (± 0.03%)}	_{+713k (+ 0.12%)}	_575,336k	_575,773k	_{p=0.005 n=6}
_{Parse Time}	_{4.17s (± 0.61%)}	_{4.20s (± 0.70%)}	_{+0.03s (+ 0.72%)}	_4.15s	_4.24s	_{p=0.043 n=6}
_{Bind Time}	_{1.35s (± 1.21%)}	_{1.34s (± 0.99%)}	_~	_1.32s	_1.36s	_{p=0.553 n=6}
_{Check Time}	_{20.62s (± 2.10%)}	_{20.48s (± 1.46%)}	_~	_20.20s	_20.88s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.13s (± 1.72%)}	_{26.03s (± 1.13%)}	_~	_25.78s	_26.41s	_{p=0.689 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2025-09-26T20:05:28Z

@saschanaz Just as an FYI, this is something we're planning on taking for 6.0, to settle this all once and for all. So, DOM will once again be evergreen.

saschanaz · 2025-09-26T20:09:02Z

@saschanaz Just as an FYI, this is something we're planning on taking for 6.0, to settle this all once and for all. So, DOM will once again be evergreen.

Cool. While we are at it, can we please stop calling it DOM (or at least add an alias)? That's very very small portion of what we have in the lib...

typescript-bot · 2025-09-26T20:10:28Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62111/merge:

Something interesting changed - please have a look.

Details

omnivore-app/omnivore

11 of 25 projects failed to build with the old tsc and were ignored

packages/api/tsconfig.json

error TS2345: Argument of type 'ChatOpenAI<ChatOpenAICallOptions>' is not assignable to parameter of type 'BaseLanguageModelInterface<any, BaseLanguageModelCallOptions>'.
- packages/api/src/jobs/ai-summarize.ts#L65
error TS2345: Argument of type 'OpenAI<OpenAICallOptions>' is not assignable to parameter of type 'RunnableLike<ChatPromptValueInterface, string>'.
- packages/api/src/jobs/ai/create_digest.ts#L267
error TS2345: Argument of type 'OpenAI<OpenAICallOptions>' is not assignable to parameter of type 'RunnableLike<StringPromptValueInterface, string>'.
error TS2345: Argument of type 'JsonOutputParser<Record<string, any>>' is not assignable to parameter of type 'RunnableLike<string, Record<string, any>>'.
- packages/api/src/jobs/ai/create_digest.ts#L312

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2536: Type 'T' cannot be used to index type 'DOMStringMap'.
- src/BootstrapModalManager.tsx#L32
- src/BootstrapModalManager.tsx#L34

test/tsconfig.json

error TS2536: Type 'T' cannot be used to index type 'DOMStringMap'.
- src/BootstrapModalManager.tsx#L32
- src/BootstrapModalManager.tsx#L34

saschanaz · 2025-09-26T20:32:52Z

Update DOM-lib-generator to do this

Do you have a plan how to do this? Add another subdirectory in baselines?

jakebailey · 2025-09-26T20:39:34Z

Yes, same diff as we did for the 5.8/5.6 dirs; I will send a patch soon.

jakebailey · 2025-09-26T21:09:54Z

Cool. While we are at it, can we please stop calling it DOM (or at least add an alias)? That's very very small portion of what we have in the lib...

I don't see this happening, really ☹️

What would you suggest, if you had to choose? web?

saschanaz · 2025-09-26T22:47:26Z

What would you suggest, if you had to choose? web?

either web or webapi. I'd be fine having dom as a legacy alias of a new name, but it should really not be the only name 🥺

jakebailey · 2025-10-02T17:54:58Z

@typescript-bot test it

typescript-bot · 2025-10-02T17:55:04Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-10-02T18:19:11Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: es6-shim
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-shim/index.d.ts
    1:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  240:5   error  TypeScript@local compile error: 
All declarations of 'EPSILON' must have identical modifiers                                                                                                    @definitelytyped/expect
  275:5   error  TypeScript@local compile error: 
All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  282:5   error  TypeScript@local compile error: 
All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  338:5   error  TypeScript@local compile error: 
All declarations of 'flags' must have identical modifiers                                                                                                      @definitelytyped/expect
  502:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  567:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  576:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  587:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  597:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  624:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  625:48  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 16 problems (16 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: wicg-file-system-access
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/index.d.ts
  149:9  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property '[Symbol.asyncIterator]' must be of type '() => FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>', but here has type '{ (): FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>; (): AsyncIterableIterator<[string, FileSystemFileHandle | FileSystemDirectoryHandle]>; }'  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/wicg-file-system-access-tests.ts
  56:30  error  TypeScript@local compile error: 
Property 'getFile' does not exist on type 'FileSystemHandle'                                                                                                                                                                                                                      @definitelytyped/expect
  58:43  error  TypeScript@local compile error: 
Argument of type 'FileSystemHandle' is not assignable to parameter of type 'FileSystemDirectoryHandle'.
  Type 'FileSystemHandle' is missing the following properties from type 'FileSystemDirectoryHandle': getDirectoryHandle, getFileHandle, removeEntry, resolve, and 7 more  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: es6-collections
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-collections/index.d.ts
  16:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  41:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  47:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  61:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  67:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  96:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  97:47  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 11 problems (11 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

typescript-bot · 2025-10-02T18:23:38Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62111/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2025-10-02T18:45:26Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,530k (± 1.09%)}	_{196,380k (± 0.07%)}	_~	_196,168k	_196,554k	_{p=0.471 n=6}
_{Parse Time}	_{1.59s (± 1.22%)}	_{1.58s (± 1.16%)}	_~	_1.55s	_1.60s	_{p=0.607 n=6}
_{Bind Time}	_{0.88s (± 0.59%)}	_{0.89s (± 1.56%)}	_~	_0.87s	_0.91s	_{p=0.242 n=6}
_{Check Time}	_{11.73s (± 0.32%)}	_{11.71s (± 0.50%)}	_~	_11.63s	_11.78s	_{p=0.377 n=6}
_{Emit Time}	_{3.41s (± 4.23%)}	_{3.32s (± 3.04%)}	_~	_3.26s	_3.53s	_{p=0.416 n=6}
_{Total Time}	_{17.61s (± 0.66%)}	_{17.50s (± 0.78%)}	_~	_17.40s	_17.77s	_{p=0.093 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_954,914	_955,117	_{+203 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_415,571	_415,619	_{+48 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,254,044k (± 0.00%)}	_{1,254,601k (± 0.00%)}	_{+557k (+ 0.04%)}	_1,254,542k	_1,254,668k	_{p=0.005 n=6}
_{Parse Time}	_{6.53s (± 0.64%)}	_{6.51s (± 1.29%)}	_~	_6.45s	_6.66s	_{p=0.374 n=6}
_{Bind Time}	_{1.88s (± 0.48%)}	_{1.88s (± 0.29%)}	_~	_1.88s	_1.89s	_{p=0.341 n=6}
_{Check Time}	_{32.20s (± 0.38%)}	_{32.20s (± 0.26%)}	_~	_32.11s	_32.35s	_{p=1.000 n=6}
_{Emit Time}	_{14.84s (± 0.33%)}	_{14.88s (± 0.50%)}	_~	_14.79s	_14.97s	_{p=0.336 n=6}
_{Total Time}	_{55.46s (± 0.23%)}	_{55.47s (± 0.32%)}	_~	_55.25s	_55.68s	_{p=0.872 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_557,130	_556,863	_{-267 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	₈₉	₈₉	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{836,650k (± 0.01%)}	_{836,510k (± 0.01%)}	_{-139k (- 0.02%)}	_836,464k	_836,678k	_{p=0.030 n=6}
_{Parse Time}	_{10.57s (± 0.35%)}	_{10.58s (± 0.30%)}	_~	_10.52s	_10.62s	_{p=0.683 n=6}
_{Bind Time}	_{2.71s (± 0.75%)}	_{2.70s (± 0.56%)}	_~	_2.68s	_2.72s	_{p=0.330 n=6}
_{Check Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Emit Time}	_{0.34s (± 2.63%)}	_{0.34s (± 2.22%)}	_~	_0.33s	_0.35s	_{p=0.798 n=6}
_{Total Time}	_{13.62s (± 0.24%)}	_{13.61s (± 0.24%)}	_~	_13.56s	_13.64s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,220	_1,237,220	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,836	_259,836	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,852,829k (±13.15%)}	_{3,095,493k (± 0.03%)}	_~	_3,093,975k	_3,096,126k	_{p=0.173 n=6}
_{Parse Time}	_{6.60s (± 1.76%)}	_{6.62s (± 0.67%)}	_~	_6.54s	_6.66s	_{p=0.689 n=6}
_{Bind Time}	_{2.15s (± 1.60%)}	_{2.14s (± 1.40%)}	_~	_2.10s	_2.18s	_{p=0.687 n=6}
_{Check Time}	_{42.40s (± 0.42%)}	_{42.56s (± 0.37%)}	_~	_42.32s	_42.80s	_{p=0.128 n=6}
_{Emit Time}	_{3.48s (± 2.36%)}	_{3.49s (± 2.43%)}	_~	_3.40s	_3.61s	_{p=0.810 n=6}
_{Total Time}	_{54.62s (± 0.53%)}	_{54.80s (± 0.44%)}	_~	_54.44s	_55.16s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,220	_1,237,220	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,836	_259,836	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,159,315k (± 0.02%)}	_{3,037,652k (± 9.73%)}	_~	_2,433,785k	_3,159,291k	_{p=0.093 n=6}
_{Parse Time}	_{6.85s (± 0.53%)}	_{6.79s (± 1.48%)}	_~	_6.60s	_6.89s	_{p=0.261 n=6}
_{Bind Time}	_{2.16s (± 0.81%)}	_{2.17s (± 0.86%)}	_~	_2.15s	_2.19s	_{p=0.676 n=6}
_{Check Time}	_{42.55s (± 0.26%)}	_{42.48s (± 0.76%)}	_~	_42.03s	_42.96s	_{p=0.575 n=6}
_{Emit Time}	_{3.53s (± 2.57%)}	_{3.54s (± 4.41%)}	_~	_3.36s	_3.82s	_{p=0.810 n=6}
_{Total Time}	_{55.11s (± 0.30%)}	_{54.97s (± 0.83%)}	_~	_54.35s	_55.41s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,524	_262,524	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,015	_104,015	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,594k (± 0.02%)}	_{440,633k (± 0.01%)}	_~	_440,596k	_440,696k	_{p=0.336 n=6}
_{Parse Time}	_{3.52s (± 1.03%)}	_{3.51s (± 1.23%)}	_~	_3.45s	_3.57s	_{p=0.686 n=6}
_{Bind Time}	_{1.32s (± 0.62%)}	_{1.32s (± 1.12%)}	_~	_1.30s	_1.34s	_{p=0.508 n=6}
_{Check Time}	_{18.99s (± 0.39%)}	_{19.02s (± 0.60%)}	_~	_18.90s	_19.17s	_{p=0.748 n=6}
_{Emit Time}	_{1.52s (± 1.58%)}	_{1.53s (± 0.89%)}	_~	_1.50s	_1.54s	_{p=0.188 n=6}
_{Total Time}	_{25.35s (± 0.21%)}	_{25.37s (± 0.58%)}	_~	_25.20s	_25.58s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,144k (± 0.06%)}	_{370,131k (± 0.03%)}	_~	_370,020k	_370,265k	_{p=0.936 n=6}
_{Parse Time}	_{2.85s (± 1.83%)}	_{2.85s (± 0.91%)}	_~	_2.81s	_2.87s	_{p=1.000 n=6}
_{Bind Time}	_{1.61s (± 1.08%)}	_{1.60s (± 0.75%)}	_~	_1.59s	_1.62s	_{p=0.188 n=6}
_{Check Time}	_{16.45s (± 0.28%)}	_{16.45s (± 0.33%)}	_~	_16.38s	_16.50s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.91s (± 0.31%)}	_{20.90s (± 0.31%)}	_~	_20.79s	_20.97s	_{p=0.747 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₅	₆	_{🔻+1 (+20.00%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_3,903,045	_3,902,896	_{-149 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,228,305	_1,228,385	_{+80 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,715,736k (± 0.01%)}	_{3,715,631k (± 0.01%)}	_~	_3,715,351k	_3,715,922k	_{p=0.378 n=6}
_{Parse Time}	_{15.35s (± 0.21%)}	_{15.30s (± 0.51%)}	_~	_15.21s	_15.41s	_{p=0.258 n=6}
_{Bind Time}	_{4.93s (± 0.70%)}	_{4.92s (± 0.33%)}	_~	_4.91s	_4.95s	_{p=0.871 n=6}
_{Check Time}	_{102.44s (± 3.06%)}	_{102.09s (± 2.56%)}	_~	_99.41s	_106.35s	_{p=0.810 n=6}
_{Emit Time}	_{33.80s (±19.73%)}	_{35.77s (± 7.87%)}	_~	_30.64s	_37.79s	_{p=0.173 n=6}
_{Total Time}	_{156.52s (± 3.58%)}	_{158.10s (± 2.46%)}	_~	_154.08s	_164.28s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₃₉	₃₉	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_370,006	_371,088	_{+1,082 (+ 0.29%)}	_~	_~	_{p=0.001 n=6}
_Types	_161,904	_162,501	_{+597 (+ 0.37%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{524,648k (± 0.02%)}	_{526,177k (± 0.01%)}	_{+1,528k (+ 0.29%)}	_526,097k	_526,248k	_{p=0.005 n=6}
_{Parse Time}	_{4.46s (± 0.59%)}	_{4.47s (± 1.06%)}	_~	_4.39s	_4.52s	_{p=0.805 n=6}
_{Bind Time}	_{1.91s (± 0.96%)}	_{1.92s (± 1.49%)}	_~	_1.89s	_1.97s	_{p=0.418 n=6}
_{Check Time}	_{21.90s (± 0.48%)}	_{22.00s (± 0.19%)}	_~	_21.95s	_22.06s	_{p=0.053 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{28.27s (± 0.35%)}	_{28.39s (± 0.21%)}	_~	_28.27s	_28.43s	_{p=0.077 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_673,247	_673,630	_{+383 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_Types	_202,036	_202,036	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{575,503k (± 0.02%)}	_{576,150k (± 0.03%)}	_{+648k (+ 0.11%)}	_576,025k	_576,370k	_{p=0.005 n=6}
_{Parse Time}	_{4.19s (± 0.85%)}	_{4.18s (± 0.65%)}	_~	_4.16s	_4.23s	_{p=1.000 n=6}
_{Bind Time}	_{1.34s (± 1.19%)}	_{1.35s (± 1.58%)}	_~	_1.33s	_1.38s	_{p=0.462 n=6}
_{Check Time}	_{20.61s (± 1.80%)}	_{20.75s (± 1.76%)}	_~	_20.24s	_21.03s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.14s (± 1.40%)}	_{26.29s (± 1.49%)}	_~	_25.75s	_26.60s	_{p=0.575 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-10-02T19:11:30Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62111/merge:

Something interesting changed - please have a look.

Details

omnivore-app/omnivore

12 of 25 projects failed to build with the old tsc and were ignored

packages/api/tsconfig.json

error TS2345: Argument of type 'ChatOpenAI<ChatOpenAICallOptions>' is not assignable to parameter of type 'BaseLanguageModelInterface<any, BaseLanguageModelCallOptions>'.
- packages/api/src/jobs/ai-summarize.ts#L65
error TS2345: Argument of type 'OpenAI<OpenAICallOptions>' is not assignable to parameter of type 'RunnableLike<ChatPromptValueInterface, string>'.
- packages/api/src/jobs/ai/create_digest.ts#L267
error TS2345: Argument of type 'OpenAI<OpenAICallOptions>' is not assignable to parameter of type 'RunnableLike<StringPromptValueInterface, string>'.
error TS2345: Argument of type 'JsonOutputParser<Record<string, any>>' is not assignable to parameter of type 'RunnableLike<string, Record<string, any>>'.
- packages/api/src/jobs/ai/create_digest.ts#L312

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2536: Type 'T' cannot be used to index type 'DOMStringMap'.
- src/BootstrapModalManager.tsx#L32
- src/BootstrapModalManager.tsx#L34

test/tsconfig.json

error TS2536: Type 'T' cannot be used to index type 'DOMStringMap'.
- src/BootstrapModalManager.tsx#L32
- src/BootstrapModalManager.tsx#L34

jakebailey · 2025-10-02T20:02:32Z

DT errors are:

shim packages (es6-shim, es6-collections) that try to define old environments. But now DOM loads es6 so they break. Fix is probably to not include dom types in those packages, or just drop them.
wicg-file-system-access not matching DOM. Common problem, solvable with fixes or typesVersions.

Perf benchmark shows VS Code regressing. This is also due to wicg-file-system-access.

Top tests:

omnivore: not sure what's going on here. Seems unrelated but clearly it's regressing somehow. It's some langchain code so not where where DOM comes into play.
react-bootstrap: They are assuming they can index all CSS declaration types into HTMLElement, which doesn't work now that CSSStyleDeclaration has async members.

Neither affect a public API.

But, in general, it's just the addition of *.{,Async}Iterable that are causing this. All of these problems can happen today. So there's nothing super scary here at all.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

typescript-bot assigned jakebailey Jul 23, 2025

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 23, 2025

jakebailey force-pushed the jabaile/dom-es6 branch from c05d405 to 9483d42 Compare September 22, 2025 19:54

jakebailey changed the title ~~Move DOM.Iterable contents to DOM, make DOM reference ES6/ES2015~~ Move DOM.Iterable/AsyncIterable into DOM Sep 26, 2025

jakebailey mentioned this pull request Sep 26, 2025

tsconfig.json "lib": "dom" should include "dom.iterable"(?) #60959

Closed

jakebailey mentioned this pull request Sep 26, 2025

Move iterables into main d.ts files in 6.0, reference es2015 and es2018.asynciterable microsoft/TypeScript-DOM-lib-generator#2168

Merged

jakebailey mentioned this pull request Sep 26, 2025

Update DOM types #62496

Merged

jakebailey added 2 commits October 2, 2025 10:46

Update libs

2cbc313

Update baselines

acc2fce

jakebailey force-pushed the jabaile/dom-es6 branch from 5116cfa to acc2fce Compare October 2, 2025 17:54

jakebailey changed the title ~~Move DOM.Iterable/AsyncIterable into DOM~~ Move Iterable/AsyncIterable into main DOM/WebWorker libs Oct 2, 2025

jakebailey marked this pull request as ready for review October 2, 2025 20:33

jakebailey requested review from DanielRosenwasser, RyanCavanaugh, andrewbranch, Copilot and sandersn October 2, 2025 20:33

Copilot AI reviewed Oct 2, 2025

View reviewed changes

andrewbranch approved these changes Oct 2, 2025

View reviewed changes

RyanCavanaugh approved these changes Oct 2, 2025

View reviewed changes

jakebailey merged commit ced90d9 into microsoft:main Oct 2, 2025
33 checks passed

jakebailey deleted the jabaile/dom-es6 branch October 2, 2025 22:52

DanielRosenwasser mentioned this pull request Oct 16, 2025

Design Meeting Notes, 9/26/2025 #62615

Closed

Conversation

jakebailey commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Jul 23, 2025

Uh oh!

typescript-bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 23, 2025

Uh oh!

typescript-bot commented Jul 23, 2025

Uh oh!

typescript-bot commented Jul 23, 2025

tsc

Uh oh!

typescript-bot commented Jul 23, 2025

Uh oh!

jakebailey commented Sep 26, 2025

Uh oh!

typescript-bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 26, 2025

Uh oh!

typescript-bot commented Sep 26, 2025

Uh oh!

typescript-bot commented Sep 26, 2025

tsc

Uh oh!

jakebailey commented Sep 26, 2025

Uh oh!

saschanaz commented Sep 26, 2025

Uh oh!

typescript-bot commented Sep 26, 2025

Uh oh!

saschanaz commented Sep 26, 2025

Uh oh!

jakebailey commented Sep 26, 2025

Uh oh!

jakebailey commented Sep 26, 2025

Uh oh!

saschanaz commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Oct 2, 2025

Uh oh!

typescript-bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 2, 2025

Uh oh!

typescript-bot commented Oct 2, 2025

Uh oh!

typescript-bot commented Oct 2, 2025

tsc

Uh oh!

typescript-bot commented Oct 2, 2025

Uh oh!

jakebailey commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jakebailey commented Jul 23, 2025 •

edited

Loading

typescript-bot commented Jul 23, 2025 •

edited

Loading

typescript-bot commented Jul 23, 2025 •

edited

Loading

typescript-bot commented Sep 26, 2025 •

edited

Loading

typescript-bot commented Sep 26, 2025 •

edited

Loading

saschanaz commented Sep 26, 2025 •

edited

Loading

typescript-bot commented Oct 2, 2025 •

edited

Loading

jakebailey commented Oct 2, 2025 •

edited

Loading