Fix getResolvePackageJsonImports utility#61707
Merged
andrewbranch merged 1 commit intomicrosoft:mainfrom May 16, 2025
Merged
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the bug in the getResolvePackageJsonImports utility by updating the configuration property check. The change ensures that the code uses compilerOptions.resolvePackageJsonImports instead of the incorrect resolvePackageJsonExports.
- Updated the conditional check from resolvePackageJsonExports to resolvePackageJsonImports.
- Ensured proper handling based on the new configuration property.
Comments suppressed due to low confidence (1)
src/compiler/utilities.ts:9060
- The conditional check now correctly validates compilerOptions.resolvePackageJsonImports, fixing the bug where an incorrect property was used.
if (compilerOptions.resolvePackageJsonImports !== undefined) {
sheetalkamat
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug @weswigham noticed in microsoft/typescript-go#791