Add type definitions for `Uint8Array` to/from base64 methods by dontwanttothink · Pull Request #61696 · microsoft/TypeScript

dontwanttothink · 2025-05-13T02:05:32Z

See #61695, which this pull request attempts to fix

typescript-bot · 2025-05-13T02:05:36Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

dontwanttothink · 2025-05-13T02:11:12Z

@microsoft-github-policy-service agree

src/lib/esnext.array.d.ts

dontwanttothink · 2025-07-01T21:37:26Z

Chrome, the last browser to not support this feature by default, has been shipping it since M138 behind a flag. It is set to be enabled in M140, which lands in the Stable release channel by the end of next month. See this and this.

filipesmedeiros · 2025-09-03T10:19:37Z

Officially shipped in Chrome 140

jakebailey · 2025-09-22T18:46:42Z

This PR needs a merge from main in order to be mergable.

src/lib/esnext.array.d.ts

jakebailey · 2025-09-30T20:05:55Z

This all seems fine, but, double checking:

@typescript-bot test it

typescript-bot · 2025-09-30T20:06:02Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-09-30T20:34:10Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-09-30T20:41:03Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61696/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2025-09-30T20:59:47Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,835k (± 0.73%)}	_{194,370k (± 1.02%)}	_{-1,465k (- 0.75%)}	_192,489k	_196,277k	_{p=0.020 n=6}
_{Parse Time}	_{1.60s (± 1.09%)}	_{1.60s (± 0.94%)}	_~	_1.59s	_1.63s	_{p=0.802 n=6}
_{Bind Time}	_{0.88s (± 1.61%)}	_{0.87s (± 1.39%)}	_~	_0.85s	_0.88s	_{p=0.493 n=6}
_{Check Time}	_{11.76s (± 0.52%)}	_{11.76s (± 0.41%)}	_~	_11.69s	_11.81s	_{p=0.936 n=6}
_{Emit Time}	_{3.39s (± 4.17%)}	_{3.54s (± 1.31%)}	_~	_3.48s	_3.61s	_{p=0.173 n=6}
_{Total Time}	_{17.64s (± 0.85%)}	_{17.77s (± 0.46%)}	_~	_17.66s	_17.85s	_{p=0.093 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,812	_948,812	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,869	_410,869	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,245,565k (± 0.01%)}	_{1,245,668k (± 0.01%)}	_{+103k (+ 0.01%)}	_1,245,584k	_1,245,779k	_{p=0.031 n=6}
_{Parse Time}	_{8.00s (± 0.74%)}	_{7.97s (± 1.01%)}	_~	_7.85s	_8.07s	_{p=0.421 n=6}
_{Bind Time}	_{2.27s (± 0.61%)}	_{2.28s (± 0.62%)}	_~	_2.26s	_2.30s	_{p=0.623 n=6}
_{Check Time}	_{38.26s (± 0.35%)}	_{38.27s (± 0.40%)}	_~	_38.16s	_38.56s	_{p=0.872 n=6}
_{Emit Time}	_{17.83s (± 0.21%)}	_{17.93s (± 0.63%)}	_~	_17.77s	_18.04s	_{p=0.228 n=6}
_{Total Time}	_{66.36s (± 0.19%)}	_{66.45s (± 0.30%)}	_~	_66.19s	_66.79s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,545,301	_2,545,301	_~	_~	_~	_{p=1.000 n=6}
_Types	_903,489	_903,489	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,830,481k (± 0.00%)}	_{2,830,467k (± 0.01%)}	_~	_2,830,251k	_2,830,668k	_{p=0.936 n=6}
_{Parse Time}	_{10.56s (± 0.54%)}	_{10.55s (± 0.41%)}	_~	_10.50s	_10.60s	_{p=0.871 n=6}
_{Bind Time}	_{2.69s (± 0.66%)}	_{2.68s (± 0.72%)}	_~	_2.66s	_2.71s	_{p=0.416 n=6}
_{Check Time}	_{104.95s (± 1.91%)}	_{105.57s (± 1.97%)}	_~	_102.69s	_108.42s	_{p=0.471 n=6}
_{Emit Time}	_{0.38s (± 1.46%)}	_{0.38s (± 1.99%)}	_~	_0.37s	_0.39s	_{p=0.476 n=6}
_{Total Time}	_{118.58s (± 1.74%)}	_{119.19s (± 1.76%)}	_~	_116.34s	_122.09s	_{p=0.471 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,200	_1,237,210	_{+10 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,829	_259,849	_{+20 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,094,586k (± 0.03%)}	_{3,095,929k (± 0.03%)}	_{+1,344k (+ 0.04%)}	_3,094,609k	_3,097,264k	_{p=0.045 n=6}
_{Parse Time}	_{6.64s (± 0.62%)}	_{6.61s (± 0.76%)}	_~	_6.55s	_6.68s	_{p=0.229 n=6}
_{Bind Time}	_{2.10s (± 1.33%)}	_{2.12s (± 1.33%)}	_~	_2.08s	_2.16s	_{p=0.296 n=6}
_{Check Time}	_{42.36s (± 0.27%)}	_{42.37s (± 0.26%)}	_~	_42.15s	_42.46s	_{p=0.689 n=6}
_{Emit Time}	_{3.53s (± 1.69%)}	_{3.45s (± 2.49%)}	_~	_3.35s	_3.58s	_{p=0.149 n=6}
_{Total Time}	_{54.63s (± 0.27%)}	_{54.56s (± 0.36%)}	_~	_54.25s	_54.76s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,200	_1,237,210	_{+10 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,829	_259,849	_{+20 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,158,826k (± 0.04%)}	_{3,159,659k (± 0.04%)}	_~	_3,158,641k	_3,161,832k	_{p=0.298 n=6}
_{Parse Time}	_{6.81s (± 0.46%)}	_{6.88s (± 0.47%)}	_{+0.06s (+ 0.93%)}	_6.82s	_6.91s	_{p=0.013 n=6}
_{Bind Time}	_{2.17s (± 1.21%)}	_{2.15s (± 1.38%)}	_~	_2.10s	_2.19s	_{p=0.335 n=6}
_{Check Time}	_{42.74s (± 0.34%)}	_{42.62s (± 0.19%)}	_~	_42.49s	_42.73s	_{p=0.128 n=6}
_{Emit Time}	_{3.56s (± 3.30%)}	_{3.51s (± 1.26%)}	_~	_3.45s	_3.57s	_{p=0.521 n=6}
_{Total Time}	_{55.28s (± 0.46%)}	_{55.16s (± 0.24%)}	_~	_54.93s	_55.31s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,515	_262,525	_{+10 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,009	_104,029	_{+20 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{440,616k (± 0.01%)}	_{440,600k (± 0.01%)}	_~	_440,558k	_440,631k	_{p=1.000 n=6}
_{Parse Time}	_{3.49s (± 0.48%)}	_{3.51s (± 1.27%)}	_~	_3.47s	_3.57s	_{p=0.732 n=6}
_{Bind Time}	_{1.32s (± 1.12%)}	_{1.32s (± 1.14%)}	_~	_1.30s	_1.34s	_{p=0.462 n=6}
_{Check Time}	_{18.98s (± 0.48%)}	_{18.99s (± 0.30%)}	_~	_18.89s	_19.06s	_{p=0.748 n=6}
_{Emit Time}	_{1.54s (± 0.54%)}	_{1.53s (± 1.73%)}	_~	_1.49s	_1.56s	_{p=1.000 n=6}
_{Total Time}	_{25.32s (± 0.43%)}	_{25.36s (± 0.15%)}	_~	_25.32s	_25.41s	_{p=0.470 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,040k (± 0.04%)}	_{370,036k (± 0.04%)}	_~	_369,882k	_370,326k	_{p=1.000 n=6}
_{Parse Time}	_{2.83s (± 0.76%)}	_{2.82s (± 0.93%)}	_~	_2.80s	_2.87s	_{p=0.373 n=6}
_{Bind Time}	_{1.62s (± 1.21%)}	_{1.60s (± 1.50%)}	_~	_1.58s	_1.64s	_{p=0.126 n=6}
_{Check Time}	_{16.46s (± 0.44%)}	_{16.52s (± 0.49%)}	_~	_16.43s	_16.63s	_{p=0.296 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.91s (± 0.36%)}	_{20.94s (± 0.53%)}	_~	_20.81s	_21.07s	_{p=0.810 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,897,347	_3,897,347	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,226,093	_1,226,093	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,709,660k (± 0.00%)}	_{3,709,882k (± 0.00%)}	_{+223k (+ 0.01%)}	_3,709,743k	_3,710,049k	_{p=0.045 n=6}
_{Parse Time}	_{15.14s (± 0.34%)}	_{15.29s (± 0.42%)}	_{+0.15s (+ 0.97%)}	_15.21s	_15.37s	_{p=0.013 n=6}
_{Bind Time}	_{5.00s (± 2.76%)}	_{4.89s (± 0.48%)}	_~	_4.86s	_4.92s	_{p=0.064 n=6}
_{Check Time}	_{101.69s (± 3.76%)}	_{104.08s (± 3.74%)}	_~	_99.57s	_110.21s	_{p=0.230 n=6}
_{Emit Time}	_{34.20s (±11.98%)}	_{31.91s (± 9.56%)}	_~	_30.31s	_38.09s	_{p=0.378 n=6}
_{Total Time}	_{156.03s (± 4.77%)}	_{156.17s (± 4.18%)}	_~	_150.02s	_168.57s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₃₈	₃₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_363,098	_363,098	_~	_~	_~	_{p=1.000 n=6}
_Types	_159,255	_159,255	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{518,013k (± 0.02%)}	_{517,959k (± 0.02%)}	_~	_517,889k	_518,150k	_{p=0.378 n=6}
_{Parse Time}	_{4.45s (± 0.44%)}	_{4.46s (± 0.48%)}	_~	_4.43s	_4.48s	_{p=0.195 n=6}
_{Bind Time}	_{1.92s (± 0.43%)}	_{1.91s (± 0.63%)}	_~	_1.90s	_1.93s	_{p=0.677 n=6}
_{Check Time}	_{21.72s (± 0.42%)}	_{21.72s (± 0.16%)}	_~	_21.68s	_21.76s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (±154.76%)}	_0.00s	_~	_~	_~	_{p=0.174 n=6}
_{Total Time}	_{28.09s (± 0.38%)}	_{28.10s (± 0.20%)}	_~	_28.01s	_28.15s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_672,790	_672,825	_{+35 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_201,962	_201,962	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{574,744k (± 0.05%)}	_{574,666k (± 0.00%)}	_~	_574,655k	_574,689k	_{p=0.298 n=6}
_{Parse Time}	_{3.34s (± 0.35%)}	_{3.33s (± 0.41%)}	_~	_3.31s	_3.35s	_{p=0.099 n=6}
_{Bind Time}	_{1.12s (± 0.49%)}	_1.12s	_~	_~	_~	_{p=0.071 n=6}
_{Check Time}	_{17.54s (± 0.45%)}	_{17.54s (± 0.10%)}	_~	_17.52s	_17.57s	_{p=0.467 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.99s (± 0.33%)}	_{21.99s (± 0.07%)}	_~	_21.97s	_22.01s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-09-30T21:36:11Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61696/merge:

Everything looks good!

jakebailey

Sorry, I missed something here; the options bags need to have explicit | undefined annotation in addition to ? to indicate that passing an explicit undefined is okay (versus requiring it be "missing").

src/lib/esnext.typedarrays.d.ts

dontwanttothink · 2025-10-03T17:32:28Z

Hopefully this is better. Thank you for taking the time to review the changes.

jakebailey · 2025-10-03T17:33:09Z

FWIW we don't usually make tests for lib.d.ts contents, exactly for the reasons you're experiencing; it's super annoying with baselines and doesn't really catch regressions. It'd probably be okay to remove them.

dontwanttothink · 2025-10-03T17:36:51Z

I see. Should I? Out of curiosity, what is the 'cases/conformance/esnext' directory for (in that case)?

jakebailey · 2025-10-03T17:40:05Z

It used to be for emit, but I think I missed the added test for Atomic in #61646.

jakebailey

LGTM but need to double check that the extra file is the right solution.

jakebailey · 2025-10-03T21:01:49Z

Going to just take this as-is. When they are in ES2025 (or later?), these files will get deleted anyway (see also #58573).

JonathanLennox · 2025-10-15T14:36:50Z

Can this be backported to release-5.9?

jakebailey · 2025-10-15T14:49:05Z

No, we do not backport features to old versions in patches.

Add type definitions for Uint8Array to/from base64 methods

2471626

Fixes microsoft#61695

github-project-automation bot added this to PR Backlog May 13, 2025

github-project-automation bot moved this to Not started in PR Backlog May 13, 2025

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 13, 2025

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 13, 2025

dontwanttothink added 4 commits May 12, 2025 21:28

Update baselines

09db85c

Update script target features

d5f1e1c

Add tests

f720939

Fix typo

ed6539c

dontwanttothink mentioned this pull request May 16, 2025

base64/hex methods missing from Uint8Array #61695

Closed

Renegade334 reviewed Jun 5, 2025

View reviewed changes

src/lib/esnext.array.d.ts Outdated Show resolved Hide resolved

src/lib/esnext.array.d.ts Outdated Show resolved Hide resolved

src/lib/esnext.array.d.ts Outdated Show resolved Hide resolved

dontwanttothink added 3 commits June 5, 2025 12:21

Use method definitions and narrow down type

3f18d3c

Update baselines

a5df42d

Merge branch 'main' into main

7289362

Merge branch 'main' into main

5e714bc

dontwanttothink mentioned this pull request Sep 4, 2025

Add type definitions for Uint8Array to/from base64 methods microsoft/typescript-go#1680

Closed

Merge branch 'microsoft:main' into main

f4aff51

jakebailey reviewed Sep 25, 2025

View reviewed changes

src/lib/esnext.array.d.ts Show resolved Hide resolved

dontwanttothink added 3 commits September 26, 2025 11:56

Move into esnext.typedarrays.d.ts

8b057c9

Update baselines

fb157d2

Fix line endings

44b7036

jakebailey approved these changes Oct 1, 2025

View reviewed changes

github-project-automation bot moved this from Not started to Needs merge in PR Backlog Oct 1, 2025

jakebailey requested changes Oct 2, 2025

View reviewed changes

src/lib/esnext.typedarrays.d.ts Outdated Show resolved Hide resolved

github-project-automation bot moved this from Needs merge to Waiting on author in PR Backlog Oct 2, 2025

dontwanttothink added 4 commits October 3, 2025 11:50

Allow passing undefined wherever appropriate

f28291d

Update baselines

9e959c6

Update tests to contemplate setting options to 'undefined'

70bdae0

Again, update baselines

29409fa

jakebailey reviewed Oct 3, 2025

View reviewed changes

src/lib/esnext.typedarrays.d.ts Outdated Show resolved Hide resolved

dontwanttothink added 2 commits October 3, 2025 12:27

Remove redundant undefineds

ea58c9b

Again, again update baselines

621e973

dontwanttothink added 2 commits October 3, 2025 13:00

Remove the test

5176640

Update baselines

b24705d

jakebailey approved these changes Oct 3, 2025

View reviewed changes

github-project-automation bot moved this from Waiting on author to Needs merge in PR Backlog Oct 3, 2025

jakebailey merged commit 3a68348 into microsoft:main Oct 3, 2025
33 checks passed

github-project-automation bot moved this from Needs merge to Done in PR Backlog Oct 3, 2025

Renegade334 mentioned this pull request Oct 16, 2025

feat(node): add Uint8Array base64/hex helpers DefinitelyTyped/DefinitelyTyped#73911

Closed

jakebailey mentioned this pull request Feb 5, 2026

Fix missing typedarrays lib microsoft/typescript-go#2695

Merged

Conversation

dontwanttothink commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 13, 2025

Uh oh!

dontwanttothink commented May 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dontwanttothink commented Jul 1, 2025

Uh oh!

filipesmedeiros commented Sep 3, 2025

Uh oh!

jakebailey commented Sep 22, 2025

Uh oh!

Uh oh!

jakebailey commented Sep 30, 2025

Uh oh!

typescript-bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 30, 2025

Uh oh!

typescript-bot commented Sep 30, 2025

Uh oh!

typescript-bot commented Sep 30, 2025

tsc

Uh oh!

typescript-bot commented Sep 30, 2025

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dontwanttothink commented Oct 3, 2025

Uh oh!

jakebailey commented Oct 3, 2025

Uh oh!

dontwanttothink commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Oct 3, 2025

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Oct 3, 2025

Uh oh!

Uh oh!

JonathanLennox commented Oct 15, 2025

Uh oh!

jakebailey commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dontwanttothink commented May 13, 2025 •

edited

Loading

typescript-bot commented Sep 30, 2025 •

edited

Loading

dontwanttothink commented Oct 3, 2025 •

edited

Loading