Fixed nullish coalesce operator's precedence by Andarist · Pull Request #61372 · microsoft/TypeScript

Andarist · 2025-03-07T14:39:17Z

jakebailey · 2025-03-07T19:43:45Z

typescript-bot · 2025-03-07T19:43:49Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

jakebailey · 2025-03-07T19:44:01Z

src/compiler/utilities.ts

    // CoalesceExpressionHead:
    //     CoalesceExpression
    //     BitwiseORExpression
-    Coalesce = Conditional, // NOTE: This is wrong


I wonder how old this comment is...

6 years, it was added in #35282

typescript-bot · 2025-03-07T20:06:38Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61372/merge:

Everything looks good!

typescript-bot · 2025-03-07T20:08:33Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-03-07T20:29:46Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,186k (± 0.96%)}	_{194,163k (± 0.94%)}	_~	_192,898k	_196,561k	_{p=1.000 n=6}
_{Parse Time}	_{1.31s (± 0.62%)}	_{1.31s (± 0.75%)}	_~	_1.29s	_1.32s	_{p=0.673 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.74s (± 0.37%)}	_{9.74s (± 0.42%)}	_~	_9.70s	_9.80s	_{p=0.872 n=6}
_{Emit Time}	_{2.72s (± 0.83%)}	_{2.73s (± 0.50%)}	_~	_2.72s	_2.75s	_{p=0.256 n=6}
_{Total Time}	_{14.50s (± 0.19%)}	_{14.51s (± 0.29%)}	_~	_14.45s	_14.56s	_{p=0.687 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,670	_948,670	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,947	_410,947	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,306k (± 0.00%)}	_{1,224,293k (± 0.00%)}	_~	_1,224,275k	_1,224,314k	_{p=0.689 n=6}
_{Parse Time}	_{6.62s (± 0.90%)}	_{6.62s (± 0.93%)}	_~	_6.56s	_6.70s	_{p=0.560 n=6}
_{Bind Time}	_{1.89s (± 0.87%)}	_{1.89s (± 0.97%)}	_~	_1.86s	_1.90s	_{p=0.933 n=6}
_{Check Time}	_{31.93s (± 0.52%)}	_{31.92s (± 0.35%)}	_~	_31.81s	_32.11s	_{p=0.810 n=6}
_{Emit Time}	_{15.29s (± 0.70%)}	_{15.27s (± 0.30%)}	_~	_15.21s	_15.33s	_{p=0.687 n=6}
_{Total Time}	_{55.73s (± 0.26%)}	_{55.70s (± 0.28%)}	_~	_55.54s	_55.97s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,347,571	_2,347,571	_~	_~	_~	_{p=1.000 n=6}
_Types	_845,646	_845,646	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,121,799k (± 0.00%)}	_{2,121,890k (± 0.01%)}	_~	_2,121,750k	_2,122,020k	_{p=0.298 n=6}
_{Parse Time}	_{7.32s (± 0.28%)}	_{7.37s (± 2.04%)}	_~	_7.26s	_7.66s	_{p=0.936 n=6}
_{Bind Time}	_{2.44s (± 0.60%)}	_{2.38s (± 6.80%)}	_~	_2.06s	_2.49s	_{p=1.000 n=6}
_{Check Time}	_{72.56s (± 0.66%)}	_{72.22s (± 0.94%)}	_~	_70.98s	_72.89s	_{p=0.471 n=6}
_{Emit Time}	_{0.15s (± 5.07%)}	_{0.15s (± 5.76%)}	_~	_0.14s	_0.16s	_{p=0.432 n=6}
_{Total Time}	_{82.46s (± 0.57%)}	_{82.11s (± 0.81%)}	_~	_80.90s	_82.77s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,697	_1,226,713	_{+16 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,990	_267,012	_{+22 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,357,043k (± 0.03%)}	_{2,357,381k (± 0.02%)}	_~	_2,356,762k	_2,357,960k	_{p=0.230 n=6}
_{Parse Time}	_{5.19s (± 0.62%)}	_{5.21s (± 0.34%)}	_~	_5.18s	_5.23s	_{p=0.518 n=6}
_{Bind Time}	_{1.77s (± 0.77%)}	_{1.77s (± 1.26%)}	_~	_1.74s	_1.80s	_{p=0.685 n=6}
_{Check Time}	_{35.28s (± 0.26%)}	_{35.26s (± 0.20%)}	_~	_35.18s	_35.38s	_{p=0.936 n=6}
_{Emit Time}	_{3.00s (± 1.17%)}	_{3.00s (± 1.29%)}	_~	_2.96s	_3.05s	_{p=0.936 n=6}
_{Total Time}	_{45.25s (± 0.26%)}	_{45.26s (± 0.20%)}	_~	_45.14s	_45.41s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,697	_1,226,713	_{+16 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,990	_267,012	_{+22 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,032,604k (± 9.77%)}	_{2,910,629k (±12.86%)}	_~	_2,426,214k	_3,154,478k	_{p=0.230 n=6}
_{Parse Time}	_{6.98s (± 0.98%)}	_{6.93s (± 1.56%)}	_~	_6.78s	_7.09s	_{p=0.378 n=6}
_{Bind Time}	_{2.13s (± 0.96%)}	_{2.15s (± 1.71%)}	_~	_2.10s	_2.19s	_{p=0.375 n=6}
_{Check Time}	_{42.91s (± 0.45%)}	_{42.88s (± 0.60%)}	_~	_42.50s	_43.21s	_{p=0.936 n=6}
_{Emit Time}	_{3.51s (± 1.04%)}	_{3.59s (± 2.62%)}	_~	_3.51s	_3.76s	_{p=0.093 n=6}
_{Total Time}	_{55.54s (± 0.42%)}	_{55.54s (± 0.67%)}	_~	_54.97s	_55.93s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,669	_262,668	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,848	_106,848	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,432k (± 0.02%)}	_{440,437k (± 0.02%)}	_~	_440,281k	_440,528k	_{p=0.936 n=6}
_{Parse Time}	_{3.54s (± 0.97%)}	_{3.52s (± 0.30%)}	_~	_3.51s	_3.54s	_{p=0.684 n=6}
_{Bind Time}	_{1.31s (± 0.62%)}	_{1.31s (± 0.89%)}	_~	_1.29s	_1.32s	_{p=0.498 n=6}
_{Check Time}	_{18.87s (± 0.32%)}	_{18.90s (± 0.39%)}	_~	_18.79s	_19.01s	_{p=0.518 n=6}
_{Emit Time}	_{1.52s (± 1.28%)}	_{1.52s (± 1.10%)}	_~	_1.49s	_1.54s	_{p=0.669 n=6}
_{Total Time}	_{25.24s (± 0.31%)}	_{25.25s (± 0.34%)}	_~	_25.11s	_25.37s	_{p=0.687 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,981	_225,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,356	_94,356	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,198k (± 0.01%)}	_{371,201k (± 0.01%)}	_~	_371,142k	_371,251k	_{p=0.936 n=6}
_{Parse Time}	_{2.92s (± 0.60%)}	_{2.88s (± 0.76%)}	_{-0.04s (- 1.26%)}	_2.85s	_2.91s	_{p=0.019 n=6}
_{Bind Time}	_{1.59s (± 1.17%)}	_{1.59s (± 1.52%)}	_~	_1.57s	_1.64s	_{p=0.806 n=6}
_{Check Time}	_{16.51s (± 0.39%)}	_{16.53s (± 0.23%)}	_~	_16.48s	_16.58s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.02s (± 0.27%)}	_{21.00s (± 0.22%)}	_~	_20.93s	_21.07s	_{p=0.467 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,271,759	_3,271,759	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,107,642	_1,107,642	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,335,848k (± 0.00%)}	_{3,335,745k (± 0.01%)}	_~	_3,335,409k	_3,335,895k	_{p=0.471 n=6}
_{Parse Time}	_{14.47s (± 0.78%)}	_{14.52s (± 0.84%)}	_~	_14.31s	_14.63s	_{p=0.335 n=6}
_{Bind Time}	_{4.69s (± 2.16%)}	_{4.69s (± 2.43%)}	_~	_4.61s	_4.91s	_{p=0.936 n=6}
_{Check Time}	_{91.25s (± 1.67%)}	_{90.26s (± 1.93%)}	_~	_88.00s	_92.50s	_{p=0.378 n=6}
_{Emit Time}	_{28.91s (± 0.53%)}	_{29.02s (± 1.86%)}	_~	_28.60s	_30.10s	_{p=1.000 n=6}
_{Total Time}	_{139.32s (± 1.03%)}	_{138.49s (± 1.61%)}	_~	_135.67s	_141.76s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_295,227	_295,227	_~	_~	_~	_{p=1.000 n=6}
_Types	_120,606	_120,606	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{449,293k (± 0.02%)}	_{449,254k (± 0.02%)}	_~	_449,125k	_449,396k	_{p=0.471 n=6}
_{Parse Time}	_{4.06s (± 0.97%)}	_{4.09s (± 0.89%)}	_~	_4.04s	_4.15s	_{p=0.228 n=6}
_{Bind Time}	_{1.77s (± 0.83%)}	_{1.75s (± 1.11%)}	_~	_1.74s	_1.79s	_{p=0.073 n=6}
_{Check Time}	_{19.02s (± 0.39%)}	_{19.09s (± 0.40%)}	_~	_19.03s	_19.23s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.86s (± 0.28%)}	_{24.94s (± 0.32%)}	_~	_24.82s	_25.05s	_{p=0.124 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_560,942	_560,942	_~	_~	_~	_{p=1.000 n=6}
_Types	_187,848	_187,848	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{497,891k (± 0.01%)}	_{497,671k (± 0.04%)}	_~	_497,511k	_498,064k	_{p=0.066 n=6}
_{Parse Time}	_{3.41s (± 0.19%)}	_{3.43s (± 0.66%)}	_~	_3.40s	_3.46s	_{p=0.134 n=6}
_{Bind Time}	_{1.22s (± 0.96%)}	_{1.21s (± 1.14%)}	_~	_1.19s	_1.23s	_{p=0.117 n=6}
_{Check Time}	_{19.72s (± 0.39%)}	_{19.79s (± 0.32%)}	_~	_19.69s	_19.85s	_{p=0.147 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{24.34s (± 0.29%)}	_{24.43s (± 0.25%)}	_~	_24.33s	_24.49s	_{p=0.065 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-03-07T21:19:07Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61372/merge:

Everything looks good!

…precedence

tests/baselines/reference/nullishCoalescingOperator5.errors.txt

…precedence

Fixed nullish coalesce operator's precedence

6b77d0e

github-project-automation bot added this to PR Backlog Mar 7, 2025

github-project-automation bot moved this to Not started in PR Backlog Mar 7, 2025

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 7, 2025

fmt

6f5d4a1

jakebailey reviewed Mar 7, 2025

View reviewed changes

jakebailey requested a review from rbuckton March 24, 2025 23:57

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 24, 2025

Andarist added 2 commits April 11, 2025 11:26

add extra test case

d99057d

Merge remote-tracking branch 'origin/main' into fix/nullish-coalesce-…

3f8cff6

…precedence

typescript-bot assigned rbuckton Apr 11, 2025

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Apr 11, 2025

jakebailey requested changes Jun 30, 2025

View reviewed changes

tests/baselines/reference/nullishCoalescingOperator5.errors.txt Show resolved Hide resolved

github-project-automation bot moved this from Not started to Waiting on author in PR Backlog Jun 30, 2025

Andarist added 3 commits June 30, 2025 21:22

Merge remote-tracking branch 'origin/main' into fix/nullish-coalesce-…

85937ab

…precedence

fix missing error

538ffd8

unify style of the cases

955d8e0

jakebailey approved these changes Jun 30, 2025

View reviewed changes

github-project-automation bot moved this from Waiting on author to Needs merge in PR Backlog Jun 30, 2025

jakebailey approved these changes Jun 30, 2025

View reviewed changes

jakebailey merged commit 91cdbd5 into microsoft:main Jun 30, 2025
32 checks passed

github-project-automation bot moved this from Needs merge to Done in PR Backlog Jun 30, 2025

JeanMeche mentioned this pull request Aug 20, 2025

Manually constructed nullish coalescing + OR AST is missing parentheses when printed #62307

Closed

Andarist mentioned this pull request Oct 5, 2025

Port "Fixed nullish coalesce operator's precedence" microsoft/typescript-go#1824

Merged

microsoft locked as resolved and limited conversation to collaborators Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed nullish coalesce operator's precedence#61372

Fixed nullish coalesce operator's precedence#61372
jakebailey merged 7 commits intomicrosoft:mainfrom
Andarist:fix/nullish-coalesce-precedence

Andarist commented Mar 7, 2025 •

edited

Loading

Uh oh!

jakebailey commented Mar 7, 2025

Uh oh!

typescript-bot commented Mar 7, 2025 •

edited

Loading

Uh oh!

jakebailey Mar 7, 2025

Uh oh!

Andarist Mar 7, 2025

Uh oh!

typescript-bot commented Mar 7, 2025

Uh oh!

typescript-bot commented Mar 7, 2025

Uh oh!

typescript-bot commented Mar 7, 2025

tsc

Uh oh!

typescript-bot commented Mar 7, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Andarist commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Mar 7, 2025

Uh oh!

typescript-bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Andarist Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Mar 7, 2025

Uh oh!

typescript-bot commented Mar 7, 2025

Uh oh!

typescript-bot commented Mar 7, 2025

tsc

Uh oh!

typescript-bot commented Mar 7, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Andarist commented Mar 7, 2025 •

edited

Loading

typescript-bot commented Mar 7, 2025 •

edited

Loading