Skip to content

[WIP] Disallow merging of enum declarations#61262

Closed
rbuckton wants to merge 2 commits intomainfrom
no-enum-merging
Closed

[WIP] Disallow merging of enum declarations#61262
rbuckton wants to merge 2 commits intomainfrom
no-enum-merging

Conversation

@rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Feb 24, 2025

This is an experiment to access the impact of disallowing the merging of enum declarations.

@rbuckton rbuckton marked this pull request as draft February 24, 2025 21:00
@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 24, 2025

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@rbuckton
Copy link
Contributor Author

rbuckton commented Feb 24, 2025

@typescript-bot test top400
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 24, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 24, 2025

@rbuckton Here are the results of running the user tests with tsc comparing main and refs/pull/61262/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 24, 2025

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61262/merge:

Everything looks good!

@rbuckton
Copy link
Contributor Author

rbuckton commented Mar 20, 2025

@typescript-bot test top10.00

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 20, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top10.00 ✅ Started

@rbuckton
Copy link
Contributor Author

rbuckton commented Mar 20, 2025

@typescript-bot test top1000

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 20, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top1000 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 20, 2025

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61262/merge:

Everything looks good!

@rbuckton
Copy link
Contributor Author

rbuckton commented Mar 31, 2025

@typescript-bot test top999

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 31, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top999 ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 31, 2025

@rbuckton Here are the results of running the top 999 repos with tsc comparing main and refs/pull/61262/merge:

Something interesting changed - please have a look.

Details

microsoft/azuredatastudio

16 of 67 projects failed to build with the old tsc and were ignored

extensions/sql-migration/tsconfig.json

extensions/sql-assessment/tsconfig.json

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

@rbuckton rbuckton mentioned this pull request Apr 1, 2025
Open
@Dunqing Dunqing mentioned this pull request May 14, 2025
Closed
@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Dec 15, 2025
@jakebailey jakebailey mentioned this pull request Jan 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

PR Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rbuckton @typescript-bot @RyanCavanaugh