Ban import=require and export= under erasableSyntaxOnly - #61175
Merged
Jake Bailey (jakebailey) merged 2 commits intoFeb 14, 2025
Merged
Ban import=require and export= under erasableSyntaxOnly#61175Jake Bailey (jakebailey) merged 2 commits into
Jake Bailey (jakebailey) merged 2 commits into
Conversation
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Ryan Cavanaugh (RyanCavanaugh)
February 14, 2025 00:26
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Feb 14, 2025
| return MyClassOk; | ||
| }()); | ||
| //// [commonjs.cjs] | ||
| "use strict"; |
Member
Author
There was a problem hiding this comment.
Oh no, this means that CJS isn't even erasable because we assume strict and always insert it
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-5.8 |
Contributor
TypeScript Bot (typescript-bot)
pushed a commit
that referenced
this pull request
Feb 14, 2025
Contributor
|
Hey, Jake Bailey (@jakebailey)! I've created #61178 for you. |
2 tasks
|
Jake Bailey (@jakebailey) was this intended to affect exports when using |
Member
Author
|
No, definitely not. I forgot that default exports and export= are the same node. |
Member
Author
|
Fix in #61210. |
Member
Author
|
Merged, so should be fixed in the next nightly. I'm glad at least one person is testing them... |
Jake Bailey (jakebailey)
added a commit
that referenced
this pull request
Feb 20, 2025
…e-5.8 (#61178) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion; this syntax isn't supported by Node.js/Amaro or
ts-blank-space, andexport=is not actually erasable as its transformed syntax ismodule.exports=.This effectively means you can't write any CJS code under
erasableSyntaxOnly(without usingconst foo = require("foo")andmodule.exports = ...directly, which do not bind in TS). Perhaps we can makeconst foo = require("...")andmodule.exports = ...bind like they do in JS for TS files in the future.Updates #59601
Updates #61011