feat: add Error.isError() to ESNext lib#60788
Merged
jakebailey merged 3 commits intomicrosoft:mainfrom Jun 6, 2025
Merged
Conversation
typescript-bot
added
the
For Uncommitted Bug
dirkluijk
changed the title
jakebailey
reviewed
Dec 17, 2024
Contributor
|
For reference, this is soon to land in Node v24. |
typescript-bot
added
For Backlog Bug
jakebailey
approved these changes
Jun 6, 2025
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Updated the PR to minimize it. I think it's good now, though my pushing to it means I don't have permission to actually approve it.
Renegade334
reviewed
Jun 6, 2025
| /** | ||
| * Indicates whether the argument provided is a built-in Error instance or not. | ||
| */ | ||
| isError(error: unknown): error is Error; |
Contributor
There was a problem hiding this comment.
Note, in the spec, this is not a predicate on satisfying the shape of the Error prototype.
const pseudo = Reflect.construct(Error, [], Object)
Error.prototype.isPrototypeOf(pseudo) // false
'message' in pseudo // false
'name' in pseudo // false
Error.isError(pseudo) // trueBy rights, this should really just return a boolean.
Member
There was a problem hiding this comment.
It being a predicate was the main reason everyone wanted it....
Member
There was a problem hiding this comment.
(okay the realm problem is the real issue but still)
Member
There was a problem hiding this comment.
The usefulness very much outweighs the downsides, we think.
jakebailey
approved these changes
Jun 6, 2025
weswigham
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60787