Actually set impliedNodeFormat in more cases by andrewbranch · Pull Request #59479 · microsoft/TypeScript

andrewbranch · 2024-07-30T22:06:30Z

A bad merge conflict resolution in #58825 caused it not to take effect. This finishes the job.

andrewbranch · 2024-07-30T22:09:58Z

typescript-bot · 2024-07-30T22:10:01Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

tests/baselines/reference/impliedNodeFormatEmit2(module=commonjs).js

typescript-bot · 2024-07-30T22:34:03Z

Hey @andrewbranch, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-30T22:38:49Z

@andrewbranch Here are the results of running the user tests with tsc comparing main and refs/pull/59479/merge:

Everything looks good!

typescript-bot · 2024-07-30T22:46:34Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,170k (± 1.03%)}	_{194,182k (± 0.98%)}	_~	_192,335k	_195,942k	_{p=0.936 n=6}
_{Parse Time}	_{1.30s (± 1.02%)}	_{1.30s (± 0.69%)}	_~	_1.29s	_1.31s	_{p=0.801 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.55s (± 0.36%)}	_{9.54s (± 0.59%)}	_~	_9.47s	_9.62s	_{p=1.000 n=6}
_{Emit Time}	_{2.73s (± 0.76%)}	_{2.74s (± 0.72%)}	_~	_2.71s	_2.76s	_{p=0.560 n=6}
_{Total Time}	_{14.28s (± 0.15%)}	_{14.29s (± 0.30%)}	_~	_14.23s	_14.35s	_{p=0.513 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,532	_945,537	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_409,507	_409,512	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,221,102k (± 0.01%)}	_{1,222,222k (± 0.00%)}	_{+1,120k (+ 0.09%)}	_1,222,189k	_1,222,241k	_{p=0.005 n=6}
_{Parse Time}	_{6.63s (± 0.51%)}	_{6.64s (± 0.53%)}	_~	_6.60s	_6.70s	_{p=0.571 n=6}
_{Bind Time}	_{1.85s (± 0.45%)}	_{1.86s (± 0.22%)}	_~	_1.86s	_1.87s	_{p=0.115 n=6}
_{Check Time}	_{31.15s (± 0.32%)}	_{31.01s (± 0.19%)}	_{-0.13s (- 0.43%)}	_30.93s	_31.09s	_{p=0.024 n=6}
_{Emit Time}	_{14.97s (± 0.38%)}	_{14.99s (± 0.58%)}	_~	_14.91s	_15.15s	_{p=0.873 n=6}
_{Total Time}	_{54.59s (± 0.18%)}	_{54.51s (± 0.21%)}	_~	_54.36s	_54.66s	_{p=0.226 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,439,121	_2,439,121	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,004,407	_1,004,407	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,410,559k (± 0.00%)}	_{2,412,463k (± 0.00%)}	_{+1,905k (+ 0.08%)}	_2,412,396k	_2,412,499k	_{p=0.005 n=6}
_{Parse Time}	_{8.39s (± 0.29%)}	_{8.47s (± 0.14%)}	_{+0.08s (+ 0.93%)}	_8.45s	_8.48s	_{p=0.004 n=6}
_{Bind Time}	_{2.07s (± 0.64%)}	_{2.08s (± 0.50%)}	_~	_2.06s	_2.09s	_{p=0.677 n=6}
_{Check Time}	_{74.98s (± 0.84%)}	_{74.54s (± 0.38%)}	_~	_74.13s	_74.96s	_{p=0.297 n=6}
_{Emit Time}	_{0.28s (± 2.95%)}	_{0.28s (± 1.45%)}	_~	_0.28s	_0.29s	_{p=0.218 n=6}
_{Total Time}	_{85.73s (± 0.74%)}	_{85.36s (± 0.34%)}	_~	_84.93s	_85.78s	_{p=0.688 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,880	_1,227,882	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,181	_265,181	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,405,750k (± 6.00%)}	_{2,406,155k (± 6.00%)}	_~	_2,346,302k	_2,701,007k	_{p=0.378 n=6}
_{Parse Time}	_{4.97s (± 1.03%)}	_{4.92s (± 0.88%)}	_~	_4.88s	_5.00s	_{p=0.093 n=6}
_{Bind Time}	_{1.90s (± 0.72%)}	_{1.89s (± 0.86%)}	_~	_1.88s	_1.92s	_{p=0.677 n=6}
_{Check Time}	_{34.50s (± 0.52%)}	_{34.55s (± 0.28%)}	_~	_34.47s	_34.68s	_{p=0.748 n=6}
_{Emit Time}	_{3.29s (± 0.89%)}	_{3.30s (± 0.74%)}	_~	_3.27s	_3.33s	_{p=0.746 n=6}
_{Total Time}	_{44.66s (± 0.42%)}	_{44.67s (± 0.24%)}	_~	_44.54s	_44.80s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,880	_1,227,882	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,181	_265,181	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,420,476k (± 0.02%)}	_{2,420,979k (± 0.02%)}	_~	_2,420,105k	_2,421,678k	_{p=0.128 n=6}
_{Parse Time}	_{6.24s (± 0.50%)}	_{6.18s (± 0.53%)}	_{-0.06s (- 0.96%)}	_6.14s	_6.23s	_{p=0.013 n=6}
_{Bind Time}	_{2.02s (± 0.73%)}	_{2.02s (± 0.68%)}	_~	_2.00s	_2.04s	_{p=0.808 n=6}
_{Check Time}	_{41.38s (± 0.70%)}	_{41.22s (± 0.51%)}	_~	_41.05s	_41.51s	_{p=0.128 n=6}
_{Emit Time}	_{4.10s (± 2.09%)}	_{4.02s (± 1.47%)}	_~	_3.94s	_4.11s	_{p=0.149 n=6}
_{Total Time}	_{53.78s (± 0.43%)}	_{53.48s (± 0.38%)}	_~	_53.31s	_53.73s	_{p=0.093 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_255,992	_255,994	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,965	_104,965	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,993k (± 0.04%)}	_{428,041k (± 0.05%)}	_~	_427,823k	_428,401k	_{p=0.936 n=6}
_{Parse Time}	_{3.35s (± 0.88%)}	_{3.36s (± 0.80%)}	_~	_3.31s	_3.39s	_{p=0.373 n=6}
_{Bind Time}	_{1.32s (± 0.83%)}	_{1.32s (± 1.33%)}	_~	_1.29s	_1.33s	_{p=1.000 n=6}
_{Check Time}	_{17.93s (± 0.21%)}	_{17.94s (± 0.39%)}	_~	_17.87s	_18.04s	_{p=1.000 n=6}
_{Emit Time}	_{1.65s (± 1.04%)}	_{1.65s (± 1.07%)}	_~	_1.62s	_1.67s	_{p=0.452 n=6}
_{Total Time}	_{24.25s (± 0.21%)}	_{24.26s (± 0.36%)}	_~	_24.13s	_24.38s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,104k (± 0.03%)}	_{370,119k (± 0.04%)}	_~	_369,986k	_370,355k	_{p=1.000 n=6}
_{Parse Time}	_{2.76s (± 0.55%)}	_{2.75s (± 0.59%)}	_~	_2.73s	_2.77s	_{p=0.805 n=6}
_{Bind Time}	_{1.59s (± 1.24%)}	_{1.58s (± 0.57%)}	_~	_1.57s	_1.59s	_{p=0.803 n=6}
_{Check Time}	_{15.62s (± 0.23%)}	_{15.65s (± 0.44%)}	_~	_15.57s	_15.76s	_{p=0.572 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.96s (± 0.25%)}	_{19.99s (± 0.37%)}	_~	_19.90s	_20.10s	_{p=0.574 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,989,731	_2,989,731	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,028,641	_1,028,641	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,114,254k (± 0.00%)}	_{3,114,493k (± 0.00%)}	_{+240k (+ 0.01%)}	_3,114,403k	_3,114,591k	_{p=0.005 n=6}
_{Parse Time}	_{13.82s (± 0.20%)}	_{13.86s (± 0.34%)}	_~	_13.79s	_13.92s	_{p=0.106 n=6}
_{Bind Time}	_{4.38s (± 2.43%)}	_{4.34s (± 2.43%)}	_~	_4.27s	_4.55s	_{p=0.748 n=6}
_{Check Time}	_{79.49s (± 0.20%)}	_{79.28s (± 0.33%)}	_~	_78.89s	_79.60s	_{p=0.171 n=6}
_{Emit Time}	_{20.49s (± 0.45%)}	_{20.55s (± 0.67%)}	_~	_20.37s	_20.77s	_{p=0.575 n=6}
_{Total Time}	_{118.17s (± 0.11%)}	_{118.03s (± 0.39%)}	_~	_117.41s	_118.59s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,994	_267,994	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,192	_109,192	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{412,903k (± 0.02%)}	_{412,999k (± 0.01%)}	_{+97k (+ 0.02%)}	_412,947k	_413,070k	_{p=0.031 n=6}
_{Parse Time}	_{3.81s (± 0.86%)}	_{3.83s (± 0.20%)}	_~	_3.82s	_3.84s	_{p=0.683 n=6}
_{Bind Time}	_{1.72s (± 0.24%)}	_{1.72s (± 0.57%)}	_~	_1.71s	_1.73s	_{p=0.487 n=6}
_{Check Time}	_{16.88s (± 0.27%)}	_{16.93s (± 0.43%)}	_~	_16.84s	_17.03s	_{p=0.297 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.42s (± 0.22%)}	_{22.48s (± 0.34%)}	_~	_22.38s	_22.59s	_{p=0.229 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_535,893	_535,893	_~	_~	_~	_{p=1.000 n=6}
_Types	_175,647	_175,647	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{479,804k (± 0.01%)}	_{479,833k (± 0.01%)}	_~	_479,798k	_479,893k	_{p=0.471 n=6}
_{Parse Time}	_{3.42s (± 0.47%)}	_{3.41s (± 0.93%)}	_~	_3.39s	_3.46s	_{p=0.285 n=6}
_{Bind Time}	_{1.24s (± 0.61%)}	_{1.24s (± 0.66%)}	_~	_1.23s	_1.25s	_{p=0.729 n=6}
_{Check Time}	_{17.88s (± 0.27%)}	_{17.92s (± 0.24%)}	_~	_17.83s	_17.95s	_{p=0.126 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.55s (± 0.26%)}	_{22.57s (± 0.20%)}	_~	_22.51s	_22.65s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-30T23:41:14Z

@andrewbranch Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59479/merge:

Something interesting changed - please have a look.

Details

microsoft/playwright

4 of 16 projects failed to build with the old tsc and were ignored

packages/html-reporter/tsconfig.json

error TS1192: Module '"/mnt/ts_downloads/_/m/playwright/node_modules/@zip.js/zip.js/index"' has no default export.
- packages/html-reporter/src/index.tsx#L18

jakebailey · 2024-07-31T20:29:03Z

It's a shame this missed the beta... but I guess we should fix this oops now since we said we were going to do it?

jakebailey · 2024-07-31T20:30:09Z

src/compiler/program.ts

+    const moduleResolution = getEmitModuleResolutionKind(options);
+    const shouldLookupFromPackageJson = ModuleResolutionKind.Node16 <= moduleResolution && moduleResolution <= ModuleResolutionKind.NodeNext
+        || pathContainsNodeModules(fileName);
+    return fileExtensionIsOneOf(fileName, [Extension.Dmts, Extension.Mts, Extension.Mjs]) ? ModuleKind.ESNext :


Not for this PR but we copy and paste the arrays passed into fileExtensionIsOneOf all over the place; makes me wonder if we'd get a speed boost by lifting these arrays into common variables.

Actually set impliedNodeFormat in more cases

19f0c8d

typescript-bot assigned andrewbranch Jul 30, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 30, 2024

jakebailey reviewed Jul 30, 2024

View reviewed changes

tests/baselines/reference/impliedNodeFormatEmit2(module=commonjs).js Show resolved Hide resolved

andrewbranch marked this pull request as ready for review July 31, 2024 18:34

andrewbranch requested review from jakebailey and sheetalkamat July 31, 2024 18:37

jakebailey approved these changes Jul 31, 2024

View reviewed changes

jakebailey reviewed Jul 31, 2024

View reviewed changes

andrewbranch merged commit 5e9b070 into microsoft:main Jul 31, 2024

andrewbranch deleted the bug/fix-58825 branch July 31, 2024 20:40

This was referenced Sep 17, 2024

CommonJS module output broken after updating from 5.5.4 to 5.6.2 #59991

Closed

Set impliedNodeFormat based on redirectedReference options #60039

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Actually set impliedNodeFormat in more cases#59479

Actually set impliedNodeFormat in more cases#59479
andrewbranch merged 1 commit intomicrosoft:mainfrom
andrewbranch:bug/fix-58825

andrewbranch commented Jul 30, 2024 •

edited

Loading

Uh oh!

andrewbranch commented Jul 30, 2024

Uh oh!

typescript-bot commented Jul 30, 2024 •

edited

Loading

Uh oh!

Uh oh!

typescript-bot commented Jul 30, 2024

Uh oh!

typescript-bot commented Jul 30, 2024

Uh oh!

typescript-bot commented Jul 30, 2024

tsc

Uh oh!

typescript-bot commented Jul 30, 2024

microsoft/playwright

packages/html-reporter/tsconfig.json

Uh oh!

jakebailey commented Jul 31, 2024

Uh oh!

jakebailey Jul 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

andrewbranch commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewbranch commented Jul 30, 2024

Uh oh!

typescript-bot commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented Jul 30, 2024

Uh oh!

typescript-bot commented Jul 30, 2024

Uh oh!

typescript-bot commented Jul 30, 2024

tsc

Uh oh!

typescript-bot commented Jul 30, 2024

microsoft/playwright

packages/html-reporter/tsconfig.json

Uh oh!

jakebailey commented Jul 31, 2024

Uh oh!

jakebailey Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrewbranch commented Jul 30, 2024 •

edited

Loading

typescript-bot commented Jul 30, 2024 •

edited

Loading