https://github.com/microsoft/TypeScript/pull/58220 by gabritto · Pull Request #58859 · microsoft/TypeScript

gabritto · 2024-06-13T23:49:38Z

Updated version of #55234.
Fixes #3276.

Motivated by #57842.

gabritto · 2024-06-13T23:55:00Z

typescript-bot · 2024-06-13T23:55:03Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-06-14T00:15:10Z

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-06-14T00:19:35Z

@gabritto Here are the results of running the user tests with tsc comparing main and refs/pull/58859/merge:

Something interesting changed - please have a look.

Details

effect

tsconfig.json

[NEW] error TS2739: Type 'MultipartError' is missing the following properties from type 'MultipartError': _tag, reason, error, [ErrorTypeId]
[MISSING] error TS2322: Type 'import("/mnt/ts_downloads/_/m/effect/packages/platform/src/internal/http/multipart", { with: { "resolution-mode": "import" } }).MultipartError' is not assignable to type 'import("/mnt/ts_downloads/_/m/effect/packages/platform/src/Http/Multipart", { with: { "resolution-mode": "import" } }).MultipartError'.

tsconfig.base.json

[NEW] error TS2739: Type 'MultipartError' is missing the following properties from type 'MultipartError': _tag, reason, error, [ErrorTypeId]
[MISSING] error TS2322: Type 'import("/mnt/ts_downloads/_/m/effect/packages/platform/src/internal/http/multipart", { with: { "resolution-mode": "import" } }).MultipartError' is not assignable to type 'import("/mnt/ts_downloads/_/m/effect/packages/platform/src/Http/Multipart", { with: { "resolution-mode": "import" } }).MultipartError'.

lodash

/mnt/ts_downloads/_/m/lodash/tsconfig.json

[NEW] error TS2740: Type 'SetCache' is missing the following properties from type 'any[]': length, pop, concat, join, and 34 more.
- /mnt/ts_downloads/_/m/lodash/node_modules/lodash/_baseUniq.js(39,5)
[MISSING] error TS2322: Type 'SetCache' is not assignable to type 'any[]'.
- /mnt/ts_downloads/_/m/lodash/node_modules/lodash/_baseUniq.js(39,5)

xterm.js

src/tsconfig-library-base.json

[NEW] error TS2740: Type 'TestBufferLine' is missing the following properties from type 'IBufferLine': length, isWrapped, get, set, and 23 more.
[MISSING] error TS2322: Type 'TestBufferLine' is not assignable to type 'IBufferLine'.

typescript-bot · 2024-06-14T00:37:39Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,729k (± 0.78%)}	_{193,392k (± 0.98%)}	_~	_192,152k	_195,835k	_{p=0.471 n=6}
_{Parse Time}	_{1.95s (± 0.82%)}	_{1.95s (± 0.39%)}	_~	_1.94s	_1.96s	_{p=0.788 n=6}
_{Bind Time}	_{1.07s (± 0.76%)}	_{1.06s (± 1.41%)}	_~	_1.05s	_1.09s	_{p=0.451 n=6}
_{Check Time}	_{13.89s (± 0.40%)}	_{13.92s (± 0.34%)}	_~	_13.87s	_13.98s	_{p=0.422 n=6}
_{Emit Time}	_{4.07s (± 3.10%)}	_{4.02s (± 0.58%)}	_~	_3.98s	_4.05s	_{p=1.000 n=6}
_{Total Time}	_{20.98s (± 0.42%)}	_{20.95s (± 0.17%)}	_~	_20.89s	_21.00s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,104	_944,104	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,044	_407,044	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,275k (± 0.01%)}	_{1,218,301k (± 0.00%)}	_~	_1,218,229k	_1,218,362k	_{p=0.423 n=6}
_{Parse Time}	_{7.94s (± 0.50%)}	_{7.97s (± 0.64%)}	_~	_7.90s	_8.03s	_{p=0.334 n=6}
_{Bind Time}	_{2.23s (± 0.34%)}	_{2.23s (± 0.44%)}	_~	_2.22s	_2.24s	_{p=0.554 n=6}
_{Check Time}	_{35.93s (± 0.32%)}	_{35.89s (± 0.27%)}	_~	_35.76s	_36.05s	_{p=0.748 n=6}
_{Emit Time}	_{16.23s (± 0.31%)}	_{16.21s (± 0.47%)}	_~	_16.09s	_16.31s	_{p=0.872 n=6}
_{Total Time}	_{62.33s (± 0.28%)}	_{62.31s (± 0.17%)}	_~	_62.10s	_62.40s	_{p=0.747 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,132,301	_2,132,301	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,081	_926,081	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,114,644k (± 0.00%)}	_{2,114,763k (± 0.00%)}	_{+119k (+ 0.01%)}	_2,114,728k	_2,114,867k	_{p=0.005 n=6}
_{Parse Time}	_{7.86s (± 0.15%)}	_{7.86s (± 0.24%)}	_~	_7.84s	_7.89s	_{p=0.684 n=6}
_{Bind Time}	_{2.77s (± 0.27%)}	_{2.76s (± 0.50%)}	_~	_2.75s	_2.78s	_{p=0.740 n=6}
_{Check Time}	_{84.38s (± 0.32%)}	_{83.94s (± 0.33%)}	_{-0.44s (- 0.52%)}	_83.52s	_84.22s	_{p=0.031 n=6}
_{Emit Time}	_{0.16s (± 4.75%)}	_{0.16s (± 4.99%)}	_~	_0.15s	_0.17s	_{p=0.306 n=6}
_{Total Time}	_{95.17s (± 0.28%)}	_{94.72s (± 0.30%)}	_{-0.45s (- 0.47%)}	_94.30s	_95.02s	_{p=0.031 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,770	_1,230,758	_{-12 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,222	_261,219	_{-3 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,355,243k (± 1.04%)}	_{2,345,705k (± 0.06%)}	_~	_2,343,313k	_2,346,879k	_{p=0.936 n=6}
_{Parse Time}	_{5.99s (± 1.16%)}	_{5.95s (± 1.22%)}	_~	_5.86s	_6.06s	_{p=0.471 n=6}
_{Bind Time}	_{2.24s (± 0.34%)}	_{2.25s (± 0.83%)}	_~	_2.23s	_2.28s	_{p=0.073 n=6}
_{Check Time}	_{39.81s (± 0.20%)}	_{39.74s (± 0.37%)}	_~	_39.53s	_39.96s	_{p=0.378 n=6}
_{Emit Time}	_{3.18s (± 3.90%)}	_{3.10s (± 2.88%)}	_~	_3.00s	_3.26s	_{p=0.230 n=6}
_{Total Time}	_{51.23s (± 0.41%)}	_{51.06s (± 0.51%)}	_~	_50.87s	_51.57s	_{p=0.173 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,770	_1,230,758	_{-12 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,222	_261,219	_{-3 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,422,483k (± 0.03%)}	_{2,431,708k (± 1.02%)}	_~	_2,420,791k	_2,482,249k	_{p=0.298 n=6}
_{Parse Time}	_{6.26s (± 0.87%)}	_{6.23s (± 0.74%)}	_~	_6.17s	_6.29s	_{p=0.298 n=6}
_{Bind Time}	_{2.01s (± 0.77%)}	_{1.99s (± 0.94%)}	_{-0.02s (- 1.16%)}	_1.96s	_2.01s	_{p=0.048 n=6}
_{Check Time}	_{40.15s (± 0.30%)}	_{40.18s (± 0.43%)}	_~	_40.05s	_40.52s	_{p=0.810 n=6}
_{Emit Time}	_{3.14s (± 2.00%)}	_{3.12s (± 1.47%)}	_~	_3.04s	_3.17s	_{p=0.810 n=6}
_{Total Time}	_{51.58s (± 0.32%)}	_{51.53s (± 0.35%)}	_~	_51.39s	_51.89s	_{p=0.575 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,665	_258,664	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,938	_104,935	_{-3 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,300k (± 0.01%)}	_{428,268k (± 0.01%)}	_~	_428,246k	_428,322k	_{p=0.078 n=6}
_{Parse Time}	_{3.30s (± 0.68%)}	_{3.31s (± 0.88%)}	_~	_3.26s	_3.35s	_{p=0.572 n=6}
_{Bind Time}	_{1.30s (± 0.69%)}	_{1.29s (± 0.42%)}	_~	_1.29s	_1.30s	_{p=0.341 n=6}
_{Check Time}	_{18.00s (± 0.29%)}	_{17.96s (± 0.16%)}	_~	_17.91s	_18.00s	_{p=0.280 n=6}
_{Emit Time}	_{1.37s (± 1.49%)}	_{1.33s (± 0.41%)}	_{-0.03s (- 2.44%)}	_1.33s	_1.34s	_{p=0.008 n=6}
_{Total Time}	_{23.97s (± 0.25%)}	_{23.90s (± 0.16%)}	_~	_23.86s	_23.95s	_{p=0.053 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,414k (± 0.03%)}	_{369,569k (± 0.04%)}	_{+154k (+ 0.04%)}	_369,468k	_369,824k	_{p=0.045 n=6}
_{Parse Time}	_{2.76s (± 0.88%)}	_{2.78s (± 0.95%)}	_~	_2.74s	_2.81s	_{p=0.373 n=6}
_{Bind Time}	_{1.60s (± 1.51%)}	_{1.59s (± 0.73%)}	_~	_1.58s	_1.61s	_{p=0.459 n=6}
_{Check Time}	_{15.47s (± 0.45%)}	_{15.51s (± 0.33%)}	_~	_15.43s	_15.57s	_{p=0.227 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.84s (± 0.37%)}	_{19.88s (± 0.33%)}	_~	_19.77s	_19.95s	_{p=0.422 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,853,853	_2,853,853	_~	_~	_~	_{p=1.000 n=6}
_Types	_968,176	_968,176	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,020,552k (± 0.00%)}	_{3,020,543k (± 0.00%)}	_~	_3,020,506k	_3,020,572k	_{p=0.873 n=6}
_{Parse Time}	_{16.82s (± 0.33%)}	_{16.76s (± 0.25%)}	_~	_16.70s	_16.81s	_{p=0.109 n=6}
_{Bind Time}	_{5.09s (± 0.32%)}	_{5.09s (± 0.42%)}	_~	_5.05s	_5.11s	_{p=0.805 n=6}
_{Check Time}	_{88.92s (± 0.54%)}	_{89.11s (± 0.69%)}	_~	_88.16s	_89.89s	_{p=0.575 n=6}
_{Emit Time}	_{28.87s (± 1.37%)}	_{28.57s (± 2.39%)}	_~	_27.61s	_29.24s	_{p=0.521 n=6}
_{Total Time}	_{139.70s (± 0.32%)}	_{139.54s (± 0.27%)}	_~	_138.99s	_140.06s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,914	_266,914	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,685	_108,685	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,295k (± 0.01%)}	_{411,377k (± 0.02%)}	_{+82k (+ 0.02%)}	_411,313k	_411,485k	_{p=0.031 n=6}
_{Parse Time}	_{4.71s (± 0.71%)}	_{4.69s (± 0.43%)}	_~	_4.66s	_4.72s	_{p=0.292 n=6}
_{Bind Time}	_{2.07s (± 0.36%)}	_{2.06s (± 0.66%)}	_~	_2.04s	_2.08s	_{p=0.273 n=6}
_{Check Time}	_{20.85s (± 0.55%)}	_{20.86s (± 0.30%)}	_~	_20.78s	_20.92s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.63s (± 0.33%)}	_{27.61s (± 0.19%)}	_~	_27.54s	_27.68s	_{p=0.470 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,429	_523,429	_~	_~	_~	_{p=1.000 n=6}
_Types	_177,955	_177,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,458k (± 0.08%)}	_{461,891k (± 0.01%)}	_~	_461,827k	_461,946k	_{p=0.173 n=6}
_{Parse Time}	_{2.62s (± 0.38%)}	_{2.63s (± 0.61%)}	_~	_2.61s	_2.65s	_{p=0.271 n=6}
_{Bind Time}	_{0.99s (± 0.64%)}	_{0.99s (± 0.41%)}	_~	_0.98s	_0.99s	_{p=0.673 n=6}
_{Check Time}	_{15.25s (± 0.66%)}	_{15.27s (± 0.46%)}	_~	_15.21s	_15.41s	_{p=0.420 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.86s (± 0.52%)}	_{18.89s (± 0.34%)}	_~	_18.83s	_19.01s	_{p=0.261 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-06-14T01:38:51Z

@gabritto Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58859/merge:

Everything looks good!

gabritto · 2024-06-14T19:07:09Z

It doesn't seem like the case of reporting the same assignability error more than once is that frequent, since there were only 3 changes in user tests, none in top 400, and no perf impact.

Two things I want to do, though:

Special case type comparison "overflow" cases so that we don't do the comparison again.
Maybe only have this consistent assignability elaboration when we know we are in an editor scenario, if that's possible.

gabritto · 2024-06-14T19:07:18Z

@typescript-bot test top800

typescript-bot · 2024-06-14T19:07:21Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top800`	✅ Started	✅ Results

typescript-bot · 2024-06-14T21:50:33Z

@gabritto Here are the results of running the top 800 repos with tsc comparing main and refs/pull/58859/merge:

Everything looks good!

gabritto · 2024-07-10T18:24:45Z

@typescript-bot perf test this
@typescript-bot test top800

typescript-bot · 2024-07-10T18:24:49Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results
`test top800`	✅ Started	✅ Results

gabritto · 2024-07-10T18:45:01Z

@typescript-bot user test this

typescript-bot · 2024-07-10T18:45:05Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`user test this`	✅ Started	👀 Results

typescript-bot · 2024-07-10T19:06:46Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,916k (± 1.00%)}	_{192,162k (± 0.03%)}	_~	_192,077k	_192,226k	_{p=0.298 n=6}
_{Parse Time}	_{1.96s (± 0.43%)}	_{1.95s (± 0.70%)}	_~	_1.93s	_1.96s	_{p=0.262 n=6}
_{Bind Time}	_{1.05s (± 0.79%)}	_{1.05s (± 1.11%)}	_~	_1.04s	_1.07s	_{p=0.555 n=6}
_{Check Time}	_{13.85s (± 0.61%)}	_{13.86s (± 0.31%)}	_~	_13.78s	_13.90s	_{p=0.570 n=6}
_{Emit Time}	_{4.03s (± 0.57%)}	_{4.04s (± 1.16%)}	_~	_3.95s	_4.08s	_{p=0.373 n=6}
_{Total Time}	_{20.89s (± 0.46%)}	_{20.90s (± 0.17%)}	_~	_20.84s	_20.95s	_{p=0.688 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,369k (± 0.00%)}	_{1,218,341k (± 0.00%)}	_~	_1,218,306k	_1,218,388k	_{p=0.230 n=6}
_{Parse Time}	_{7.94s (± 0.50%)}	_{7.97s (± 0.65%)}	_~	_7.93s	_8.07s	_{p=0.226 n=6}
_{Bind Time}	_{2.22s (± 0.66%)}	_{2.23s (± 0.57%)}	_~	_2.22s	_2.25s	_{p=0.198 n=6}
_{Check Time}	_{35.77s (± 0.23%)}	_{35.88s (± 0.29%)}	_~	_35.75s	_36.04s	_{p=0.078 n=6}
_{Emit Time}	_{16.21s (± 0.82%)}	_{16.15s (± 0.26%)}	_~	_16.10s	_16.21s	_{p=0.687 n=6}
_{Total Time}	_{62.14s (± 0.13%)}	_{62.23s (± 0.24%)}	_~	_62.01s	_62.43s	_{p=0.296 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,296	_2,130,296	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,656	_927,656	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,107,135k (± 0.01%)}	_{2,107,141k (± 0.01%)}	_~	_2,107,047k	_2,107,310k	_{p=1.000 n=6}
_{Parse Time}	_{7.82s (± 0.36%)}	_{7.81s (± 0.40%)}	_~	_7.75s	_7.83s	_{p=0.324 n=6}
_{Bind Time}	_{2.74s (± 0.56%)}	_{2.73s (± 0.95%)}	_~	_2.69s	_2.76s	_{p=0.565 n=6}
_{Check Time}	_{83.40s (± 0.35%)}	_{83.55s (± 0.35%)}	_~	_83.20s	_84.07s	_{p=0.688 n=6}
_{Emit Time}	_{0.16s (± 4.75%)}	_{0.16s (± 3.29%)}	_~	_0.15s	_0.16s	_{p=0.784 n=6}
_{Total Time}	_{94.12s (± 0.32%)}	_{94.25s (± 0.31%)}	_~	_93.94s	_94.79s	_{p=0.748 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,784	_1,225,809	_{+25 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,518	_261,522	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,338,907k (± 0.02%)}	_{2,339,004k (± 0.05%)}	_~	_2,338,265k	_2,341,142k	_{p=0.575 n=6}
_{Parse Time}	_{7.56s (± 0.66%)}	_{7.54s (± 0.57%)}	_~	_7.49s	_7.62s	_{p=0.688 n=6}
_{Bind Time}	_{2.81s (± 0.83%)}	_{2.80s (± 0.73%)}	_~	_2.77s	_2.83s	_{p=0.935 n=6}
_{Check Time}	_{49.50s (± 0.30%)}	_{49.52s (± 0.28%)}	_~	_49.41s	_49.75s	_{p=0.471 n=6}
_{Emit Time}	_{4.76s (± 1.61%)}	_{4.73s (± 1.26%)}	_~	_4.66s	_4.82s	_{p=0.423 n=6}
_{Total Time}	_{64.63s (± 0.31%)}	_{64.60s (± 0.27%)}	_~	_64.43s	_64.91s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,784	_1,225,809	_{+25 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,518	_261,522	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,412,730k (± 0.02%)}	_{2,413,490k (± 0.02%)}	_{+761k (+ 0.03%)}	_2,412,408k	_2,413,863k	_{p=0.045 n=6}
_{Parse Time}	_{7.89s (± 0.48%)}	_{7.83s (± 0.80%)}	_~	_7.75s	_7.91s	_{p=0.128 n=6}
_{Bind Time}	_{2.51s (± 0.59%)}	_{2.53s (± 0.92%)}	_~	_2.50s	_2.57s	_{p=0.222 n=6}
_{Check Time}	_{50.12s (± 0.23%)}	_{50.13s (± 0.25%)}	_~	_49.92s	_50.27s	_{p=0.575 n=6}
_{Emit Time}	_{4.88s (± 1.22%)}	_{4.79s (± 1.00%)}	_{-0.10s (- 2.01%)}	_4.72s	_4.84s	_{p=0.019 n=6}
_{Total Time}	_{65.41s (± 0.23%)}	_{65.29s (± 0.23%)}	_~	_65.02s	_65.40s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,268	_258,271	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,775	_104,779	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,125k (± 0.03%)}	_{427,113k (± 0.01%)}	_~	_427,043k	_427,221k	_{p=0.575 n=6}
_{Parse Time}	_{3.29s (± 0.78%)}	_{3.29s (± 0.61%)}	_~	_3.26s	_3.32s	_{p=0.746 n=6}
_{Bind Time}	_{1.30s (± 1.05%)}	_{1.32s (± 1.04%)}	_~	_1.29s	_1.33s	_{p=0.142 n=6}
_{Check Time}	_{17.77s (± 0.40%)}	_{17.82s (± 0.29%)}	_~	_17.72s	_17.86s	_{p=0.296 n=6}
_{Emit Time}	_{1.64s (± 0.46%)}	_{1.60s (± 0.75%)}	_{-0.03s (- 2.14%)}	_1.59s	_1.62s	_{p=0.005 n=6}
_{Total Time}	_{24.00s (± 0.39%)}	_{24.03s (± 0.24%)}	_~	_23.94s	_24.08s	_{p=0.748 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,534k (± 0.04%)}	_{369,523k (± 0.04%)}	_~	_369,388k	_369,814k	_{p=0.936 n=6}
_{Parse Time}	_{2.78s (± 1.58%)}	_{2.77s (± 1.04%)}	_~	_2.74s	_2.81s	_{p=0.684 n=6}
_{Bind Time}	_{1.59s (± 1.08%)}	_{1.59s (± 0.76%)}	_~	_1.58s	_1.61s	_{p=0.459 n=6}
_{Check Time}	_{15.52s (± 0.39%)}	_{15.51s (± 0.41%)}	_~	_15.41s	_15.59s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.89s (± 0.24%)}	_{19.87s (± 0.32%)}	_~	_19.76s	_19.93s	_{p=0.748 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,889,341	_2,889,341	_~	_~	_~	_{p=1.000 n=6}
_Types	_977,546	_977,546	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,052,777k (± 0.00%)}	_{3,052,788k (± 0.00%)}	_~	_3,052,700k	_3,052,869k	_{p=0.575 n=6}
_{Parse Time}	_{16.81s (± 0.32%)}	_{16.84s (± 0.49%)}	_~	_16.71s	_16.95s	_{p=0.688 n=6}
_{Bind Time}	_{5.11s (± 0.27%)}	_{5.11s (± 0.53%)}	_~	_5.08s	_5.14s	_{p=1.000 n=6}
_{Check Time}	_{92.35s (± 2.99%)}	_{91.35s (± 2.88%)}	_~	_89.34s	_94.74s	_{p=0.229 n=6}
_{Emit Time}	_{27.01s (± 9.59%)}	_{27.65s (± 8.98%)}	_~	_24.34s	_29.48s	_{p=0.810 n=6}
_{Total Time}	_{141.29s (± 0.16%)}	_{140.95s (± 0.23%)}	_~	_140.39s	_141.32s	_{p=0.066 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,235	_267,235	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,815	_108,815	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,783k (± 0.01%)}	_{411,811k (± 0.01%)}	_~	_411,775k	_411,856k	_{p=0.298 n=6}
_{Parse Time}	_{3.19s (± 0.74%)}	_{3.20s (± 0.47%)}	_~	_3.17s	_3.21s	_{p=0.461 n=6}
_{Bind Time}	_{1.40s (± 0.58%)}	_{1.41s (± 0.59%)}	_~	_1.39s	_1.41s	_{p=0.718 n=6}
_{Check Time}	_{14.19s (± 0.29%)}	_{14.22s (± 0.37%)}	_~	_14.15s	_14.29s	_{p=0.296 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.78s (± 0.31%)}	_{18.82s (± 0.28%)}	_~	_18.75s	_18.88s	_{p=0.199 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,958k (± 0.08%)}	_{463,184k (± 0.02%)}	_~	_463,030k	_463,293k	_{p=0.471 n=6}
_{Parse Time}	_{2.66s (± 0.57%)}	_{2.65s (± 0.41%)}	_~	_2.64s	_2.67s	_{p=0.618 n=6}
_{Bind Time}	_{0.98s (± 0.84%)}	_{0.98s (± 0.53%)}	_~	_0.97s	_0.98s	_{p=0.929 n=6}
_{Check Time}	_{15.19s (± 0.35%)}	_{15.20s (± 0.27%)}	_~	_15.16s	_15.27s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.82s (± 0.29%)}	_{18.83s (± 0.24%)}	_~	_18.78s	_18.91s	_{p=0.747 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,295ms (± 0.18%)}	_{2,292ms (± 0.60%)}	_~	_2,271ms	_2,306ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{5,082ms (± 0.77%)}	_{5,080ms (± 0.29%)}	_~	_5,054ms	_5,093ms	_{p=0.810 n=6}
_{Req 3 - references}	_{265ms (± 0.44%)}	_{265ms (± 0.28%)}	_~	_264ms	_266ms	_{p=0.933 n=6}
_{Req 4 - navto}	_{227ms (± 1.20%)}	_{228ms (± 0.18%)}	_~	_227ms	_228ms	_{p=0.474 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{91ms (± 5.94%)}	_{93ms (± 2.49%)}	_~	_91ms	_97ms	_{p=0.934 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,575ms (± 1.02%)}	_{3,583ms (± 1.53%)}	_~	_3,525ms	_3,657ms	_{p=0.688 n=6}
_{Req 2 - geterr}	_{5,539ms (± 0.59%)}	_{5,548ms (± 0.28%)}	_~	_5,526ms	_5,569ms	_{p=0.810 n=6}
_{Req 3 - references}	_{418ms (± 0.33%)}	_{417ms (± 0.33%)}	_~	_415ms	_419ms	_{p=0.253 n=6}
_{Req 4 - navto}	_{338ms (± 0.71%)}	_{339ms (± 1.03%)}	_~	_336ms	_346ms	_{p=0.319 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{109ms (± 2.59%)}	_{109ms (± 2.78%)}	_~	_103ms	_111ms	_{p=0.858 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,187ms (± 0.69%)}	_{5,205ms (± 0.50%)}	_~	_5,183ms	_5,255ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{1,125ms (± 1.27%)}	_{1,120ms (± 0.94%)}	_~	_1,111ms	_1,138ms	_{p=0.688 n=6}
_{Req 3 - references}	_{80ms (± 5.27%)}	_{77ms (± 3.11%)}	_~	_76ms	_82ms	_{p=0.325 n=6}
_{Req 4 - navto}	_{456ms (± 0.38%)}	_{458ms (± 0.26%)}	_~	_457ms	_460ms	_{p=0.081 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{842ms (± 1.72%)}	_{834ms (± 1.76%)}	_~	_819ms	_856ms	_{p=0.336 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{157.04ms (± 0.18%)}	_{156.88ms (± 0.17%)}	_{-0.16ms (- 0.10%)}	_155.74ms	_161.19ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{232.00ms (± 0.13%)}	_{232.11ms (± 0.16%)}	_{+0.11ms (+ 0.05%)}	_230.57ms	_237.89ms	_{p=0.014 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.37ms (± 0.16%)}	_{226.23ms (± 0.14%)}	_{-0.14ms (- 0.06%)}	_224.58ms	_228.25ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{225.97ms (± 0.17%)}	_{226.15ms (± 0.20%)}	_{+0.18ms (+ 0.08%)}	_224.42ms	_234.03ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-10T19:09:02Z

@gabritto Here are the results of running the user tests with tsc comparing main and refs/pull/58859/merge:

Something interesting changed - please have a look.

Details

effect

lodash

/mnt/ts_downloads/_/m/lodash/tsconfig.json

[NEW] error TS2740: Type 'SetCache' is missing the following properties from type 'any[]': length, pop, concat, join, and 34 more.
- /mnt/ts_downloads/_/m/lodash/node_modules/lodash/_baseUniq.js(39,5)
[MISSING] error TS2322: Type 'SetCache' is not assignable to type 'any[]'.
- /mnt/ts_downloads/_/m/lodash/node_modules/lodash/_baseUniq.js(39,5)

xterm.js

src/tsconfig-library-base.json

[NEW] error TS2740: Type 'TestBufferLine' is missing the following properties from type 'IBufferLine': length, isWrapped, get, set, and 23 more.
[MISSING] error TS2322: Type 'TestBufferLine' is not assignable to type 'IBufferLine'.

typescript-bot · 2024-07-10T21:09:07Z

@gabritto Here are the results of running the top 800 repos with tsc comparing main and refs/pull/58859/merge:

Everything looks good!

weswigham

Perf still looks fine, baselines look good, and I already approved the old version of the PR :)

gabritto added 3 commits May 28, 2024 13:47

add test

eea6eaa

always elaborate if reporting errors

bd87d48

get rid of reported flag on comparison result

5e6a51e

typescript-bot assigned gabritto Jun 13, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 13, 2024

Merge branch 'main' into gabritto/elaboration

34f3a87

gabritto added 3 commits July 8, 2024 15:27

update comment

f663817

wip

048aa52

remove debug logs

7ac6925

jakebailey closed this Jul 10, 2024

jakebailey reopened this Jul 10, 2024

Merge branch 'main' into gabritto/elaboration

6d95e18

gabritto changed the title ~~Make assignability error elaboration consistent~~ Make type comparison error elaboration consistent Jul 10, 2024

delete useless file

34f1a5e

typescript-bot removed the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 10, 2024

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 10, 2024

gabritto marked this pull request as ready for review July 11, 2024 00:43

weswigham approved these changes Jul 11, 2024

View reviewed changes

gabritto merged commit 0314372 into main Jul 15, 2024

gabritto deleted the gabritto/elaboration branch July 15, 2024 18:11

Andarist mentioned this pull request Jul 15, 2024

Don't skip elaborations when reporting errors for cached failed relations #55234

Closed

DanielRosenwasser mentioned this pull request Jul 19, 2024

Design Meeting Notes, 7/12/2024 #59362

Closed

LukeAbby mentioned this pull request Oct 12, 2024

"No error for last overload signature" regression in #58859 #60202

Closed

gabritto changed the title ~~Make type comparison error elaboration consistent~~ https://github.com/microsoft/TypeScript/pull/58220 Jul 10, 2025

microsoft locked as resolved and limited conversation to collaborators Jan 7, 2026

Conversation

gabritto commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabritto commented Jun 13, 2024

Uh oh!

typescript-bot commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 14, 2024

Uh oh!

typescript-bot commented Jun 14, 2024

/mnt/ts_downloads/_/m/lodash/tsconfig.json

Uh oh!

typescript-bot commented Jun 14, 2024

tsc

Uh oh!

typescript-bot commented Jun 14, 2024

Uh oh!

gabritto commented Jun 14, 2024

Uh oh!

gabritto commented Jun 14, 2024

Uh oh!

typescript-bot commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 14, 2024

Uh oh!

gabritto commented Jul 10, 2024

Uh oh!

typescript-bot commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabritto commented Jul 10, 2024

Uh oh!

typescript-bot commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 10, 2024

tsc

tsserver

startup

Uh oh!

typescript-bot commented Jul 10, 2024

/mnt/ts_downloads/_/m/lodash/tsconfig.json

Uh oh!

typescript-bot commented Jul 10, 2024

Uh oh!

weswigham left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gabritto commented Jun 13, 2024 •

edited

Loading

typescript-bot commented Jun 13, 2024 •

edited

Loading

typescript-bot commented Jun 14, 2024 •

edited

Loading

typescript-bot commented Jul 10, 2024 •

edited

Loading

typescript-bot commented Jul 10, 2024 •

edited

Loading