Provide Spelling Suggestions for Named Capture Group References in Regular Expressions#58613
Merged
rbuckton merged 1 commit intomicrosoft:mainfrom Jun 4, 2024
Merged
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
Author
|
IMO the current parameters in |
rbuckton
approved these changes
May 31, 2024
Contributor
rbuckton
left a comment
rbuckton
left a comment
There was a problem hiding this comment.
This looks good, but may not meet the bar for the 5.5 RC. We can merge this next week once main opens up for TypeScript 5.6.
Member
|
Any idea why I'm not able to see this in any nightly version of TypeScript?
|
Contributor
Author
|
@DanielRosenwasser I can’t see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#55600 already provides spelling suggestions for Unicode property value expressions (1a5228d), this PR extends it to capturing group names.