fix(dts): array buffer types (ES2024,ES2017)#57858
Conversation
|
I'm unsure what the licence agreement implies about original code, part of this PR is based on a stale PR linked at the top, since it's impossible to rebase the original one (it's 800 commits behind.) |
|
Not a lawyer, but they gave the PR away in #54637 (comment), so I would just add |
Thanks, sounds good. I can only do that revising and forcing a push I think. Is this fine for you? I will accept the CLA after doing that. |
|
Yes, feel free to force push |
Co-authored-by: Indrajeet Nikam <indrajitbnikam@gmail.com>
done, it did work because the profile picture is correct in the co-authored commit. |
|
@microsoft-github-policy-service agree |
|
Still needs some tests #54637 (review) and also for the new def of |
|
Any update on this? |
I can't spend the time now (tendonitis.) I think it needs some tests only. Feel free to take over the PR. |
| interface ArrayBuffer { | ||
| /** | ||
| * If this ArrayBuffer is resizable, returns the maximum byte length given during construction; returns the byte length if not. | ||
| */ | ||
| get maxByteLength(): number; | ||
| /** | ||
| * Returns true if this ArrayBuffer can be resized. | ||
| */ | ||
| get resizable(): boolean; | ||
|
|
||
| /** | ||
| * Resizes the ArrayBuffer to the specified size (in bytes). | ||
| * @param newByteLength The new length, in bytes, to resize the ArrayBuffer to. | ||
| */ | ||
| resize(newByteLength: number): undefined; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think there are other methods and properties that need to be added. Like this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/detached
ghost
closed this by deleting the head repository
|
Oh, It appears that the account has been lost. I'll take it instead. |
|
@petamoriken Status? |
|
@guest271314 Please see #58573 |
8 participants
This should be an updated, and hopefully correct fix from the stale PR here #54637.
In summary this PR is an extension of the previous PR with several modifications (to comments, interfaces, references etc.) The previous PR included ArrayBuffer-related interfaces that are part of ES2024.
It passes most of the tests with the exceptions of baselines from what I understand, so those are accepted and send with a commit.
Would be useful to get some feedback if this looks good in principle @petamoriken @sandersn, I've included most of the reviews you made in the stale PR that I linked earlier.
Fixes #54636