Skip to content

correctly capture 'this' when converting loops into functions#5747

Merged
vladima merged 2 commits into
masterfrom
thisWithLetConst
Nov 23, 2015
Merged

correctly capture 'this' when converting loops into functions#5747
vladima merged 2 commits into
masterfrom
thisWithLetConst

Conversation

@vladima

@vladima vladima commented Nov 22, 2015

Copy link
Copy Markdown
Contributor

fixes #5746

Comment thread src/compiler/emitter.ts Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calline -> calling

@RyanCavanaugh

Copy link
Copy Markdown
Member

👍

vladima added a commit that referenced this pull request Nov 23, 2015
correctly capture 'this' when converting loops into functions
@vladima vladima merged commit fbaba90 into master Nov 23, 2015
@vladima vladima deleted the thisWithLetConst branch November 23, 2015 05:53
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'this' not appropriately captured when downleveling loop with block-scoped variable

3 participants