fix(57141): override keyword doesn't check symbol-key class members - #57146
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
Nathan Shively-Sanders (sandersn)
requested review from
Isabel Duan (iisaduan) and
Ron Buckton (rbuckton)
February 15, 2024 19:55
Isabel Duan (iisaduan)
requested changes
Mar 12, 2024
Isabel Duan (iisaduan)
left a comment
Isabel Duan (iisaduan)
left a comment
Member
There was a problem hiding this comment.
The nodeModules.... baselines should be reverted since #57220 was merged after this PR was last updated. Pulling/merging main, and then updating baselines should revert them!
Otherwise, the PR looks good!
Isabel Duan (iisaduan)
approved these changes
Mar 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57141