Fixed an issue with string mappings over generic intersections not being deferred in conditional types by Andarist · Pull Request #55856 · microsoft/TypeScript

Andarist · 2023-09-25T10:44:50Z

…ing deferred in conditional types

jakebailey · 2023-09-25T19:02:08Z

This looks good to me (having touched this recently), but:

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-09-25T19:02:11Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 9f56c7f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-25T19:02:12Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 9f56c7f. You can monitor the build here.

typescript-bot · 2023-09-25T19:02:12Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 9f56c7f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-25T19:02:12Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 9f56c7f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-25T19:02:12Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 9f56c7f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-25T19:03:56Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157926/artifacts?artifactName=tgz&fileId=1FA9231F21A39E8A58C48819B07BF08D74C3576968C20B4DB594B040867ABB8802&fileName=/typescript-5.3.0-insiders.20230925.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-55856-6".;

typescript-bot · 2023-09-25T19:21:55Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55856/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-25T19:24:08Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{294,974k (± 0.01%)}	_{294,952k (± 0.01%)}	_~	_294,908k	_294,991k	_{p=0.230 n=6}
_{Parse Time}	_{2.61s (± 0.32%)}	_{2.61s (± 0.71%)}	_~	_2.60s	_2.65s	_{p=0.607 n=6}
_{Bind Time}	_{0.84s (± 1.23%)}	_{0.83s (± 0.98%)}	_~	_0.83s	_0.85s	_{p=0.595 n=6}
_{Check Time}	_{8.06s (± 0.35%)}	_{8.06s (± 0.24%)}	_~	_8.03s	_8.08s	_{p=1.000 n=6}
_{Emit Time}	_{7.04s (± 0.45%)}	_{7.06s (± 0.53%)}	_~	_7.00s	_7.09s	_{p=0.260 n=6}
_{Total Time}	_{18.56s (± 0.22%)}	_{18.57s (± 0.24%)}	_~	_18.51s	_18.63s	_{p=0.748 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,129k (± 1.25%)}	_{191,670k (± 1.23%)}	_~	_190,687k	_196,485k	_{p=0.173 n=6}
_{Parse Time}	_{1.34s (± 0.61%)}	_{1.35s (± 0.86%)}	_{+0.01s (+ 1.12%)}	_1.34s	_1.37s	_{p=0.039 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.14s (± 0.72%)}	_{9.12s (± 0.59%)}	_~	_9.03s	_9.18s	_{p=0.873 n=6}
_{Emit Time}	_{2.63s (± 0.56%)}	_{2.63s (± 0.40%)}	_~	_2.61s	_2.64s	_{p=0.805 n=6}
_{Total Time}	_{13.84s (± 0.37%)}	_{13.83s (± 0.43%)}	_~	_13.72s	_13.89s	_{p=1.000 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,219k (± 0.01%)}	_{347,216k (± 0.01%)}	_~	_347,173k	_347,248k	_{p=0.873 n=6}
_{Parse Time}	_{2.45s (± 0.42%)}	_{2.46s (± 0.36%)}	_~	_2.45s	_2.47s	_{p=0.273 n=6}
_{Bind Time}	_{0.94s (± 0.00%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=1.000 n=6}
_{Check Time}	_{6.88s (± 0.39%)}	_{6.85s (± 0.43%)}	_~	_6.80s	_6.88s	_{p=0.141 n=6}
_{Emit Time}	_{4.02s (± 0.24%)}	_{4.02s (± 0.49%)}	_~	_3.99s	_4.04s	_{p=0.802 n=6}
_{Total Time}	_{14.29s (± 0.25%)}	_{14.27s (± 0.18%)}	_~	_14.24s	_14.30s	_{p=0.168 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,495k (± 0.01%)}	_{302,488k (± 0.01%)}	_~	_302,468k	_302,523k	_{p=0.297 n=6}
_{Parse Time}	_{2.01s (± 0.97%)}	_{2.01s (± 0.68%)}	_~	_1.99s	_2.03s	_{p=0.567 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.01s (± 1.32%)}	_~	_1.00s	_1.03s	_{p=0.462 n=6}
_{Check Time}	_{6.26s (± 0.34%)}	_{6.24s (± 0.49%)}	_{-0.02s (- 0.40%)}	_6.22s	_6.30s	_{p=0.048 n=6}
_{Emit Time}	_{3.55s (± 1.08%)}	_{3.52s (± 0.80%)}	_~	_3.49s	_3.57s	_{p=0.372 n=6}
_{Total Time}	_{12.82s (± 0.55%)}	_{12.78s (± 0.27%)}	_~	_12.74s	_12.83s	_{p=0.466 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,449k (± 0.00%)}	_{470,450k (± 0.00%)}	_~	_470,427k	_470,478k	_{p=0.936 n=6}
_{Parse Time}	_{2.56s (± 0.35%)}	_{2.57s (± 0.49%)}	_~	_2.56s	_2.59s	_{p=0.209 n=6}
_{Bind Time}	_{0.99s (± 0.55%)}	_{0.99s (± 0.82%)}	_~	_0.98s	_1.00s	_{p=0.859 n=6}
_{Check Time}	_{16.60s (± 0.19%)}	_{16.59s (± 0.60%)}	_~	_16.50s	_16.73s	_{p=0.422 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.16s (± 0.17%)}	_{20.15s (± 0.53%)}	_~	_20.05s	_20.31s	_{p=0.520 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,556k (± 0.02%)}	_{512,514k (± 0.01%)}	_~	_512,441k	_512,575k	_{p=0.378 n=6}
_{Parse Time}	_{3.27s (± 0.12%)}	_{3.27s (± 0.26%)}	_~	_3.26s	_3.28s	_{p=0.285 n=6}
_{Bind Time}	_{1.55s (± 0.33%)}	_{1.55s (± 0.48%)}	_~	_1.54s	_1.56s	_{p=0.241 n=6}
_{Check Time}	_{2.83s (± 0.49%)}	_{2.84s (± 0.79%)}	_~	_2.80s	_2.86s	_{p=0.745 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 9.21%)}	_~	_0.07s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{7.73s (± 0.19%)}	_{7.73s (± 0.26%)}	_~	_7.71s	_7.75s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,350ms (± 0.93%)}	_{2,350ms (± 1.24%)}	_~	_2,324ms	_2,398ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{5,371ms (± 1.62%)}	_{5,375ms (± 1.52%)}	_~	_5,257ms	_5,448ms	_{p=0.810 n=6}
_{Req 3 - references}	_{329ms (± 1.50%)}	_{327ms (± 0.57%)}	_~	_325ms	_330ms	_{p=0.371 n=6}
_{Req 4 - navto}	_{275ms (± 0.78%)}	_{276ms (± 1.11%)}	_~	_272ms	_281ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 8.13%)}	_{86ms (± 7.12%)}	_~	_76ms	_90ms	_{p=0.652 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,461ms (± 1.60%)}	_{2,466ms (± 1.18%)}	_~	_2,421ms	_2,495ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{4,153ms (± 1.94%)}	_{4,141ms (± 1.92%)}	_~	_4,062ms	_4,231ms	_{p=0.423 n=6}
_{Req 3 - references}	_{336ms (± 1.03%)}	_{338ms (± 1.28%)}	_~	_333ms	_343ms	_{p=0.328 n=6}
_{Req 4 - navto}	_{283ms (± 0.43%)}	_{283ms (± 0.18%)}	_~	_283ms	_284ms	_{p=0.351 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 7.19%)}	_{79ms (± 7.50%)}	_~	_75ms	_87ms	_{p=0.285 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,596ms (± 0.41%)}	_{2,600ms (± 0.44%)}	_~	_2,579ms	_2,608ms	_{p=0.260 n=6}
_{Req 2 - geterr}	_{1,706ms (± 1.55%)}	_{1,674ms (± 1.68%)}	_~	_1,640ms	_1,721ms	_{p=0.093 n=6}
_{Req 3 - references}	_{121ms (± 6.58%)}	_{113ms (± 8.62%)}	_~	_106ms	_126ms	_{p=0.106 n=6}
_{Req 4 - navto}	_{360ms (± 0.76%)}	_{360ms (± 0.49%)}	_~	_358ms	_363ms	_{p=0.802 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{306ms (± 1.62%)}	_{305ms (± 1.90%)}	_~	_297ms	_313ms	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{151.89ms (± 0.15%)}	_{151.98ms (± 0.18%)}	_{+0.09ms (+ 0.06%)}	_150.85ms	_155.36ms	_{p=0.005 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.62ms (± 0.18%)}	_{227.38ms (± 0.15%)}	_{-0.23ms (- 0.10%)}	_225.78ms	_232.51ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.09ms (± 0.19%)}	_{229.27ms (± 0.18%)}	_{+0.18ms (+ 0.08%)}	_227.65ms	_235.68ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.88ms (± 0.22%)}	_{228.58ms (± 0.15%)}	_{-0.30ms (- 0.13%)}	_227.07ms	_234.10ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-25T20:30:00Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-09-25T21:14:33Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55856/merge:

Everything looks good!

sankantsu · 2023-09-26T16:19:30Z

Thank you for creating PR!

It seems still fails in some (very artificial) examples...

type E<S> = Lowercase<`f${S & string}` & `${S & string}f`>
>E : Lowercase<`f${S & string}` & `${S & string}f`>

type F = E<""> extends "f" ? 1 : 0
>F : 1

type G<S> = E<S> extends "f" ? 1 : 0
>G : 0

let x5: G<""> = 1;
>x5 : 0
>1 : 1

E<""> is "f", so G<""> should be 1

Playground link (v5.0.4)

Andarist · 2023-09-26T16:36:20Z

Ah, ye - I see why it might fail. I'll try to improve the fix in a moment to handle more crazy scenarios like this recursively.

src/compiler/checker.ts

ahejlsberg · 2023-09-29T01:10:00Z

src/compiler/checker.ts

-    function isPatternLiteralPlaceholderType(type: Type): boolean {
+    function isPatternLiteralPlaceholderType(type: Type, ignoreGenericIntersections = false): boolean {
        if (type.flags & TypeFlags.Intersection) {
-            return some((type as IntersectionType).types, t => !!(t.flags & (TypeFlags.Literal | TypeFlags.Null | TypeFlags.Undefined)) || isPatternLiteralPlaceholderType(t));


I think this entire fix can be simplified to simply adding a check that the type isn't generic:

return !isGenericType(type) && some(...);

Generic types should never be classified as placeholders since upon instantiation they may become something completely different.

Oh, that's cool! Thanks for the tip. I was worried that addSpans would fail if I did something like this. It seems that (somewhat confusingly) isGenericIndexType already returns true for an intersection like this so addSpans is covered.

jakebailey · 2023-09-29T16:48:56Z

LGTM but just going to double check:

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-09-29T16:49:00Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 5d29c23. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-29T16:49:00Z

Heya @jakebailey, I've started to run the tsc-only perf test suite on this PR at 5d29c23. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-29T16:49:00Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 5d29c23. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-29T16:49:00Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 5d29c23. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-29T17:02:09Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{294,998k (± 0.01%)}	_{295,000k (± 0.01%)}	_~	_294,951k	_295,054k	_{p=1.000 n=6}
_{Parse Time}	_{2.63s (± 0.42%)}	_{2.63s (± 0.66%)}	_~	_2.60s	_2.65s	_{p=0.365 n=6}
_{Bind Time}	_{0.84s (± 1.06%)}	_{0.84s (± 1.06%)}	_~	_0.83s	_0.85s	_{p=1.000 n=6}
_{Check Time}	_{8.08s (± 0.36%)}	_{8.06s (± 0.12%)}	_~	_8.05s	_8.07s	_{p=0.289 n=6}
_{Emit Time}	_{7.03s (± 0.25%)}	_{7.04s (± 0.29%)}	_~	_7.01s	_7.07s	_{p=0.935 n=6}
_{Total Time}	_{18.58s (± 0.17%)}	_{18.57s (± 0.12%)}	_~	_18.55s	_18.61s	_{p=0.747 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,089k (± 1.24%)}	_{192,597k (± 1.56%)}	_~	_190,606k	_196,482k	_{p=0.810 n=6}
_{Parse Time}	_{1.35s (± 1.11%)}	_{1.35s (± 0.87%)}	_~	_1.34s	_1.37s	_{p=0.730 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.21s (± 0.65%)}	_{9.18s (± 0.17%)}	_~	_9.15s	_9.19s	_{p=0.683 n=6}
_{Emit Time}	_{2.62s (± 0.54%)}	_{2.63s (± 0.62%)}	_~	_2.61s	_2.65s	_{p=0.568 n=6}
_{Total Time}	_{13.92s (± 0.44%)}	_{13.88s (± 0.18%)}	_~	_13.85s	_13.91s	_{p=0.293 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,239k (± 0.00%)}	_{347,226k (± 0.01%)}	_~	_347,204k	_347,248k	_{p=0.229 n=6}
_{Parse Time}	_{2.45s (± 0.36%)}	_{2.46s (± 0.42%)}	_~	_2.44s	_2.47s	_{p=0.273 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{6.89s (± 0.51%)}	_{6.88s (± 0.50%)}	_~	_6.84s	_6.93s	_{p=0.687 n=6}
_{Emit Time}	_{4.03s (± 0.38%)}	_{4.03s (± 0.37%)}	_~	_4.01s	_4.05s	_{p=0.801 n=6}
_{Total Time}	_{14.31s (± 0.26%)}	_{14.30s (± 0.28%)}	_~	_14.26s	_14.35s	_{p=0.466 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,529k (± 0.01%)}	_{302,550k (± 0.01%)}	_~	_302,519k	_302,582k	_{p=0.336 n=6}
_{Parse Time}	_{2.00s (± 1.32%)}	_{2.00s (± 0.82%)}	_~	_1.98s	_2.02s	_{p=0.807 n=6}
_{Bind Time}	_{1.01s (± 1.08%)}	_{1.01s (± 0.51%)}	_~	_1.00s	_1.01s	_{p=0.670 n=6}
_{Check Time}	_{6.27s (± 0.60%)}	_{6.26s (± 0.52%)}	_~	_6.20s	_6.29s	_{p=0.872 n=6}
_{Emit Time}	_{3.54s (± 0.85%)}	_{3.55s (± 0.96%)}	_~	_3.51s	_3.59s	_{p=0.461 n=6}
_{Total Time}	_{12.82s (± 0.31%)}	_{12.80s (± 0.50%)}	_~	_12.74s	_12.89s	_{p=0.520 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,489k (± 0.00%)}	_{470,484k (± 0.00%)}	_~	_470,471k	_470,503k	_{p=0.810 n=6}
_{Parse Time}	_{2.57s (± 0.38%)}	_{2.57s (± 0.52%)}	_~	_2.55s	_2.59s	_{p=0.858 n=6}
_{Bind Time}	_{0.99s (± 1.64%)}	_{1.00s (± 0.75%)}	_~	_0.99s	_1.01s	_{p=0.741 n=6}
_{Check Time}	_{16.56s (± 0.32%)}	_{16.64s (± 0.48%)}	_~	_16.56s	_16.78s	_{p=0.066 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.12s (± 0.30%)}	_{20.21s (± 0.34%)}	_~	_20.15s	_20.33s	_{p=0.108 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,548k (± 0.02%)}	_{512,580k (± 0.02%)}	_~	_512,495k	_512,729k	_{p=0.378 n=6}
_{Parse Time}	_{3.26s (± 0.41%)}	_{3.27s (± 0.30%)}	_~	_3.25s	_3.28s	_{p=0.340 n=6}
_{Bind Time}	_{1.55s (± 0.33%)}	_{1.55s (± 0.33%)}	_~	_1.54s	_1.55s	_{p=1.000 n=6}
_{Check Time}	_{2.83s (± 1.15%)}	_{2.85s (± 1.03%)}	_~	_2.82s	_2.90s	_{p=0.293 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 5.21%)}	_~	_0.07s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.72s (± 0.55%)}	_{7.74s (± 0.32%)}	_~	_7.72s	_7.79s	_{p=0.225 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-29T17:08:02Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55856/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-29T18:05:24Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-09-29T18:59:58Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55856/merge:

Everything looks good!

sandersn · 2023-10-25T20:41:34Z

@jakebailey @ahejlsberg is this a fix intended for 5.3, or should we wait until 5.4?

jakebailey · 2023-10-25T20:52:34Z

Probably meant for 5.3, not sure why we didn't merge it as we both approved

Fixed an issue with string mappings over generic intersections not be…

5c9a5a7

…ing deferred in conditional types

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 25, 2023

add extra test cases

9f56c7f

Fixed an extra test case

f063271

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 27, 2023

Andarist commented Sep 27, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

ahejlsberg requested changes Sep 29, 2023

View reviewed changes

Andarist added 2 commits September 29, 2023 08:20

Simplify the fix

a678738

remove redundant passthrough function

5d29c23

ahejlsberg approved these changes Sep 29, 2023

View reviewed changes

jakebailey approved these changes Sep 29, 2023

View reviewed changes

sandersn merged commit 41ebfbf into microsoft:main Oct 26, 2023

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

Andarist commented Sep 25, 2023

Uh oh!

jakebailey commented Sep 25, 2023

Uh oh!

typescript-bot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 25, 2023

Uh oh!

typescript-bot commented Sep 25, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Sep 25, 2023

Uh oh!

typescript-bot commented Sep 25, 2023

Uh oh!

sankantsu commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andarist commented Sep 26, 2023

Uh oh!

Uh oh!

ahejlsberg Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

Andarist Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Sep 29, 2023

Uh oh!

typescript-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2023

Compiler

Uh oh!

typescript-bot commented Sep 29, 2023

Uh oh!

typescript-bot commented Sep 29, 2023

Uh oh!

typescript-bot commented Sep 29, 2023

Uh oh!

sandersn commented Oct 25, 2023

Uh oh!

jakebailey commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

typescript-bot commented Sep 25, 2023 •

edited

Loading

typescript-bot commented Sep 25, 2023 •

edited

Loading

typescript-bot commented Sep 25, 2023 •

edited

Loading

typescript-bot commented Sep 25, 2023 •

edited

Loading

typescript-bot commented Sep 25, 2023 •

edited

Loading

typescript-bot commented Sep 25, 2023 •

edited

Loading

sankantsu commented Sep 26, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading