Experiment: Convert Promise<void> to Promise<undefined> by sandersn · Pull Request #55096 · microsoft/TypeScript

Nathan Shively-Sanders (sandersn) · 2023-07-20T20:11:55Z

As suggested in microsoft/TypeScript-DOM-lib-generator#1598

Nathan Shively-Sanders (sandersn) · 2023-07-20T20:13:23Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (typescript-bot) · 2023-07-20T20:13:25Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the extended test suite on this PR at 8139c3c. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-07-20T20:13:25Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at 8139c3c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-07-20T20:13:25Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based user code test suite on this PR at 8139c3c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-07-20T20:13:25Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based top-repos suite on this PR at 8139c3c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-07-20T20:40:31Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the user test suite comparing main and refs/pull/55096/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55096/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

TypeScript Bot (typescript-bot) · 2023-07-20T22:02:22Z

Nathan Shively-Sanders (@sandersn) Here are the results of running the top-repos suite comparing main and refs/pull/55096/merge:

Something interesting changed - please have a look.

Details

angular/angular-cli

4 of 19 projects failed to build with the old tsc and were ignored

tests/legacy-cli/tsconfig.json

error TS2769: No overload matches this call.
- tests/legacy-cli/e2e/utils/assets.ts#L31

Eugeny/tabby

9 of 29 projects failed to build with the old tsc and were ignored

tabby-community-color-schemes/tsconfig.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

tabby-electron/tsconfig.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

tabby-linkifier/tsconfig.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

tabby-local/tsconfig.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

tabby-serial/tsconfig.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

tabby-ssh/tsconfig.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

tabby-telnet/tsconfig.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

tabby-terminal/tsconfig.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

tabby-terminal/tsconfig.typings.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

tabby-web-demo/tsconfig.json

error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L457

microsoft/vscode

5 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2322: Type 'Promise<void>' is not assignable to type 'Promise<undefined>'.
error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
error TS7030: Not all code paths return a value.
- src/vs/workbench/contrib/remote/browser/tunnelView.ts#L1282
- src/vs/workbench/contrib/remote/browser/tunnelView.ts#L1311

vuejs/core

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2345: Argument of type 'import("stream/web").WritableStream<any>' is not assignable to parameter of type 'WritableStream<any>'.
- packages/server-renderer/__tests__/webStream.spec.ts#L52

TypeScript Bot (typescript-bot) · 2023-07-20T22:19:59Z

Hey Nathan Shively-Sanders (@sandersn), the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: chrome-apps
Error:

Error: Errors in typescript@local for external dependencies:
../../../../../../built/local/lib.dom.d.ts(6729,11): error TS2430: Interface 'Document' incorrectly extends interface 'NonElementParentNode'.
  The types returned by 'getElementById(...)' are incompatible between these types.
    Type 'HTMLElement | null' is not assignable to type 'Element | null'.
      Type 'HTMLElement' is not assignable to type 'Element'.
        The types returned by 'requestFullscreen(...)' are incompatible between these types.
          Type 'Promise<void>' is not assignable to type 'Promise<undefined>'.
            Type 'void' is not assignable to type 'undefined'.
../../../../../../built/local/lib.dom.d.ts(6756,40): error TS2344: Type 'HTMLAnchorElement' does not satisfy the constraint 'Element'.
  Types of property 'requestFullscreen' are incompatible.
    Type '() => Promise<void>' is not assignable to type '(options?: FullscreenOptions | undefined) => Promise<undefined>'.
../../../../../../built/local/lib.dom.d.ts(6868,39): error TS2344: Type 'HTMLEmbedElement' does not satisfy the constraint 'Element'.
  Types of property 'requestFullscreen' are incompatible.
    Type '() => Promise<void>' is not assignable to type '(options?: FullscreenOptions | undefined) => Promise<undefined>'.
../../../../../../built/local/lib.dom.d.ts(6881,38): error TS2344: Type 'HTMLFormElement' does not satisfy the constraint 'Element'.
  Types of property 'requestFullscreen' are incompatible.
    Type '() => Promise<void>' is not assignable to type '(options?: FullscreenOptions | undefined) => Promise<undefined>'.
../../../../../../built/local/lib.dom.d.ts(6907,39): error TS2344: Type 'HTMLImageElement' does not satisfy the constraint 'Element'.
  Types of property 'requestFullscreen' are incompatible.
    Type '() => Promise<void>' is not assignable to type '(options?: FullscreenOptions | undefined) => Promise<undefined>'.
../../../../../../built/local/lib.dom.d.ts(6939,38): error TS2344: Type 'HTMLAnchorElement | HTMLAreaElement' does not satisfy the constraint 'Element'.
  Type 'HTMLAnchorElement' is not assignable to type 'Element'.
../../../../../../built/local/lib.dom.d.ts(6972,40): error TS2344: Type 'HTMLEmbedElement' does not satisfy the constraint 'Element'.
../../../../../../built/local/lib.dom.d.ts(6996,40): error TS2344: Type 'HTMLScriptElement' does not satisfy the constraint 'Element'.
  Types of property 'requestFullscreen' are incompatible.
    Type '() => Promise<void>' is not assignable to type '(options?: FullscreenOptions | undefined) => Promise<undefined>'.
../../../../../../built/local/lib.dom.d.ts(7251,101): error TS2344: Type 'HTMLElementTagNameMap[K]' does not satisfy the constraint 'Element'.
  Type 'HTMLElement | HTMLCanvasElement | HTMLImageElement | HTMLVideoElement | HTMLAnchorElement | ... 59 more ... | HTMLWebViewElement' is not assignable to type 'Element'.
    Type 'HTMLElement' is not assignable to type 'Element'.
../../../../../../built/local/lib.dom.d.ts(7255,111): error TS2344: Type 'HTMLElementDeprecatedTagNameMap[K]' does not satisfy the constraint 'Element'.
  Type 'HTMLElement | HTMLPreElement | HTMLUnknownElement | HTMLFontElement | HTMLDirectoryElement | HTMLFrameElement | HTMLFrameSetElement | HTMLMarqueeElement | HTMLParamElement' is not assignable to type 'Element'.
    Type 'HTMLElement' is not assignable to type 'Element'.
../../../../../../built/local/lib.dom.d.ts(7268,111): error TS2344: Type 'HTMLElement' does not satisfy the constraint 'Element'.
../../../../../../built/local/lib.dom.d.ts(7383,11): error TS2430: Interface 'DocumentFragment' incorrectly extends interface 'NonElementParentNode'.
  The types returned by 'getElementById(...)' are incompatible between these types.
    Type 'HTMLElement | null' is not assignable to type 'Element | null'.
../../../../../../built/local/lib.dom.d.ts(7729,101): error TS2344: Type 'HTMLElementTagNameMap[K]' does not satisfy the constraint 'Element'.
  Type 'HTMLElement | HTMLCanvasElement | HTMLImageElement | HTMLVideoElement | HTMLAnchorElement | ... 59 more ... | HTMLWebViewElement' is not assignable to type 'Element'.
../../../../../../built/local/lib.dom.d.ts(7733,111): error TS2344: Type 'HTMLElementDeprecatedTagNameMap[K]' does not satisfy the constraint 'Element'.
  Type 'HTMLElement | HTMLPreElement | HTMLUnknownElement | HTMLFontElement | HTMLDirectoryElement | HTMLFrameElement | HTMLFrameSetElement | HTMLMarqueeElement | HTMLParamElement' is not assignable to type 'Element'.
../../../../../../built/local/lib.dom.d.ts(7736,111): error TS2344: Type 'HTMLElement' does not satisfy the constraint 'Element'.
../../../../../../built/local/lib.dom.d.ts(9927,40): error TS2344: Type 'HTMLOptionElement' does not satisfy the constraint 'Element'.
  Types of property 'requestFullscreen' are incompatible.
    Type '() => Promise<void>' is not assignable to type '(options?: FullscreenOptions | undefined) => Promise<undefined>'.
../../../../../../built/local/lib.dom.d.ts(10049,11): error TS2430: Interface 'HTMLElement' incorrectly extends interface 'Element'.
../../../../../../built/local/lib.dom.d.ts(11998,58): error TS2344: Type 'HTMLOptionElement' does not satisfy the constraint 'Element'.
../../../../../../built/local/lib.dom.d.ts(12384,48): error TS2344: Type 'HTMLOptionElement' does not satisfy the constraint 'Element'.
../../../../../../built/local/lib.dom.d.ts(12851,37): error TS2344: Type 'HTMLTableRowElement' does not satisfy the constraint 'Element'.
  Types of property 'requestFullscreen' are incompatible.
    Type '() => Promise<void>' is not assignable to type '(options?: FullscreenOptions | undefined) => Promise<undefined>'.
../../../../../../built/local/lib.dom.d.ts(12871,40): error TS2344: Type 'HTMLTableSectionElement' does not satisfy the constraint 'Element'.
  Types of property 'requestFullscreen' are incompatible.
    Type '() => Promise<void>' is not assignable to type '(options?: FullscreenOptions | undefined) => Promise<undefined>'.
../../../../../../built/local/lib.dom.d.ts(12990,38): error TS2344: Type 'HTMLTableCellElement' does not satisfy the constraint 'Element'.
  Types of property 'requestFullscreen' are incompatible.
    Type '() => Promise<void>' is not assignable to type '(options?: FullscreenOptions | undefined) => Promise<undefined>'.
../../../../../../built/local/lib.dom.d.ts(13076,37): error TS2344: Type 'HTMLTableRowElement' does not satisfy the constraint 'Element'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: dexie-batch
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/dexie/dist/dexie.d.ts(55,18): error TS2430: Interface 'PromiseExtendedConstructor' incorrectly extends interface 'PromiseConstructor'.
  Types of property 'resolve' are incompatible.
    Type '{ <T>(value: T | PromiseLike<T>): PromiseExtended<T>; (): PromiseExtended<void>; }' is not assignable to type '{ (): Promise<undefined>; <T>(value: T): Promise<Awaited<T>>; <T>(value: T | PromiseLike<T>): Promise<Awaited<T>>; }'.
      Target signature provides too few arguments. Expected 1 or more, but got 0.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: es-abstract
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/es-abstract/test/es5.test.ts:47:1
ERROR: 47:1  expect  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: dom-mediacapture-transform
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/dom-mediacapture-transform/dom-mediacapture-transform-tests.ts:68:9
ERROR: 68:9   expect  TypeScript@local expected type to be:
  void
got:
  undefined
ERROR: 145:9  expect  TypeScript@local expected type to be:
  void
got:
  undefined

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: chillout
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/chillout/chillout-tests.ts:54:1
ERROR: 54:1   expect  TypeScript@local expected type to be:
  ChilloutIterator<Promise<void>, null>
got:
  ChilloutIterator<Promise<undefined>, null>
ERROR: 106:1  expect  TypeScript@local expected type to be:
  ChilloutIterator<Promise<void>, null>
got:
  ChilloutIterator<Promise<undefined>, null>
ERROR: 168:1  expect  TypeScript@local expected type to be:
  ChilloutIterator<Promise<void>, null>
got:
  ChilloutIterator<Promise<undefined>, null>
ERROR: 200:1  expect  TypeScript@local expected type to be:
  ChilloutIterator<Promise<void>, null>
got:
  ChilloutIterator<Promise<undefined>, null>
ERROR: 253:1  expect  TypeScript@local expected type to be:
  ChilloutIterator<Promise<void>, null>
got:
  ChilloutIterator<Promise<undefined>, null>

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: promise-debounce
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/promise-debounce/promise-debounce-tests.ts:4:1
ERROR: 4:1  expect  TypeScript@local expected type to be:
  () => Promise<void>
got:
  () => Promise<undefined>

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

Experiment: Convert Promise<void> to Promise<undefined>

8139c3c

As suggested in microsoft/TypeScript-DOM-lib-generator#1598

TypeScript Bot (typescript-bot) assigned Nathan Shively-Sanders (sandersn) Jul 20, 2023

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 20, 2023

Nathan Shively-Sanders (sandersn) closed this Jul 21, 2023

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Nathan Shively-Sanders (sandersn) commented Jul 20, 2023

Uh oh!

Nathan Shively-Sanders (sandersn) commented Jul 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 20, 2023

/mnt/ts_downloads/rxjs-src/build.sh

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TypeScript Bot (typescript-bot) commented Jul 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jul 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jul 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jul 20, 2023 •

edited

Loading