Skip to content

fix(54992): Negative constant enums return number when toString is called#55031

Closed
a-tarasyuk wants to merge 1 commit intomicrosoft:mainfrom
a-tarasyuk:fix/54992
Closed

fix(54992): Negative constant enums return number when toString is called#55031
a-tarasyuk wants to merge 1 commit intomicrosoft:mainfrom
a-tarasyuk:fix/54992

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Jul 15, 2023 •
edited
Loading

No description provided.

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 15, 2023
@a-tarasyuk a-tarasyuk marked this pull request as ready for review July 15, 2023 20:11
Andarist
Andarist reviewed Jul 15, 2023
View reviewed changes
Andarist
Andarist reviewed Jul 15, 2023
View reviewed changes
Andarist
Andarist reviewed Jul 15, 2023
View reviewed changes
Andarist
Andarist reviewed Jul 15, 2023
View reviewed changes
@Andarist
Copy link
Contributor

Andarist commented Jul 15, 2023

Adding parenthesis could create other problems - but I guess that's not really possible since the emitter prefers semicolons. Is that right? Or am I missing some edge cases in which an accidental function call could be created?

@a-tarasyuk a-tarasyuk closed this Jul 18, 2023
@a-tarasyuk a-tarasyuk deleted the fix/54992 branch July 18, 2023 16:09
@jakebailey
Copy link
Member

jakebailey commented Jul 18, 2023

What happened to this PR? Was it totally wrong in some way?

FWIW, here's what esbuild does; thankfully doesn't have this problem, but my recollection of this PR before it was force pushed to empty was that this PR matched.

@a-tarasyuk
Copy link
Contributor Author

a-tarasyuk commented Jul 18, 2023

@jakebailey I've closed it in favor of @Andarist's PR.

@jakebailey
Copy link
Member

jakebailey commented Jul 18, 2023

Which PR is that? #55018 is for a different bug, and I'm not seeing any other enum PRs...

@a-tarasyuk
Copy link
Contributor Author

a-tarasyuk commented Jul 18, 2023

I believe @Andarist will create a new PR soon.

@Andarist Andarist mentioned this pull request Jul 18, 2023
Merged
@Andarist
Copy link
Contributor

Andarist commented Jul 18, 2023

here it is: #55065

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 22, 2025

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Andarist Andarist Andarist left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-tarasyuk @Andarist @jakebailey @typescript-bot