Skip to content

Correctly error on enum member values referring to identifiers shadowing Infinity and NaN#55018

Merged
gabritto merged 1 commit intomicrosoft:mainfrom
Andarist:fix/enum-member-values-using-shadowing-infinity-nan
Aug 2, 2023
Merged

Correctly error on enum member values referring to identifiers shadowing Infinity and NaN#55018
gabritto merged 1 commit intomicrosoft:mainfrom
Andarist:fix/enum-member-values-using-shadowing-infinity-nan

Conversation

@Andarist
Copy link
Contributor

@Andarist Andarist commented Jul 14, 2023

fixes #54981

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 14, 2023
@jakebailey jakebailey mentioned this pull request Jul 18, 2023
Closed
@sandersn sandersn requested review from gabritto and iisaduan July 28, 2023 23:15
@typescript-bot typescript-bot removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 28, 2023
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 28, 2023
@gabritto

This comment was marked as duplicate.

Sign in to view
@gabritto
Copy link
Member

gabritto commented Aug 2, 2023

@typescript-bot run DT
@typescript-bot user test this
@typescript-bot test top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2023 •
edited
Loading

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 5488642. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2023 •
edited
Loading

Heya @gabritto, I've started to run the diff-based user code test suite on this PR at 5488642. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2023 •
edited
Loading

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at 5488642. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2023

@gabritto Here are the results of running the user test suite comparing main and refs/pull/55018/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55018/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2023

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/55018/merge:

Everything looks good!

@gabritto
Copy link
Member

gabritto commented Aug 2, 2023

@typescript-bot run DT

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2023 •
edited
Loading

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 5488642. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2023

Hey @gabritto, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2023

Hey @gabritto, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@gabritto gabritto merged commit 1481750 into microsoft:main Aug 2, 2023
@Andarist Andarist mentioned this pull request Aug 12, 2023
Open
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gabritto gabritto gabritto approved these changes

@iisaduan iisaduan Awaiting requested review from iisaduan

Assignees

@gabritto gabritto

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing error for enum using non-number variables named Infinity/NaN

3 participants

@Andarist @gabritto @typescript-bot