Repository navigation
Fix crash in getAwaitedType - #54107
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
|
TypeScript Bot (@typescript-bot) test this |
|
Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at d7467bd. You can monitor the build here. Update: The results are in! |
|
Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at d7467bd. You can monitor the build here. Update: The results are in! |
|
Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at d7467bd. You can monitor the build here. |
|
Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
|
Well, the user deltas were supposed to show that the crash went away, but apparently the infra is totally skipping the test I added. I'll have to figure out why. |
|
FYI, I did verify that the crash repro'd with the added test before applying the fix. The test I added is the smallest fragment of https://github.com/tc39/test262/blob/main/test/language/expressions/async-generator/named-yield-star-async-next.js necessary to trigger the crash. |
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
There was a problem hiding this comment.
I sent microsoft/typescript-error-deltas#115 which hopefully will get test262 running, but LGTM.
|
Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing Everything looks good! |
|
TypeScript Bot (@typescript-bot) user test this |
|
Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at d7467bd. You can monitor the build here. Update: The results are in! |
|
Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
|
third time's the charm TypeScript Bot (@typescript-bot) user test this |
|
Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at d7467bd. You can monitor the build here. Update: The results are in! |
|
Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
Fixes a crash in
getAwaitedTypedue to a missing diagnostic message.Fixes #53145