feat(7411): Resolve intrinsics elements by JSX namespaced tag names by a-tarasyuk · Pull Request #53799 · microsoft/TypeScript

a-tarasyuk · 2023-04-16T15:41:59Z

tests/cases/compiler/jsxElementType.tsx

DanielRosenwasser · 2023-04-16T22:54:29Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-04-16T22:54:33Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at a4159a6. You can monitor the build here.

typescript-bot · 2023-04-16T22:54:33Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at a4159a6. You can monitor the build here.

typescript-bot · 2023-04-16T22:54:33Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at a4159a6. You can monitor the build here.

typescript-bot · 2023-04-16T22:54:33Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-16T22:54:33Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-16T22:54:33Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-16T22:54:33Z

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-16T22:54:33Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-16T22:56:39Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/152564/artifacts?artifactName=tgz&fileId=17FFE5CAFB801C146941722D97C1B2B099F34620DB40088633D4C655A01E8D2A02&fileName=/typescript-5.1.0-insiders.20230416.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53799-9".;

typescript-bot · 2023-04-16T23:07:28Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/53799/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-04-16T23:07:40Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/53799/merge:

Everything looks good!

typescript-bot · 2023-04-17T00:03:17Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53799

_Metric	_main	₅₃₇₉₉	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{364,558k (± 0.01%)}	_{364,611k (± 0.01%)}	_{+53k (+ 0.01%)}	_364,570k	_364,645k	_{p=0.013 n=6}
_{Parse Time}	_{3.54s (± 0.50%)}	_{3.52s (± 0.43%)}	_~	_3.49s	_3.53s	_{p=0.140 n=6}
_{Bind Time}	_{1.19s (± 0.43%)}	_{1.19s (± 0.63%)}	_~	_1.18s	_1.20s	_{p=0.784 n=6}
_{Check Time}	_{9.51s (± 0.33%)}	_{9.50s (± 0.33%)}	_~	_9.45s	_9.54s	_{p=0.686 n=6}
_{Emit Time}	_{7.92s (± 0.46%)}	_{7.89s (± 0.68%)}	_~	_7.84s	_7.98s	_{p=0.335 n=6}
_{Total Time}	_{22.15s (± 0.25%)}	_{22.09s (± 0.27%)}	_~	_22.03s	_22.18s	_{p=0.196 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,580k (± 0.04%)}	_{192,602k (± 0.03%)}	_~	_192,544k	_192,663k	_{p=0.521 n=6}
_{Parse Time}	_{1.58s (± 1.42%)}	_{1.59s (± 0.40%)}	_~	_1.58s	_1.60s	_{p=0.787 n=6}
_{Bind Time}	_{0.82s (± 0.92%)}	_{0.83s (± 0.62%)}	_~	_0.82s	_0.83s	_{p=0.247 n=6}
_{Check Time}	_{10.22s (± 0.66%)}	_{10.34s (± 0.33%)}	_{+0.12s (+ 1.17%)}	_10.29s	_10.38s	_{p=0.008 n=6}
_{Emit Time}	_{2.97s (± 0.87%)}	_{2.97s (± 1.03%)}	_~	_2.93s	_3.00s	_{p=1.000 n=6}
_{Total Time}	_{15.60s (± 0.40%)}	_{15.72s (± 0.39%)}	_{+0.13s (+ 0.81%)}	_15.64s	_15.80s	_{p=0.013 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,758k (± 0.00%)}	_{345,782k (± 0.02%)}	_~	_345,709k	_345,881k	_{p=0.810 n=6}
_{Parse Time}	_{2.72s (± 0.30%)}	_{2.72s (± 0.64%)}	_~	_2.69s	_2.74s	_{p=1.000 n=6}
_{Bind Time}	_{1.09s (± 0.37%)}	_{1.08s (± 0.70%)}	_{-0.01s (- 0.92%)}	_1.07s	_1.09s	_{p=0.029 n=6}
_{Check Time}	_{7.84s (± 0.32%)}	_{7.80s (± 0.31%)}	_{-0.04s (- 0.53%)}	_7.76s	_7.82s	_{p=0.029 n=6}
_{Emit Time}	_{4.44s (± 0.68%)}	_{4.41s (± 0.88%)}	_~	_4.36s	_4.47s	_{p=0.296 n=6}
_{Total Time}	_{16.08s (± 0.37%)}	_{16.01s (± 0.24%)}	_~	_15.95s	_16.07s	_{p=0.064 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,054k (± 0.01%)}	_{300,066k (± 0.01%)}	_~	_300,048k	_300,095k	_{p=0.689 n=6}
_{Parse Time}	_{2.15s (± 0.42%)}	_{2.15s (± 0.62%)}	_~	_2.14s	_2.17s	_{p=0.666 n=6}
_{Bind Time}	_{1.24s (± 0.79%)}	_{1.25s (± 0.94%)}	_~	_1.23s	_1.26s	_{p=0.314 n=6}
_{Check Time}	_{7.20s (± 0.43%)}	_{7.17s (± 0.24%)}	_{-0.03s (- 0.46%)}	_7.15s	_7.20s	_{p=0.041 n=6}
_{Emit Time}	_{4.34s (± 0.76%)}	_{4.36s (± 0.94%)}	_~	_4.31s	_4.41s	_{p=0.624 n=6}
_{Total Time}	_{14.93s (± 0.26%)}	_{14.92s (± 0.32%)}	_~	_14.85s	_14.97s	_{p=0.936 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,148k (± 0.01%)}	_{481,093k (± 0.01%)}	_~	_481,074k	_481,142k	_{p=0.128 n=6}
_{Parse Time}	_{3.23s (± 0.26%)}	_{3.25s (± 0.36%)}	_{+0.02s (+ 0.52%)}	_3.24s	_3.27s	_{p=0.021 n=6}
_{Bind Time}	_{0.95s (± 0.54%)}	_{0.95s (± 0.79%)}	_~	_0.94s	_0.96s	_{p=0.241 n=6}
_{Check Time}	_{17.81s (± 0.28%)}	_{17.76s (± 0.29%)}	_~	_17.71s	_17.85s	_{p=0.125 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.99s (± 0.25%)}	_{21.96s (± 0.20%)}	_~	_21.92s	_22.04s	_{p=0.421 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{559,360k (± 0.03%)}	_{559,332k (± 0.01%)}	_~	_559,268k	_559,455k	_{p=0.689 n=6}
_{Parse Time}	_{3.98s (± 0.38%)}	_{3.99s (± 0.37%)}	_~	_3.97s	_4.01s	_{p=0.570 n=6}
_{Bind Time}	_{1.75s (± 0.48%)}	_{1.78s (± 0.59%)}	_{+0.03s (+ 1.72%)}	_1.76s	_1.79s	_{p=0.005 n=6}
_{Check Time}	_{3.02s (± 0.57%)}	_{3.04s (± 0.71%)}	_~	_3.01s	_3.07s	_{p=0.064 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.84s (± 0.30%)}	_{8.90s (± 0.17%)}	_{+0.06s (+ 0.66%)}	_8.88s	_8.91s	_{p=0.005 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₇₉₉	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-04-17T00:19:44Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

DanielRosenwasser · 2023-04-17T00:20:18Z

We'll get the tests in a follow-up

typescript-bot · 2023-04-17T01:06:11Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/53799/merge:

Everything looks good!

typescript-bot · 2023-04-17T01:23:02Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/53799/merge:

Something interesting changed - please have a look.

Details

backstage/backstage

⚠️ Note that built had errors ⚠️

Exited unexpectedly with signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

That is a filtered view of the text. To see the raw error text, go to RepoResults4/backstage.backstage.rawError.txt in the artifact folder

Last few requests

{"seq":1372,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/packages/cli/src/commands/fix.ts","projectRootPath":"@PROJECT_ROOT@"}]}}
{"seq":1373,"type":"request","command":"organizeImports","arguments":{"scope":{"type":"file","args":{"file":"@PROJECT_ROOT@/packages/cli/src/commands/fix.ts"}},"skipDestructiveCodeActions":true}}
{"seq":1374,"type":"request","command":"getOutliningSpans","arguments":{"file":"@PROJECT_ROOT@/packages/cli/src/commands/fix.ts"}}
{"seq":1375,"type":"request","command":"navto","arguments":{"searchValue":"a","maxResultCount":256}}

Repro Steps

git clone https://github.com/backstage/backstage --recurse-submodules
In dir backstage, run git reset --hard 54f741d1f0229f0b7026f485d48307a8cb33ba8f
Install packages (exact steps are below, but it might be easier to follow the repo readme)
1. In dir backstage/cypress, run yarn install --no-immutable --mode=skip-build
2. In dir backstage/microsite, run yarn install --no-immutable --mode=skip-build
3. In dir backstage, run yarn install --no-immutable --mode=skip-build
4. In dir backstage/storybook, run yarn install --no-immutable --mode=skip-build
Back in the initial folder, download RepoResults4/backstage.backstage.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./backstage ./backstage.backstage.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

resolve intrinsics elements by jsx namespaced tag names

a4159a6

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 16, 2023

a-tarasyuk mentioned this pull request Apr 16, 2023

[test] Intrinsics with colon no longer type-checked #53784

Closed

DanielRosenwasser reviewed Apr 16, 2023

View reviewed changes

tests/cases/compiler/jsxElementType.tsx Show resolved Hide resolved

DanielRosenwasser marked this pull request as ready for review April 17, 2023 00:19

DanielRosenwasser merged commit 378ffa4 into microsoft:main Apr 17, 2023

a-tarasyuk mentioned this pull request Apr 17, 2023

feat(7411): Add additional test cases #53809

Merged

eps1lon mentioned this pull request Apr 17, 2023

[react] Fix invalid readonly array value in ServerContextJSONArray DefinitelyTyped/DefinitelyTyped#65149

Merged

7 tasks

kylpo mentioned this pull request Apr 22, 2023

Derive props from $ type Chronstruct/display-primitives#1

Open

weswigham mentioned this pull request May 2, 2023

JSX namespace names should not be considered expressions #54104

Merged

Andarist mentioned this pull request Aug 2, 2023

Revert "feat(7411): JSX namespaced attribute syntax not supported" #53791

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

a-tarasyuk commented Apr 16, 2023

Uh oh!

Uh oh!

DanielRosenwasser commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 17, 2023

Uh oh!

typescript-bot commented Apr 17, 2023

Uh oh!

DanielRosenwasser commented Apr 17, 2023

Uh oh!

typescript-bot commented Apr 17, 2023

Uh oh!

typescript-bot commented Apr 17, 2023

backstage/backstage

Last few requests

Repro Steps

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading