Fix emit for ES6 export default class with static initializers. #5137
Merged
Conversation
Member
There was a problem hiding this comment.
languageVersion should never be less than ES6 here since this is in emitClassLikeDeclarationForES6AndHigher
Contributor
Author
There was a problem hiding this comment.
It looks like the previous version may have been a vestige of our class emit before we split the function.
Contributor
|
👍 |
rbuckton
added a commit
that referenced
this pull request
Oct 6, 2015
Fix emit for ES6 export default class with static initializers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5136.