Skip to content

DOM update 2022/09/21#50884

Merged
DanielRosenwasser merged 1 commit intomainfrom
DOM-update-2022-09-21
Sep 21, 2022
Merged

DOM update 2022/09/21#50884
DanielRosenwasser merged 1 commit intomainfrom
DOM-update-2022-09-21

Conversation

@sandersn
Copy link
Member

@sandersn sandersn commented Sep 21, 2022

Fixes #50099

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Sep 21, 2022
@sandersn
Copy link
Member Author

sandersn commented Sep 21, 2022

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022 •
edited
Loading

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at d7bf787. You can monitor the build here.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Sep 21, 2022

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at d7bf787. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at d7bf787. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at d7bf787. You can monitor the build here.

DanielRosenwasser
DanielRosenwasser approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - let's see if the tests find anything and revisit if they do.

@DanielRosenwasser DanielRosenwasser merged commit e2dd508 into main Sep 21, 2022
@DanielRosenwasser DanielRosenwasser deleted the DOM-update-2022-09-21 branch September 21, 2022 17:17
@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/50884/merge:

Something interesting changed - please have a look.

Details

puppeteer

tsconfig.lib.json

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@mrienstra mrienstra mentioned this pull request Oct 22, 2022
Open
This was referenced Jul 9, 2023
Closed
Closed
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@sandersn sandersn

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

lib.d.ts Updates for TypeScript 4.9

3 participants

@sandersn @typescript-bot @DanielRosenwasser