Fixed #5032: tsserver: Format on type broken #5033
Merged
Merged
Conversation
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
we already have similar function getIndentationString. Can it be used instead to avoid code duplication?
Contributor
|
LGTM, assuming that notes about potential code reuse can be addressed |
Contributor
|
@dbaeumer can you also add a fourslash test? |
Contributor
|
@vladima spent some time yesterday trying to write a test for the original issue, and it does not seem possible given the current test infrastructure. the fourslash test behaves similar to VS, as it will not add indentation before calling format. so i would not bother about adding test for the original issue. |
Contributor
|
please add a test for preserving tabs though. |
mhegazy
added a commit
that referenced
this pull request
Oct 14, 2015
Fixed #5032: tsserver: Format on type broken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5032
The Pull request changes the logic of the indentation correction code as follows:
Although this is might replace a larger string then necessary it is easier to understand. And IMO it doesn't really matter if the edit replace n or m characters with m > n.