Skip to content

Do not auto-generate names for anonymous class expressions#4991

Merged
DanielRosenwasser merged 1 commit into
microsoft:masterfrom
MartyIX:patch-1
Sep 28, 2015
Merged

Do not auto-generate names for anonymous class expressions#4991
DanielRosenwasser merged 1 commit into
microsoft:masterfrom
MartyIX:patch-1

Conversation

@MartyIX

@MartyIX MartyIX commented Sep 27, 2015

Copy link
Copy Markdown
Contributor

Proposed fix for #4908

Can anybody confirm if I'm on a right track?

@msftclas

Copy link
Copy Markdown

Hi @MartyIX, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incorrect

@DanielRosenwasser DanielRosenwasser changed the title Update emitter.ts Do not generate a name for class expressions when one was not given Sep 28, 2015
@DanielRosenwasser DanielRosenwasser changed the title Do not generate a name for class expressions when one was not given Do not auto-generate names for anonymous class expressions Sep 28, 2015
Proposed fix for microsoft#4908

Can anybody confirm if I'm on a right track?
@MartyIX

MartyIX commented Sep 28, 2015

Copy link
Copy Markdown
Contributor Author

I have updated the code as @vladima suggested.

@vladima

vladima commented Sep 28, 2015

Copy link
Copy Markdown
Contributor

👍

@DanielRosenwasser

Copy link
Copy Markdown
Member

Thanks for the fix @MartyIX!

DanielRosenwasser added a commit that referenced this pull request Sep 28, 2015
Do not auto-generate names for anonymous class expressions
@DanielRosenwasser DanielRosenwasser merged commit 7d257b2 into microsoft:master Sep 28, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants