Skip to content

Strip literal freshness of contextually typed literals - #49884

Merged
Andrew Branch (andrewbranch) merged 2 commits into
microsoft:mainfrom
andrewbranch:bug/49514
Aug 16, 2022
Merged

Strip literal freshness of contextually typed literals#49884
Andrew Branch (andrewbranch) merged 2 commits into
microsoft:mainfrom
andrewbranch:bug/49514

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented Jul 12, 2022

Copy link
Copy Markdown
Member

I thought this would be way too heavy-handed, but surprisingly the baselines don’t look that bad?

Fixes #49514

@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jul 12, 2022
@andrewbranch

Andrew Branch (andrewbranch) commented Jul 12, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the parallelized Definitely Typed test suite on this PR at b9709fb. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at b9709fb. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the abridged perf test suite on this PR at b9709fb. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the diff-based user code test suite on this PR at b9709fb. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the user tests run you requested are in!

Here they are:

Comparison Report - main..refs/pull/49884/merge

puppeteer

4 of 4 projects failed to build with the old tsc

/mnt/ts_downloads/puppeteer/scripts/tsconfig.json

  • error TS2322: Type '"latest"' is not assignable to type '"1011831"'.
    • /mnt/ts_downloads/puppeteer/src/initializePuppeteer.ts(38,5)

/mnt/ts_downloads/puppeteer/tsconfig.json

  • error TS2322: Type '"latest"' is not assignable to type '"1011831"'.
    • /mnt/ts_downloads/puppeteer/src/initializePuppeteer.ts(38,5)

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..49884
Metric main 49884 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 359,641k (± 0.02%) 359,717k (± 0.03%) +77k (+ 0.02%) 359,560k 359,880k
Parse Time 2.08s (± 0.39%) 2.09s (± 0.56%) +0.01s (+ 0.53%) 2.07s 2.13s
Bind Time 0.90s (± 0.96%) 0.90s (± 0.67%) -0.00s (- 0.33%) 0.89s 0.91s
Check Time 5.98s (± 0.33%) 5.98s (± 0.42%) -0.01s (- 0.10%) 5.91s 6.02s
Emit Time 6.10s (± 0.49%) 6.13s (± 0.57%) +0.03s (+ 0.44%) 6.04s 6.22s
Total Time 15.06s (± 0.21%) 15.09s (± 0.33%) +0.03s (+ 0.18%) 15.00s 15.25s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,666k (± 0.03%) 206,608k (± 0.04%) -58k (- 0.03%) 206,447k 206,891k
Parse Time 0.83s (± 0.48%) 0.84s (± 0.80%) +0.01s (+ 0.72%) 0.82s 0.85s
Bind Time 0.53s (± 2.16%) 0.53s (± 1.70%) -0.00s (- 0.57%) 0.51s 0.55s
Check Time 7.10s (± 0.37%) 7.12s (± 0.68%) +0.02s (+ 0.28%) 7.03s 7.25s
Emit Time 2.49s (± 0.87%) 2.51s (± 0.87%) +0.02s (+ 0.68%) 2.45s 2.55s
Total Time 10.95s (± 0.36%) 11.00s (± 0.53%) +0.04s (+ 0.39%) 10.89s 11.14s
Monaco - node (v10.16.3, x64)
Memory used 344,000k (± 0.01%) 344,002k (± 0.02%) +2k (+ 0.00%) 343,896k 344,209k
Parse Time 1.60s (± 0.23%) 1.60s (± 0.76%) 0.00s ( 0.00%) 1.58s 1.63s
Bind Time 0.77s (± 0.89%) 0.77s (± 1.14%) +0.00s (+ 0.52%) 0.76s 0.80s
Check Time 5.95s (± 0.38%) 5.98s (± 0.45%) +0.03s (+ 0.57%) 5.90s 6.02s
Emit Time 3.25s (± 0.65%) 3.26s (± 0.54%) +0.01s (+ 0.15%) 3.22s 3.31s
Total Time 11.56s (± 0.31%) 11.60s (± 0.33%) +0.04s (+ 0.37%) 11.49s 11.65s
TFS - node (v10.16.3, x64)
Memory used 305,175k (± 0.03%) 305,131k (± 0.01%) -45k (- 0.01%) 305,068k 305,208k
Parse Time 1.28s (± 0.47%) 1.28s (± 0.61%) +0.00s (+ 0.39%) 1.27s 1.31s
Bind Time 0.72s (± 0.82%) 0.72s (± 0.80%) -0.00s (- 0.55%) 0.71s 0.73s
Check Time 5.40s (± 0.50%) 5.41s (± 0.60%) +0.01s (+ 0.19%) 5.33s 5.46s
Emit Time 3.43s (± 1.23%) 3.45s (± 1.17%) +0.03s (+ 0.79%) 3.37s 3.53s
Total Time 10.82s (± 0.51%) 10.87s (± 0.63%) +0.04s (+ 0.37%) 10.74s 10.99s
material-ui - node (v10.16.3, x64)
Memory used 469,433k (± 0.01%) 469,490k (± 0.01%) +57k (+ 0.01%) 469,424k 469,625k
Parse Time 1.83s (± 0.74%) 1.82s (± 0.45%) -0.00s (- 0.27%) 1.81s 1.84s
Bind Time 0.68s (± 2.01%) 0.69s (± 2.13%) +0.01s (+ 0.73%) 0.66s 0.71s
Check Time 14.54s (± 0.58%) 14.47s (± 0.72%) -0.08s (- 0.53%) 14.29s 14.82s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.06s (± 0.47%) 16.98s (± 0.61%) -0.07s (- 0.44%) 16.80s 17.32s
xstate - node (v10.16.3, x64)
Memory used 578,008k (± 0.01%) 578,013k (± 0.01%) +5k (+ 0.00%) 577,876k 578,194k
Parse Time 2.59s (± 0.27%) 2.59s (± 0.25%) +0.00s (+ 0.04%) 2.58s 2.60s
Bind Time 1.03s (± 1.07%) 1.02s (± 1.08%) -0.01s (- 0.68%) 1.00s 1.06s
Check Time 1.56s (± 0.44%) 1.56s (± 0.67%) +0.00s (+ 0.13%) 1.53s 1.58s
Emit Time 0.07s (± 3.14%) 0.07s (± 0.00%) -0.00s (- 1.41%) 0.07s 0.07s
Total Time 5.24s (± 0.32%) 5.24s (± 0.26%) -0.00s (- 0.02%) 5.20s 5.26s
Angular - node (v12.1.0, x64)
Memory used 337,263k (± 0.02%) 337,272k (± 0.02%) +9k (+ 0.00%) 337,150k 337,377k
Parse Time 2.10s (± 0.73%) 2.09s (± 0.55%) -0.00s (- 0.05%) 2.06s 2.12s
Bind Time 0.86s (± 0.69%) 0.86s (± 0.43%) -0.01s (- 1.04%) 0.85s 0.86s
Check Time 5.81s (± 0.61%) 5.79s (± 0.39%) -0.02s (- 0.38%) 5.73s 5.85s
Emit Time 6.36s (± 0.44%) 6.36s (± 0.35%) -0.00s (- 0.08%) 6.28s 6.40s
Total Time 15.13s (± 0.41%) 15.10s (± 0.17%) -0.03s (- 0.19%) 15.05s 15.18s
Compiler-Unions - node (v12.1.0, x64)
Memory used 194,211k (± 0.10%) 194,099k (± 0.10%) -112k (- 0.06%) 193,618k 194,347k
Parse Time 0.82s (± 0.91%) 0.82s (± 0.81%) -0.00s (- 0.36%) 0.81s 0.84s
Bind Time 0.54s (± 0.91%) 0.55s (± 1.21%) +0.01s (+ 0.92%) 0.54s 0.56s
Check Time 6.68s (± 0.37%) 6.69s (± 0.47%) +0.01s (+ 0.15%) 6.65s 6.79s
Emit Time 2.53s (± 1.46%) 2.53s (± 1.20%) -0.00s (- 0.20%) 2.50s 2.63s
Total Time 10.58s (± 0.49%) 10.59s (± 0.35%) +0.00s (+ 0.03%) 10.51s 10.66s
Monaco - node (v12.1.0, x64)
Memory used 326,994k (± 0.02%) 326,925k (± 0.03%) -70k (- 0.02%) 326,694k 327,091k
Parse Time 1.57s (± 1.00%) 1.57s (± 0.65%) +0.01s (+ 0.32%) 1.55s 1.59s
Bind Time 0.76s (± 0.98%) 0.76s (± 1.30%) -0.00s (- 0.26%) 0.74s 0.79s
Check Time 5.80s (± 0.29%) 5.81s (± 0.29%) +0.01s (+ 0.17%) 5.78s 5.85s
Emit Time 3.32s (± 0.99%) 3.30s (± 0.79%) -0.02s (- 0.54%) 3.26s 3.37s
Total Time 11.44s (± 0.34%) 11.43s (± 0.41%) -0.00s (- 0.04%) 11.38s 11.56s
TFS - node (v12.1.0, x64)
Memory used 289,689k (± 0.06%) 289,771k (± 0.02%) +82k (+ 0.03%) 289,628k 289,847k
Parse Time 1.29s (± 1.00%) 1.29s (± 0.56%) -0.00s (- 0.23%) 1.28s 1.31s
Bind Time 0.72s (± 1.05%) 0.72s (± 0.55%) -0.00s (- 0.55%) 0.71s 0.73s
Check Time 5.34s (± 0.36%) 5.35s (± 0.64%) +0.01s (+ 0.22%) 5.28s 5.43s
Emit Time 3.54s (± 1.29%) 3.54s (± 1.24%) -0.00s (- 0.08%) 3.44s 3.64s
Total Time 10.90s (± 0.52%) 10.90s (± 0.50%) +0.00s (+ 0.02%) 10.80s 11.02s
material-ui - node (v12.1.0, x64)
Memory used 448,530k (± 0.01%) 448,600k (± 0.02%) +70k (+ 0.02%) 448,475k 448,820k
Parse Time 1.83s (± 0.26%) 1.82s (± 0.27%) -0.00s (- 0.11%) 1.81s 1.83s
Bind Time 0.68s (± 0.59%) 0.68s (± 0.91%) +0.00s (+ 0.29%) 0.67s 0.70s
Check Time 13.04s (± 0.71%) 13.06s (± 0.45%) +0.02s (+ 0.13%) 12.94s 13.17s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.55s (± 0.62%) 15.57s (± 0.37%) +0.02s (+ 0.14%) 15.46s 15.66s
xstate - node (v12.1.0, x64)
Memory used 546,688k (± 1.32%) 543,492k (± 0.02%) -3,196k (- 0.58%) 543,274k 543,626k
Parse Time 2.55s (± 0.29%) 2.55s (± 0.40%) -0.00s (- 0.08%) 2.53s 2.57s
Bind Time 1.03s (± 1.46%) 1.02s (± 1.42%) -0.01s (- 0.58%) 1.00s 1.07s
Check Time 1.49s (± 0.72%) 1.50s (± 0.44%) +0.01s (+ 0.60%) 1.49s 1.51s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.14s (± 0.47%) 5.14s (± 0.29%) -0.00s (- 0.02%) 5.12s 5.19s
Angular - node (v14.15.1, x64)
Memory used 335,420k (± 0.01%) 335,436k (± 0.01%) +15k (+ 0.00%) 335,361k 335,543k
Parse Time 2.05s (± 0.67%) 2.07s (± 0.64%) +0.01s (+ 0.58%) 2.05s 2.11s
Bind Time 0.90s (± 0.41%) 0.90s (± 0.64%) +0.00s (+ 0.56%) 0.89s 0.92s
Check Time 5.78s (± 0.42%) 5.77s (± 0.43%) -0.01s (- 0.19%) 5.73s 5.85s
Emit Time 6.40s (± 0.82%) 6.36s (± 1.03%) -0.04s (- 0.55%) 6.27s 6.58s
Total Time 15.13s (± 0.40%) 15.10s (± 0.61%) -0.03s (- 0.22%) 14.95s 15.34s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,159k (± 0.38%) 193,180k (± 0.38%) +21k (+ 0.01%) 192,801k 196,146k
Parse Time 0.85s (± 0.61%) 0.84s (± 0.43%) -0.01s (- 0.59%) 0.84s 0.85s
Bind Time 0.57s (± 1.44%) 0.57s (± 1.43%) -0.00s (- 0.35%) 0.56s 0.60s
Check Time 6.70s (± 0.50%) 6.70s (± 0.52%) +0.00s (+ 0.03%) 6.62s 6.77s
Emit Time 2.49s (± 0.89%) 2.49s (± 1.00%) -0.00s (- 0.08%) 2.44s 2.56s
Total Time 10.61s (± 0.40%) 10.60s (± 0.51%) -0.01s (- 0.08%) 10.47s 10.68s
Monaco - node (v14.15.1, x64)
Memory used 325,715k (± 0.01%) 325,715k (± 0.00%) 0k ( 0.00%) 325,689k 325,734k
Parse Time 1.57s (± 0.41%) 1.58s (± 0.56%) +0.01s (+ 0.51%) 1.56s 1.60s
Bind Time 0.80s (± 1.56%) 0.79s (± 0.86%) -0.00s (- 0.25%) 0.79s 0.82s
Check Time 5.71s (± 0.71%) 5.68s (± 0.33%) -0.02s (- 0.40%) 5.65s 5.74s
Emit Time 3.35s (± 0.56%) 3.35s (± 0.58%) +0.00s (+ 0.09%) 3.31s 3.40s
Total Time 11.43s (± 0.44%) 11.41s (± 0.26%) -0.02s (- 0.16%) 11.33s 11.45s
TFS - node (v14.15.1, x64)
Memory used 288,785k (± 0.01%) 288,807k (± 0.01%) +22k (+ 0.01%) 288,765k 288,848k
Parse Time 1.32s (± 1.55%) 1.33s (± 1.50%) +0.01s (+ 0.76%) 1.29s 1.38s
Bind Time 0.78s (± 4.53%) 0.77s (± 4.21%) -0.01s (- 0.90%) 0.73s 0.86s
Check Time 5.35s (± 0.47%) 5.33s (± 0.42%) -0.02s (- 0.43%) 5.28s 5.37s
Emit Time 3.54s (± 1.92%) 3.60s (± 2.02%) +0.06s (+ 1.69%) 3.46s 3.73s
Total Time 10.99s (± 0.59%) 11.03s (± 0.81%) +0.04s (+ 0.36%) 10.86s 11.23s
material-ui - node (v14.15.1, x64)
Memory used 446,539k (± 0.06%) 446,524k (± 0.06%) -15k (- 0.00%) 445,412k 446,729k
Parse Time 1.87s (± 0.33%) 1.87s (± 0.28%) +0.00s (+ 0.11%) 1.86s 1.88s
Bind Time 0.72s (± 0.68%) 0.72s (± 1.05%) +0.00s (+ 0.00%) 0.71s 0.74s
Check Time 13.08s (± 0.32%) 13.16s (± 0.75%) +0.08s (+ 0.62%) 13.04s 13.46s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.68s (± 0.27%) 15.76s (± 0.65%) +0.09s (+ 0.55%) 15.63s 16.06s
xstate - node (v14.15.1, x64)
Memory used 541,283k (± 0.00%) 541,267k (± 0.00%) -16k (- 0.00%) 541,237k 541,304k
Parse Time 2.60s (± 0.37%) 2.59s (± 0.26%) -0.01s (- 0.54%) 2.57s 2.60s
Bind Time 1.15s (± 1.59%) 1.14s (± 1.25%) -0.00s (- 0.44%) 1.10s 1.17s
Check Time 1.54s (± 0.58%) 1.55s (± 0.36%) +0.00s (+ 0.19%) 1.54s 1.56s
Emit Time 0.07s (± 4.92%) 0.07s (± 4.13%) -0.00s (- 2.70%) 0.07s 0.08s
Total Time 5.38s (± 0.52%) 5.35s (± 0.30%) -0.02s (- 0.39%) 5.33s 5.38s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49884 10
Baseline main 10

TSServer

Comparison Report - main..49884
Metric main 49884 Delta Best Worst
xstateTSServer - node (v10.16.3, x64)
Initial load time 2,158.00ms (± 0.38%) 2,159.90ms (± 0.38%) +1.90ms (+ 0.09%) 2,139.00ms 2,177.00ms
Geterr time 758.60ms (± 0.52%) 759.90ms (± 0.47%) +1.30ms (+ 0.17%) 753.00ms 769.00ms
References time 95.20ms (± 0.91%) 95.90ms (± 1.12%) +0.70ms (+ 0.74%) 93.00ms 98.00ms
Navto time 248.90ms (± 0.60%) 250.20ms (± 1.08%) +1.30ms (+ 0.52%) 245.00ms 259.00ms
Navto count 256.00 (± 0.00%) 256.00 (± 0.00%) 0.00 ( 0.00%) 256.00 256.00
Completions time 242.60ms (± 0.71%) 244.00ms (± 1.32%) +1.40ms (+ 0.58%) 236.00ms 248.00ms
Completions count 3,205.00 (± 0.00%) 3,205.00 (± 0.00%) 0.00 ( 0.00%) 3,205.00 3,205.00
xstateTSServer - node (v12.1.0, x64)
Initial load time 2,088.90ms (± 0.66%) 2,078.90ms (± 0.44%) -10.00ms (- 0.48%) 2,063.00ms 2,106.00ms
Geterr time 744.00ms (± 0.40%) 744.80ms (± 0.63%) +0.80ms (+ 0.11%) 734.00ms 758.00ms
References time 67.00ms (± 2.58%) 67.00ms (± 1.21%) 0.00ms ( 0.00%) 64.00ms 68.00ms
Navto time 241.70ms (± 0.36%) 239.40ms (± 1.27%) -2.30ms (- 0.95%) 228.00ms 244.00ms
Navto count 256.00 (± 0.00%) 256.00 (± 0.00%) 0.00 ( 0.00%) 256.00 256.00
Completions time 239.70ms (± 1.06%) 240.30ms (± 1.01%) +0.60ms (+ 0.25%) 232.00ms 245.00ms
Completions count 3,205.00 (± 0.00%) 3,205.00 (± 0.00%) 0.00 ( 0.00%) 3,205.00 3,205.00
xstateTSServer - node (v14.15.1, x64)
Initial load time 2,215.50ms (± 0.30%) 2,219.80ms (± 0.35%) +4.30ms (+ 0.19%) 2,200.00ms 2,237.00ms
Geterr time 765.30ms (± 0.36%) 771.70ms (± 0.32%) +6.40ms (+ 0.84%) 768.00ms 777.00ms
References time 65.30ms (± 2.22%) 65.80ms (± 2.13%) +0.50ms (+ 0.77%) 63.00ms 68.00ms
Navto time 250.90ms (± 0.45%) 251.50ms (± 0.87%) +0.60ms (+ 0.24%) 248.00ms 258.00ms
Navto count 256.00 (± 0.00%) 256.00 (± 0.00%) 0.00 ( 0.00%) 256.00 256.00
Completions time 241.30ms (± 0.39%) 241.70ms (± 0.41%) +0.40ms (+ 0.17%) 240.00ms 245.00ms
Completions count 3,205.00 (± 0.00%) 3,205.00 (± 0.00%) 0.00 ( 0.00%) 3,205.00 3,205.00
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • xstateTSServer - node (v10.16.3, x64)
  • xstateTSServer - node (v12.1.0, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49884 10
Baseline main 10

Developer Information:

Download Benchmark

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49884

Metric main 49884 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 335,420k (± 0.01%) 335,448k (± 0.01%) +28k (+ 0.01%) 335,321k 335,516k
Parse Time 2.05s (± 0.67%) 2.07s (± 0.62%) +0.02s (+ 0.73%) 2.05s 2.10s
Bind Time 0.90s (± 0.41%) 0.89s (± 0.56%) -0.00s (- 0.00%) 0.89s 0.91s
Check Time 5.78s (± 0.42%) 5.77s (± 0.45%) -0.01s (- 0.14%) 5.73s 5.85s
Emit Time 6.40s (± 0.82%) 6.39s (± 0.25%) -0.01s (- 0.11%) 6.36s 6.43s
Total Time 15.13s (± 0.40%) 15.13s (± 0.23%) -0.00s (- 0.03%) 15.05s 15.21s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,159k (± 0.38%) 192,745k (± 0.13%) -414k (- 0.21%) 191,768k 192,934k
Parse Time 0.85s (± 0.61%) 0.85s (± 0.78%) +0.00s (+ 0.12%) 0.83s 0.86s
Bind Time 0.57s (± 1.44%) 0.57s (± 1.04%) -0.00s (- 0.17%) 0.56s 0.59s
Check Time 6.70s (± 0.50%) 6.72s (± 0.45%) +0.03s (+ 0.39%) 6.65s 6.78s
Emit Time 2.49s (± 0.89%) 2.50s (± 1.35%) +0.01s (+ 0.36%) 2.45s 2.62s
Total Time 10.61s (± 0.40%) 10.65s (± 0.44%) +0.04s (+ 0.36%) 10.55s 10.74s
Monaco - node (v14.15.1, x64)
Memory used 325,715k (± 0.01%) 325,732k (± 0.01%) +18k (+ 0.01%) 325,698k 325,765k
Parse Time 1.57s (± 0.41%) 1.58s (± 0.79%) +0.01s (+ 0.76%) 1.56s 1.61s
Bind Time 0.80s (± 1.56%) 0.79s (± 0.62%) -0.00s (- 0.38%) 0.78s 0.80s
Check Time 5.71s (± 0.71%) 5.71s (± 0.53%) +0.01s (+ 0.14%) 5.66s 5.77s
Emit Time 3.35s (± 0.56%) 3.37s (± 0.81%) +0.02s (+ 0.63%) 3.30s 3.45s
Total Time 11.43s (± 0.44%) 11.46s (± 0.48%) +0.03s (+ 0.28%) 11.31s 11.59s
TFS - node (v14.15.1, x64)
Memory used 288,785k (± 0.01%) 288,799k (± 0.01%) +13k (+ 0.00%) 288,715k 288,847k
Parse Time 1.32s (± 1.55%) 1.32s (± 1.28%) -0.00s (- 0.08%) 1.29s 1.36s
Bind Time 0.78s (± 4.53%) 0.78s (± 4.69%) +0.01s (+ 0.64%) 0.74s 0.86s
Check Time 5.35s (± 0.47%) 5.34s (± 0.48%) -0.01s (- 0.15%) 5.29s 5.41s
Emit Time 3.54s (± 1.92%) 3.58s (± 2.12%) +0.04s (+ 1.02%) 3.42s 3.71s
Total Time 10.99s (± 0.59%) 11.02s (± 0.79%) +0.03s (+ 0.27%) 10.89s 11.28s
material-ui - node (v14.15.1, x64)
Memory used 446,539k (± 0.06%) 446,633k (± 0.00%) +94k (+ 0.02%) 446,599k 446,672k
Parse Time 1.87s (± 0.33%) 1.87s (± 0.43%) -0.00s (- 0.05%) 1.85s 1.89s
Bind Time 0.72s (± 0.68%) 0.73s (± 1.24%) +0.01s (+ 0.97%) 0.71s 0.75s
Check Time 13.08s (± 0.32%) 13.19s (± 0.38%) +0.10s (+ 0.79%) 13.08s 13.30s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.68s (± 0.27%) 15.79s (± 0.38%) +0.11s (+ 0.70%) 15.64s 15.91s
xstate - node (v14.15.1, x64)
Memory used 541,283k (± 0.00%) 541,255k (± 0.00%) -28k (- 0.01%) 541,199k 541,286k
Parse Time 2.60s (± 0.37%) 2.60s (± 0.38%) +0.00s (+ 0.04%) 2.58s 2.62s
Bind Time 1.15s (± 1.59%) 1.15s (± 1.29%) +0.00s (+ 0.35%) 1.12s 1.18s
Check Time 1.54s (± 0.58%) 1.54s (± 0.58%) -0.00s (- 0.06%) 1.53s 1.57s
Emit Time 0.07s (± 4.92%) 0.07s (± 4.95%) +0.00s (+ 1.35%) 0.07s 0.08s
Total Time 5.38s (± 0.52%) 5.38s (± 0.37%) +0.00s (+ 0.09%) 5.34s 5.42s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49884 10
Baseline main 10

Developer Information:

Download Benchmark

ahejlsberg
Anders Hejlsberg (ahejlsberg) approved these changes Jul 13, 2022
View reviewed changes

@ahejlsberg Anders Hejlsberg (ahejlsberg) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Definitely seems wrong to infer fresh literal types for array literal elements and object literal properties.

@andrewbranch

Andrew Branch (andrewbranch) commented Jul 13, 2022

Copy link
Copy Markdown
Member Author

The puppeteer failure shows that Object.freeze is a fairly easy way to observe this change. I think the new behavior makes more sense, but it is certainly a breaking change:

const PUPPETEER_REVISIONS = Object.freeze({
  chromium: '1011831',
  firefox: 'latest',
});

let preferredRevision = PUPPETEER_REVISIONS.chromium; // Previously string, now "1011931"
preferredRevision = PUPPETEER_REVISIONS.firefox;      // Previously ok, now error

@andrewbranch
Andrew Branch (andrewbranch) marked this pull request as ready for review July 13, 2022 16:32
@andrewbranch Andrew Branch (andrewbranch) added the Breaking Change Would introduce errors in existing code label Jul 13, 2022
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jul 13, 2022

Copy link
Copy Markdown
Member

Ah yes, I see there's some cleverness in the Object.freeze overloads to preserve literal types for properties. Still, I don't like capturing fresh literal types for properties and the new behavior makes more sense to me, even if it is a breaking change.

@AlCalzone

AlCalzone commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

Would it be possible to get a test build with this? I'd like to test if I can get rid of basically a ton of as const assertions with this.

@andrewbranch

Andrew Branch (andrewbranch) commented Jul 18, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) pack this

@AlCalzone

AlCalzone commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

Doesn't look like that worked Andrew Branch (@andrewbranch)

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Jul 20, 2022

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) pack this

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the tarball bundle task on this PR at d2ff6b8. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Ryan Cavanaugh (@RyanCavanaugh), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/130126/artifacts?artifactName=tgz&fileId=FCC692AA88BA75F42C969294B37BDCD789FD86540102485B4D25AD907680EBAA02&fileName=/typescript-4.8.0-insiders.20220720.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.8.0-pr-49884-15".;

@AlCalzone

AlCalzone commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Thanks! Doesn't seem to affect my use case though.

@sandersn

Nathan Shively-Sanders (sandersn) commented Jul 27, 2022

Copy link
Copy Markdown
Member

Andrew Branch (@andrewbranch) I assume this is 4.9-bound, right?

@andrewbranch

Andrew Branch (andrewbranch) commented Jul 28, 2022

Copy link
Copy Markdown
Member Author

Nathan Shively-Sanders (@sandersn) yep.

@andrewbranch
Andrew Branch (andrewbranch) merged commit 64ee1e8 into microsoft:main Aug 16, 2022
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Aug 16, 2022
Merged
@david10sing

d.ts (david10sing) commented Jan 9, 2023 •
edited
Loading

Copy link
Copy Markdown

The puppeteer failure shows that Object.freeze is a fairly easy way to observe this change. I think the new behavior makes more sense, but it is certainly a breaking change:

const PUPPETEER_REVISIONS = Object.freeze({
  chromium: '1011831',
  firefox: 'latest',
});

let preferredRevision = PUPPETEER_REVISIONS.chromium; // Previously string, now "1011931"
preferredRevision = PUPPETEER_REVISIONS.firefox;      // Previously ok, now error

Andrew Branch (@andrewbranch)

Is there a proposed workaround for this? I am having the same issue here. #52125

I think this new behaviour goes against JavaScript's syntax. In the example you gave above, I think it is fine to do the re-assignment but now we have TypeScript telling us that it is an error.

In my use case, creating an array from an immutable object and running includes on that array should not throw a type error.

With this breaking change, does this mean that to get around this, we need to do [] as string[]?

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ahejlsberg Anders Hejlsberg (ahejlsberg) ahejlsberg approved these changes

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

Author: Team Breaking Change Would introduce errors in existing code For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type Predicate Function Inconsistent Across Identical Inferred Types

7 participants

@andrewbranch @typescript-bot @ahejlsberg @AlCalzone @RyanCavanaugh @sandersn @david10sing