Skip to content

Put AMD dependency list inline with define call in UMD modules#4980

Merged
vladima merged 1 commit into
microsoft:masterfrom
csnover:fix-4952
Sep 28, 2015
Merged

Put AMD dependency list inline with define call in UMD modules#4980
vladima merged 1 commit into
microsoft:masterfrom
csnover:fix-4952

Conversation

@csnover

@csnover csnover commented Sep 25, 2015

Copy link
Copy Markdown
Contributor

Fixes #4952.

@mhegazy

mhegazy commented Sep 26, 2015

Copy link
Copy Markdown
Contributor

👍

@mhegazy

mhegazy commented Sep 26, 2015

Copy link
Copy Markdown
Contributor

@xi can you give this a try?

@vladima

vladima commented Sep 26, 2015

Copy link
Copy Markdown
Contributor

👍

@xi

xi commented Sep 28, 2015

Copy link
Copy Markdown

This indeed works with my project. Great!

vladima added a commit that referenced this pull request Sep 28, 2015
Put AMD dependency list inline with define call in UMD modules
@vladima vladima merged commit b046c3a into microsoft:master Sep 28, 2015
@vladima

vladima commented Sep 28, 2015

Copy link
Copy Markdown
Contributor

thanks @csnover !

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants