Move hasOwn from Object instance to Object constructor - #48207
Merged
Ryan Cavanaugh (RyanCavanaugh) merged 1 commit intoMar 10, 2022
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Member
|
🤦♂️ In checker.ts we have some logic for reporting whether or not the |
Member
|
Nah should be fine.
|
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Mar 10, 2022
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Member
There was a problem hiding this comment.
Should we cherry-pick to release-4.6 and release a patch?
Member
Author
|
I think so, this will not be the first report of it |
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-4.6 |
Contributor
|
Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the task to cherry-pick this into |
Contributor
|
Hey Ryan Cavanaugh (@RyanCavanaugh), I've opened #48213 for you. |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 10, 2022
Component commits: d1b063e Move `hasOwn` from Object instance to Object constructor Fixes microsoft#48206
Daniel Rosenwasser (DanielRosenwasser)
pushed a commit
that referenced
this pull request
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48206