Only suggest @param codefixes in TS - #47959
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoFeb 18, 2022
Merged
Conversation
Previously, there were 2 JS errors that were issued as suggestions in TS files. But there was no codefix for these errors, and the errors were incorrect in TS. This PR only issues the JS-specific errors on JS files.
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Nathan Shively-Sanders (sandersn)
changed the title
@param codefixes in TS
Nathan Shively-Sanders (sandersn)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
February 18, 2022 22:05
Member
Author
|
Oleksandr Tarasiuk (@a-tarasyuk) I can't add you as a reviewer, but you're probably interested in this. |
Contributor
Member
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-4.6 |
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into |
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Feb 18, 2022
Contributor
|
Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #47962 for you. |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Feb 18, 2022
Component commits: 465042e Only issue @PARAM suggestions with codefixes in TS Previously, there were 2 JS errors that were issued as suggestions in TS files. But there was no codefix for these errors, and the errors were incorrect in TS. This PR only issues the JS-specific errors on JS files. 4056b38 Minimise test 4fb10f1 Merge branch 'main' into only-suggest-param-codefixes-in-ts 72499ac Merge branch 'main' into only-suggest-param-codefixes-in-ts
Nathan Shively-Sanders (sandersn)
deleted the
only-suggest-param-codefixes-in-ts
branch
February 18, 2022 23:58
Daniel Rosenwasser (DanielRosenwasser)
pushed a commit
that referenced
this pull request
Feb 19, 2022
Component commits: 465042e Only issue @PARAM suggestions with codefixes in TS Previously, there were 2 JS errors that were issued as suggestions in TS files. But there was no codefix for these errors, and the errors were incorrect in TS. This PR only issues the JS-specific errors on JS files. 4056b38 Minimise test 4fb10f1 Merge branch 'main' into only-suggest-param-codefixes-in-ts 72499ac Merge branch 'main' into only-suggest-param-codefixes-in-ts Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there were 2 JS errors that were issued as suggestions in TS files. But there was no codefix for these errors, and the errors were incorrect in TS.
This PR only issues the JS-specific errors on JS files.
Fixes bug discovered by Daniel Rosenwasser (@DanielRosenwasser) and Titian Cernicova-Dragomir (@dragomirtitian)
Fixes #47949