Check if imported file is a proper external module for imported node typings#4738
Check if imported file is a proper external module for imported node typings#4738
Conversation
src/compiler/types.ts
Outdated
There was a problem hiding this comment.
i think this should be declarative. i.e. the name tells you what it is rather than telling you how it should be have. so something like
isExternalLibrary, or isExternalLibraryImport
|
also looks like you have build error. |
|
👍 |
Check if imported file is a proper external module for imported node typings
|
pinging @basarat and @jbrantly: FYI, this PR has changed the signature of |
|
Thanks for the heads up |
|
@vladima can you comment this issue in the API breaking changes page |
There was a problem hiding this comment.
It seems like this would be a good case of having the "Please contact the package author to update the package definition." message.
There was a problem hiding this comment.
fair point, will update the message. Thanks!
4 participants
No description provided.