Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
sandersn
requested review from
DanielRosenwasser,
amcasey and
andrewbranch
and removed request for
andrewbranch
andrewbranch
reviewed
Dec 8, 2021
| Diagnostics.A_set_accessor_must_have_exactly_one_parameter.code, | ||
| Diagnostics.An_export_declaration_can_only_be_used_in_a_module.code, | ||
| Diagnostics.An_export_declaration_cannot_have_modifiers.code, | ||
| Diagnostics.An_import_declaration_can_only_be_used_in_a_namespace_or_module.code, |
Member
There was a problem hiding this comment.
This wording seems off, and we could probably improve it and make it friendlier to JS (which doesn’t have namespaces) at the same time. I think it means that an import declaration has to be at the top level of the file.
Member
Author
There was a problem hiding this comment.
That's how it's implemented, yes. Well, it also checks for parents like namespace N or declare module "m", neither of which apply to JS.
I'll open a bug proposing to split the current implementation into 2 messages and improve the wording.
andrewbranch
approved these changes
Dec 9, 2021
amcasey
reviewed
Dec 9, 2021
| Diagnostics.Argument_of_dynamic_import_cannot_be_spread_element.code, | ||
| Diagnostics.Cannot_assign_to_private_method_0_Private_methods_are_not_writable.code, | ||
| Diagnostics.Cannot_redeclare_identifier_0_in_catch_clause.code, | ||
| Diagnostics.Catch_clause_variable_cannot_have_an_initializer.code, |
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
These are the last ones that I know of. They come from calls to `grammarErrorOnFirstToken`. Fixes part of microsoft#45349 Follow-up to microsoft#47067
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the last ones that I know of. They come from calls to
grammarErrorOnFirstToken.Fixes part of #45349
Follow-up to #47067