Skip to content

do not emit '=' in jsx attribute if initializer is missing#4703

Merged
vladima merged 1 commit into
masterfrom
jsxEmitAttribiteWithInitializer
Sep 10, 2015
Merged

do not emit '=' in jsx attribute if initializer is missing#4703
vladima merged 1 commit into
masterfrom
jsxEmitAttribiteWithInitializer

Conversation

@vladima

@vladima vladima commented Sep 9, 2015

Copy link
Copy Markdown
Contributor

fixes #4645

@DanielRosenwasser

Copy link
Copy Markdown
Member

👍 @mhegazy does this need to go into 1.6?

@mhegazy

mhegazy commented Sep 10, 2015

Copy link
Copy Markdown
Contributor

👍

@mhegazy

mhegazy commented Sep 10, 2015

Copy link
Copy Markdown
Contributor

fix looks safe. let's port it to 1.6

vladima added a commit that referenced this pull request Sep 10, 2015
do not emit '=' in jsx attribute if initializer is missing
@vladima vladima merged commit 6a77400 into master Sep 10, 2015
@vladima vladima deleted the jsxEmitAttribiteWithInitializer branch September 10, 2015 18:37
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid Jsx emit when jsx=preserve is specified

4 participants