Closed
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
Collaborator
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
elibarzilay
force-pushed
the
typeformer
branch
2 times, most recently
from
3b3f8cd to
8be16d9
Compare
elibarzilay
force-pushed
the
typeformer
branch
from
8be16d9 to
32c2e60
Compare
elibarzilay
force-pushed
the
typeformer
branch
from
9910ffb to
d6c537e
Compare
Member
|
@ahejlsberg was wondering why in some places things like |
(Also improve the generated comment at the top.)
This will change (should be done for all packages, and probably better), but added now to make running the tests easier for others.
elibarzilay
force-pushed
the
typeformer
branch
from
696c616 to
23ce87d
Compare
Member
|
Closing this; I'm now staging this work as a PR stack here: jakebailey#1 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be rebased often, and the commit pointers below will be updated. Generated by this script.
The work is tracked at #46744.
Best viewed by looking at each commit separately:
prepares for the conversion, it's doing only the unindentation as well as normalizes all files to end with a newline.
Main conversion step
processDiagnosticMessages.tsgenerate a moduleConvert the diagnostic-generation script to create a module
b9a4a3a Some
require->importconversionsManual changes and tweaks to make things work
Rest of the ongoing work, saved in a commit (will eventually become a proper part). This includes:
buildServices,buildLssl).!!!comments marking places that might need adjusting.This would change (done for all packages, and probably better), but added now to make running the tests easier for others