Skip to content

Report error for class expressions incorrectly extending abstract classes#4656

Merged
mhegazy merged 2 commits into
masterfrom
Fix4655
Sep 9, 2015
Merged

Report error for class expressions incorrectly extending abstract classes#4656
mhegazy merged 2 commits into
masterfrom
Fix4655

Conversation

@mhegazy

@mhegazy mhegazy commented Sep 5, 2015

Copy link
Copy Markdown
Contributor

Fix #4655

@DanielRosenwasser DanielRosenwasser changed the title Report error for class expressions incorrectelly extending abstract classes Report error for class expressions incorrectly extending abstract classes Sep 5, 2015
@DanielRosenwasser

Copy link
Copy Markdown
Member

Can you add a test for a default-exported non-abstract class that does't implement its inherited abstract methods?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment is misleading, can you remove it?

@vladima

vladima commented Sep 9, 2015

Copy link
Copy Markdown
Contributor

👍

mhegazy added a commit that referenced this pull request Sep 9, 2015
Report error for class expressions incorrectly extending abstract classes
@mhegazy mhegazy merged commit a5c7201 into master Sep 9, 2015
@mhegazy mhegazy deleted the Fix4655 branch September 9, 2015 20:35
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants