Skip to content

in operator typeguard can widen types#46403

Closed
marekdedic wants to merge 86 commits intomicrosoft:mainfrom
marekdedic:in-operator-add-property
Closed

in operator typeguard can widen types#46403
marekdedic wants to merge 86 commits intomicrosoft:mainfrom
marekdedic:in-operator-add-property

Conversation

@marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Oct 17, 2021 •
edited
Loading

Fixes #21732

This PR is a continuation of #39746 - thanks @ShuiRuTian for his work. I have made the branch up-to-date with main and fixed new test breakages. As I am not the original author of most of the changes, I would greatly appreciate a review either from @ShuiRuTian or the maintainers of TS.

Submission containing materials of a third party: @ShuiRuTian

Please verify that:

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the main branch
  • You've successfully run gulp runtests locally
  • There are new or updated unit tests validating the change

ShuiRuTian and others added 22 commits July 7, 2020 17:00
@ghost
Copy link

ghost commented Oct 17, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Oct 17, 2021
@marekdedic marekdedic changed the title in operator typeguard now can widen types in operator typeguard can widen types Oct 17, 2021
@marekdedic
Copy link
Contributor Author

marekdedic commented Oct 17, 2021

I have signed the CLA, however, I have no idea what to do with the code that is not my own - my layman's interpretation of the CLA is that if @ShuiRuTian signed the CLA as well, than it should all be OK. However, I can't check that he did.

@marekdedic marekdedic marked this pull request as draft October 17, 2021 17:26
@marekdedic
Copy link
Contributor Author

marekdedic commented Mar 26, 2022

Hi, @weswigham
thanks for the tips, I've used one and have some question about the other. Could you please take a look at the comments about the src/compiler/typeTests.ts file by @jakebailey? I'd like to resolve that :)

@marekdedic marekdedic requested a review from weswigham March 26, 2022 21:31
@marekdedic marekdedic mentioned this pull request Sep 7, 2022
Merged
@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Sep 20, 2022

superseded by #50666 ?

@marekdedic
Copy link
Contributor Author

marekdedic commented Sep 20, 2022 •
edited
Loading

Yes, superseded. For some (unsolicited) feedback, it's a pretty demotivating contributor experience to have a PR sit and wait for feedback/merge for half a year only to be re-implemented and superseded by a different PR from a project member.

With that said, the other PR is pretty clearly much more expansive and definitely an improvement over this one...

@marekdedic marekdedic closed this Sep 20, 2022
@marekdedic marekdedic deleted the in-operator-add-property branch September 20, 2022 07:48
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey left review comments

@weswigham weswigham Awaiting requested review from weswigham

+1 more reviewer

@ShuiRuTian ShuiRuTian ShuiRuTian left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@weswigham weswigham

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suggestion: treat in operator as type guard which asserts property existence

7 participants

@marekdedic @ShuiRuTian @sandersn @HolgerJeromin @weswigham @jakebailey @typescript-bot