Skip to content

Format intersection type#4623

Merged
vladima merged 4 commits into
microsoft:masterfrom
saschanaz:formatIntersectionType
Sep 3, 2015
Merged

Format intersection type#4623
vladima merged 4 commits into
microsoft:masterfrom
saschanaz:formatIntersectionType

Conversation

@saschanaz

Copy link
Copy Markdown
Contributor

Related to #4569

Current:

let x: string            &         number

Fix:

let x: string & number

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do I understand correctly, this is removed to avoid double indentation for cases like the one below?

type a = string
    | number;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it to prevent this:

type a = 
    string |
        number |
        boolean;

... to match normal bar operator behavior:

let x = 
    3 | 
    4 |
    5;

@vladima

vladima commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

👍

vladima added a commit that referenced this pull request Sep 3, 2015
@vladima vladima merged commit 3c96e70 into microsoft:master Sep 3, 2015
@vladima

vladima commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

Thanks @saschanaz!

@mhegazy

mhegazy commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

We should merge this into release-1.6

@saschanaz saschanaz deleted the formatIntersectionType branch September 4, 2015 04:52
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants