Skip to content

Fix class expression indentation#4622

Merged
vladima merged 3 commits into
microsoft:masterfrom
saschanaz:fixClassExpressionIndent
Sep 3, 2015
Merged

Fix class expression indentation#4622
vladima merged 3 commits into
microsoft:masterfrom
saschanaz:fixClassExpressionIndent

Conversation

@saschanaz

@saschanaz saschanaz commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

Fixes #4580

Current:

class Foo extends (
    class

    {
    bar() { }
    }
)

Fix:

class Foo extends (
    class {
        bar() { }
    }
)

@vladima

vladima commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

👍 LGTM

vladima added a commit that referenced this pull request Sep 3, 2015
@vladima
Merge pull request #4622 from SaschaNaz/fixClassExpressionIndent
feddff0 
Fix class expression indentation
@vladima vladima merged commit feddff0 into microsoft:master Sep 3, 2015
@vladima

vladima commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

Thanks @saschanaz!

@mhegazy

mhegazy commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

We should merge this into release-1.6

@vladima vladima mentioned this pull request Sep 3, 2015
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saschanaz @vladima @mhegazy @msftclas