Handle strict flag when writing tsbuildinfo - #44394
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
|
TypeScript Bot (@typescript-bot) pack this |
|
Heya Sheetal Nandi (@sheetalkamat), I've started to run the tarball bundle task on this PR at d3b479e. You can monitor the build here. |
|
Daniel Rosenwasser (@DanielRosenwasser) we probably need this patch for 4.3 ? |
Andrew Casey (amcasey)
left a comment
Andrew Casey (amcasey)
left a comment
There was a problem hiding this comment.
I think I get it, but please see my comment.
| // Though this affects semantic diagnostics, affectsSemanticDiagnostics is not set here | ||
| // The value of each strictFlag depends on own strictFlag value or this and never accessed directly. |
There was a problem hiding this comment.
I kind of wonder whether it's just worth it to say this always has affectsSemanticDiagnostics set to true since it's unlikely that you'd toggle this but have no difference in effective strict options.
There was a problem hiding this comment.
I think its better that we dont update unnecessarily so prefer to keep it like this. But not stuck on it so open to changing that if you feel strongly about it.
There was a problem hiding this comment.
What’s the actual consequence of doing it like this? Like if someone had every individual strict flag enabled, and then toggled strict itself, we would be able to correctly identify that it had no effect?
There was a problem hiding this comment.
correct.
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
|
TypeScript Bot (@typescript-bot) pack this |
|
Heya Sheetal Nandi (@sheetalkamat), I've started to run the tarball bundle task on this PR at cee9f40. You can monitor the build here. |
|
TypeScript Bot (@typescript-bot) cherry pick this to release-4.3 branch |
|
TypeScript Bot (@typescript-bot) cherry pick this to release-4.3 |
|
Sheetal Nandi (@sheetalkamat) Daniel Rosenwasser (@DanielRosenwasser) Looks like you need a dash in "cherry-pick" for the bot to activate |
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-4.3 |
|
Heya Sheetal Nandi (@sheetalkamat), I've started to run the task to cherry-pick this into |
|
Hey Sheetal Nandi (@sheetalkamat), I've opened #44431 for you. |
Component commits: b6754e4 Add test showing how setting strict is not preserved in tsbuildinfo Test for microsoft#44305 d3b479e Handle strict flag when writing tsbuildinfo Fixes microsoft#44305 cee9f40 Apply suggestions from code review Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Component commits: b6754e4 Add test showing how setting strict is not preserved in tsbuildinfo Test for #44305 d3b479e Handle strict flag when writing tsbuildinfo Fixes #44305 cee9f40 Apply suggestions from code review Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com> Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
6 participants
Fixes #44305