Adds a script for removing unused diagnostics - #44324
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
|
I can use |
| const diagName = line.split(":")[0].trim(); | ||
|
|
||
| try { | ||
| execSync(`grep -rnw 'src' -e 'Diagnostics.${diagName}'`).toString(); |
There was a problem hiding this comment.
there's probably a platform-independent package on npm that does recursive file string search, although feature-detecting grep vs findstr would work too.
There was a problem hiding this comment.
wes thinks ripgrep ( https://www.npmjs.com/package/vscode-ripgrep ) should be a reasonable tradeoff here
There was a problem hiding this comment.
To avoid the offensive huge cost of this you could just grep all lines that include Diagnostics., print them to a temp file, then search through this file. Also, even if the names are well behaved, it would be better to add -F. Also, -n is redundant AFAICT.
(And doing it with a grep library seems like an overkill too...)
| "category": "Message", | ||
| "code": 95001 | ||
| }, | ||
| "Convert function '{0}' to class": { |
There was a problem hiding this comment.
I'm almost certain this message and the ones that follow are used in codefixes. I wonder why our fourslash tests don't fail with them gone.
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
There was a problem hiding this comment.
Well...early in a release's development is the best time to try something like this.
Orta Therox (@orta) you want to try merging this early on Monday to see whether it breaks anything?
(I think Eli Barzilay (@elibarzilay) 's right about grep -- almost all the team can run this script in an environment with grep if they need to.)
|
Yeah, lets do it |
* Adds a script for removing unused diagnostics * Accidentally deleted the wrong one
4 participants
This adds a script which only runs on linux boxes, that searches the codebase for every diagnostic and lets you know if nothing is found.
TODO: Add to CI.