Proposal class static block support by Kingwl · Pull Request #43370 · microsoft/TypeScript

Wenlu Wang (Kingwl) · 2021-03-25T07:02:18Z

* Add types factory and parser * Add some case * Make class static block as a container * Update cases * Add visitor * Add emitter and more compile target * Check boundary of break and continue

Wenlu Wang (Kingwl) · 2021-03-25T07:27:14Z

Let's try it again. Orta Therox (@orta)

TypeScript Bot (@typescript-bot) pack this.

TypeScript Bot (typescript-bot) · 2021-03-25T07:27:16Z

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 3c0b7cf. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-03-25T07:47:21Z

Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/99247/artifacts?artifactName=tgz&fileId=C99DA09C5ECBA3E66DC0D451539FCF2B7270F09A474D967333148F7F3AF9C95B02&fileName=/typescript-4.3.0-insiders.20210325.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.3.0-pr-43370-2".;

Ron Buckton (rbuckton)

I know this is still a Draft, but thought you might appreciate some early feedback.

We should have logic in the checker to check for invalid decorators or modifiers. We also should be checking for invalid uses of await as an identifier in the block.

Wenlu Wang (Kingwl) · 2021-03-26T09:04:57Z

One of problem is we do not have something like IdentifierReferenceExpression.

If I'm correct. We should check many thinks:

name of property access: a.await Should be an error?
name of type parameter: type await = number. Should be an error?
name of type reference: const a: await Should be an error?
etc.

Seems it's very expensive? I would like to add a (flag? property?) into identifier if it's parsed by parsePrimaryExpression. That seems could help us check the reference by cheap way (And with check variable like & type reference )？

And we need many cases to check about the function boundary.

Ron Buckton (rbuckton) · 2021-03-27T02:21:18Z

We could handle this via a special parser context, similar to NodeFlags.Await and NodeFlags.Yield, and then modify isIdentifier() in parser.ts.

For example, we don't allow await as a keyword in a type declaration in an async function today:

interface await {} // ok
async function f() {
    interface await {} // error, because we're in an Await context
    const a: await = 1; // not an error because parsing a type annotation exits the Await context
}

Ron Buckton (rbuckton) · 2021-03-27T02:23:17Z

Also a.await isn't an issue since that's parsed as a property name, which allows keywords.

Ron Buckton (rbuckton) · 2021-03-27T02:24:11Z

I would like to add a (flag? property?) into identifier if it's parsed by parsePrimaryExpression

This shouldn't be necessary.

Wenlu Wang (Kingwl) · 2021-04-16T07:17:19Z

Should we also deny the await identifiers inside type context?

Wenlu Wang (Kingwl) · 2021-04-16T11:21:09Z

Basically checked the function boundary. Computed property name is a known issue.
Please let me know if anything wrong.
Thanks!

Ron Buckton (rbuckton) · 2021-06-23T22:19:28Z

If it helps, I can work on the missing language service features and tests for static {} so that this can be ready for 4.4 beta.

Wenlu Wang (Kingwl) · 2021-06-24T01:15:50Z

that this can be ready for 4.4 beta.

Appreciate, if it need to be done before today end.

Ron Buckton (rbuckton) · 2021-06-24T01:24:20Z

I'd like to get this in before noon PDT on Friday. I've pushed up support for call hierarchy, references, and go to definition along with relevant tests.

Ron Buckton (rbuckton) · 2021-06-24T21:35:28Z

From a conversation with Ryan Cavanaugh (@RyanCavanaugh), it seems like we want to try to wrap 4.4 features today. I will do what I can to get this PR merged by EOD.

Wenlu Wang (Kingwl) · 2021-06-25T03:07:37Z

I'm not sure what time zone that you say but I'll stay late this night (6/25, your morning).

Ron Buckton (rbuckton) · 2021-06-25T09:51:12Z

I think this is good to merge except for the missing this support in static {}. Its possible we could merge this for the beta without this support (since referencing the class by name works), and add it once #43114 is merged. Either this PR or that one will have to deal with the merge conflicts.

Ron Buckton (rbuckton)

I think this looks good. We can address this support in static {} in #43114.

Ron Buckton (rbuckton) · 2021-06-25T09:53:59Z

TypeScript Bot (@typescript-bot) perf test
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this

TypeScript Bot (typescript-bot) · 2021-06-25T09:54:02Z

Heya Ron Buckton (@rbuckton), I've started to run the parallelized community code test suite on this PR at 6234640. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-06-25T09:54:02Z

Heya Ron Buckton (@rbuckton), I've started to run the extended test suite on this PR at 6234640. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-06-25T09:54:02Z

Heya Ron Buckton (@rbuckton), I've started to run the parallelized Definitely Typed test suite on this PR at 6234640. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-06-25T09:54:02Z

Heya Ron Buckton (@rbuckton), I've started to run the perf test suite on this PR at 6234640. You can monitor the build here.

Update: The results are in!

Ron Buckton (rbuckton) · 2021-06-25T09:54:59Z

After the bot checks all the things, I can merge this in the morning if there are no major breaks. Then we can work on getting this to work with #43114.

TypeScript Bot (typescript-bot) · 2021-06-25T10:29:22Z

Ron Buckton (@rbuckton)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..43370

_Metric	_main	₄₃₃₇₀	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{344,436k (± 0.02%)}	_{344,539k (± 0.02%)}	_{+102k (+ 0.03%)}	_344,280k	_344,682k
_{Parse Time}	_{1.80s (± 0.71%)}	_{1.80s (± 0.46%)}	_{-0.00s (- 0.22%)}	_1.78s	_1.82s
_{Bind Time}	_{0.84s (± 0.74%)}	_{0.84s (± 0.77%)}	_{-0.00s (- 0.12%)}	_0.82s	_0.85s
_{Check Time}	_{5.20s (± 0.60%)}	_{5.21s (± 0.41%)}	_{+0.01s (+ 0.17%)}	_5.16s	_5.26s
_{Emit Time}	_{5.60s (± 0.67%)}	_{5.63s (± 0.54%)}	_{+0.03s (+ 0.57%)}	_5.55s	_5.70s
_{Total Time}	_{13.44s (± 0.56%)}	_{13.48s (± 0.35%)}	_{+0.04s (+ 0.28%)}	_13.34s	_13.55s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{201,022k (± 0.03%)}	_{201,123k (± 0.06%)}	_{+101k (+ 0.05%)}	_200,701k	_201,321k
_{Parse Time}	_{0.78s (± 0.63%)}	_{0.79s (± 0.76%)}	_{+0.00s (+ 0.13%)}	_0.77s	_0.80s
_{Bind Time}	_{0.53s (± 1.40%)}	_{0.53s (± 1.13%)}	_{-0.00s (- 0.75%)}	_0.52s	_0.54s
_{Check Time}	_{7.63s (± 0.60%)}	_{7.55s (± 0.41%)}	_{-0.09s (- 1.13%)}	_7.48s	_7.63s
_{Emit Time}	_{2.30s (± 1.55%)}	_{2.29s (± 1.40%)}	_{-0.01s (- 0.52%)}	_2.22s	_2.38s
_{Total Time}	_{11.25s (± 0.68%)}	_{11.16s (± 0.44%)}	_{-0.10s (- 0.87%)}	_11.06s	_11.25s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{340,546k (± 0.03%)}	_{340,492k (± 0.02%)}	_{-54k (- 0.02%)}	_340,336k	_340,637k
_{Parse Time}	_{1.46s (± 0.77%)}	_{1.45s (± 0.38%)}	_{-0.01s (- 0.62%)}	_1.44s	_1.46s
_{Bind Time}	_{0.74s (± 0.98%)}	_{0.74s (± 0.87%)}	_{0.00s ( 0.00%)}	_0.73s	_0.76s
_{Check Time}	_{5.34s (± 0.60%)}	_{5.33s (± 0.30%)}	_{-0.01s (- 0.17%)}	_5.30s	_5.38s
_{Emit Time}	_{3.01s (± 0.95%)}	_{3.00s (± 0.72%)}	_{-0.01s (- 0.23%)}	_2.95s	_3.06s
_{Total Time}	_{10.56s (± 0.41%)}	_{10.54s (± 0.26%)}	_{-0.02s (- 0.23%)}	_10.46s	_10.59s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{303,760k (± 0.01%)}	_{303,773k (± 0.02%)}	_{+13k (+ 0.00%)}	_303,599k	_303,927k
_{Parse Time}	_{1.18s (± 0.64%)}	_{1.18s (± 0.38%)}	_{-0.01s (- 0.59%)}	_1.17s	_1.19s
_{Bind Time}	_{0.71s (± 1.05%)}	_{0.71s (± 0.31%)}	_{-0.00s (- 0.14%)}	_0.70s	_0.71s
_{Check Time}	_{4.89s (± 0.46%)}	_{4.87s (± 0.70%)}	_{-0.02s (- 0.37%)}	_4.80s	_4.96s
_{Emit Time}	_{3.14s (± 1.82%)}	_{3.12s (± 1.20%)}	_{-0.02s (- 0.73%)}	_3.05s	_3.20s
_{Total Time}	_{9.93s (± 0.78%)}	_{9.88s (± 0.50%)}	_{-0.05s (- 0.52%)}	_9.79s	_10.01s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{471,410k (± 0.01%)}	_{471,388k (± 0.01%)}	_{-22k (- 0.00%)}	_471,294k	_471,473k
_{Parse Time}	_{1.72s (± 0.38%)}	_{1.72s (± 0.33%)}	_{-0.00s (- 0.12%)}	_1.71s	_1.74s
_{Bind Time}	_{0.67s (± 0.87%)}	_{0.66s (± 0.67%)}	_{-0.01s (- 0.75%)}	_0.65s	_0.67s
_{Check Time}	_{14.12s (± 0.48%)}	_{14.08s (± 0.43%)}	_{-0.05s (- 0.32%)}	_13.98s	_14.24s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.51s (± 0.43%)}	_{16.46s (± 0.39%)}	_{-0.05s (- 0.33%)}	_16.34s	_16.62s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{322,741k (± 0.03%)}	_{322,570k (± 0.10%)}	_{-171k (- 0.05%)}	_321,642k	_322,990k
_{Parse Time}	_{1.78s (± 0.57%)}	_{1.77s (± 0.71%)}	_{-0.01s (- 0.56%)}	_1.75s	_1.80s
_{Bind Time}	_{0.83s (± 0.74%)}	_{0.83s (± 0.60%)}	_{-0.00s (- 0.36%)}	_0.81s	_0.83s
_{Check Time}	_{5.11s (± 0.52%)}	_{5.14s (± 0.64%)}	_{+0.03s (+ 0.57%)}	_5.08s	_5.23s
_{Emit Time}	_{5.84s (± 1.04%)}	_{5.88s (± 1.14%)}	_{+0.04s (+ 0.69%)}	_5.77s	_6.08s
_{Total Time}	_{13.56s (± 0.64%)}	_{13.62s (± 0.63%)}	_{+0.05s (+ 0.38%)}	_13.50s	_13.88s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{188,750k (± 0.29%)}	_{188,545k (± 0.13%)}	_{-206k (- 0.11%)}	_187,632k	_188,822k
_{Parse Time}	_{0.77s (± 0.72%)}	_{0.77s (± 0.84%)}	_{+0.00s (+ 0.52%)}	_0.76s	_0.79s
_{Bind Time}	_{0.53s (± 1.05%)}	_{0.53s (± 0.98%)}	_{+0.00s (+ 0.19%)}	_0.52s	_0.54s
_{Check Time}	_{7.07s (± 0.33%)}	_{7.07s (± 0.50%)}	_{+0.00s (+ 0.03%)}	_6.98s	_7.15s
_{Emit Time}	_{2.32s (± 1.08%)}	_{2.32s (± 1.30%)}	_{-0.00s (- 0.13%)}	_2.25s	_2.40s
_{Total Time}	_{10.69s (± 0.20%)}	_{10.69s (± 0.46%)}	_{+0.00s (+ 0.00%)}	_10.57s	_10.81s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{323,548k (± 0.02%)}	_{323,647k (± 0.02%)}	_{+99k (+ 0.03%)}	_323,472k	_323,828k
_{Parse Time}	_{1.41s (± 0.84%)}	_{1.42s (± 0.66%)}	_{+0.01s (+ 0.57%)}	_1.40s	_1.45s
_{Bind Time}	_{0.71s (± 0.95%)}	_{0.72s (± 0.69%)}	_{+0.00s (+ 0.28%)}	_0.71s	_0.73s
_{Check Time}	_{5.20s (± 0.66%)}	_{5.20s (± 0.44%)}	_{+0.00s (+ 0.10%)}	_5.16s	_5.26s
_{Emit Time}	_{3.06s (± 0.87%)}	_{3.05s (± 0.77%)}	_{-0.01s (- 0.23%)}	_3.02s	_3.11s
_{Total Time}	_{10.38s (± 0.61%)}	_{10.39s (± 0.46%)}	_{+0.01s (+ 0.09%)}	_10.31s	_10.51s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{288,369k (± 0.01%)}	_{288,453k (± 0.03%)}	_{+84k (+ 0.03%)}	_288,243k	_288,674k
_{Parse Time}	_{1.19s (± 0.84%)}	_{1.19s (± 0.80%)}	_{-0.00s (- 0.34%)}	_1.17s	_1.20s
_{Bind Time}	_{0.70s (± 1.17%)}	_{0.69s (± 0.83%)}	_{-0.01s (- 1.00%)}	_0.68s	_0.70s
_{Check Time}	_{4.78s (± 0.39%)}	_{4.79s (± 0.64%)}	_{+0.00s (+ 0.04%)}	_4.73s	_4.86s
_{Emit Time}	_{3.18s (± 1.22%)}	_{3.20s (± 0.78%)}	_{+0.02s (+ 0.69%)}	_3.15s	_3.25s
_{Total Time}	_{9.85s (± 0.49%)}	_{9.86s (± 0.49%)}	_{+0.01s (+ 0.10%)}	_9.77s	_10.00s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{450,057k (± 0.01%)}	_{450,113k (± 0.02%)}	_{+56k (+ 0.01%)}	_449,923k	_450,249k
_{Parse Time}	_{1.71s (± 0.76%)}	_{1.71s (± 0.38%)}	_{+0.00s (+ 0.12%)}	_1.70s	_1.72s
_{Bind Time}	_{0.64s (± 1.27%)}	_{0.64s (± 0.70%)}	_{-0.01s (- 0.78%)}	_0.63s	_0.65s
_{Check Time}	_{12.66s (± 0.52%)}	_{12.62s (± 0.33%)}	_{-0.04s (- 0.36%)}	_12.53s	_12.73s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.01s (± 0.42%)}	_{14.96s (± 0.26%)}	_{-0.05s (- 0.34%)}	_14.89s	_15.07s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{321,315k (± 0.01%)}	_{321,366k (± 0.01%)}	_{+51k (+ 0.02%)}	_321,305k	_321,423k
_{Parse Time}	_{1.81s (± 0.54%)}	_{1.79s (± 0.45%)}	_{-0.02s (- 0.88%)}	_1.78s	_1.81s
_{Bind Time}	_{0.87s (± 0.60%)}	_{0.88s (± 1.64%)}	_{+0.01s (+ 1.38%)}	_0.87s	_0.94s
_{Check Time}	_{5.12s (± 0.54%)}	_{5.11s (± 0.36%)}	_{-0.01s (- 0.21%)}	_5.06s	_5.15s
_{Emit Time}	_{5.91s (± 0.78%)}	_{5.86s (± 0.42%)}	_{-0.05s (- 0.86%)}	_5.78s	_5.89s
_{Total Time}	_{13.70s (± 0.58%)}	_{13.64s (± 0.27%)}	_{-0.06s (- 0.46%)}	_13.55s	_13.72s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{189,144k (± 0.62%)}	_{189,872k (± 0.50%)}	_{+727k (+ 0.38%)}	_187,272k	_190,578k
_{Parse Time}	_{0.81s (± 0.61%)}	_{0.80s (± 0.74%)}	_{-0.00s (- 0.12%)}	_0.79s	_0.82s
_{Bind Time}	_{0.56s (± 0.59%)}	_{0.56s (± 0.72%)}	_{-0.00s (- 0.18%)}	_0.55s	_0.57s
_{Check Time}	_{7.17s (± 0.33%)}	_{7.13s (± 0.43%)}	_{-0.04s (- 0.53%)}	_7.08s	_7.19s
_{Emit Time}	_{2.29s (± 0.77%)}	_{2.32s (± 2.22%)}	_{+0.02s (+ 0.96%)}	_2.27s	_2.52s
_{Total Time}	_{10.83s (± 0.33%)}	_{10.81s (± 0.46%)}	_{-0.02s (- 0.18%)}	_10.72s	_10.97s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{322,485k (± 0.01%)}	_{322,530k (± 0.00%)}	_{+45k (+ 0.01%)}	_322,497k	_322,556k
_{Parse Time}	_{1.48s (± 0.91%)}	_{1.48s (± 0.71%)}	_{+0.00s (+ 0.20%)}	_1.47s	_1.51s
_{Bind Time}	_{0.74s (± 0.80%)}	_{0.75s (± 0.87%)}	_{+0.00s (+ 0.40%)}	_0.73s	_0.76s
_{Check Time}	_{5.19s (± 0.63%)}	_{5.17s (± 0.64%)}	_{-0.02s (- 0.31%)}	_5.09s	_5.22s
_{Emit Time}	_{3.13s (± 0.85%)}	_{3.11s (± 1.08%)}	_{-0.02s (- 0.54%)}	_3.06s	_3.20s
_{Total Time}	_{10.54s (± 0.39%)}	_{10.51s (± 0.50%)}	_{-0.02s (- 0.23%)}	_10.41s	_10.64s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{287,397k (± 0.01%)}	_{287,471k (± 0.01%)}	_{+74k (+ 0.03%)}	_287,428k	_287,526k
_{Parse Time}	_{1.27s (± 0.80%)}	_{1.25s (± 0.53%)}	_{-0.02s (- 1.26%)}	_1.24s	_1.27s
_{Bind Time}	_{0.72s (± 0.81%)}	_{0.72s (± 1.04%)}	_{+0.00s (+ 0.00%)}	_0.71s	_0.74s
_{Check Time}	_{4.81s (± 0.39%)}	_{4.82s (± 0.50%)}	_{+0.01s (+ 0.12%)}	_4.78s	_4.89s
_{Emit Time}	_{3.29s (± 1.03%)}	_{3.27s (± 0.61%)}	_{-0.02s (- 0.58%)}	_3.24s	_3.33s
_{Total Time}	_{10.09s (± 0.37%)}	_{10.06s (± 0.25%)}	_{-0.03s (- 0.25%)}	_10.00s	_10.12s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{448,218k (± 0.05%)}	_{448,340k (± 0.04%)}	_{+121k (+ 0.03%)}	_447,631k	_448,486k
_{Parse Time}	_{1.75s (± 0.50%)}	_{1.75s (± 0.63%)}	_{-0.00s (- 0.17%)}	_1.72s	_1.77s
_{Bind Time}	_{0.69s (± 0.32%)}	_{0.69s (± 0.58%)}	_{+0.00s (+ 0.00%)}	_0.68s	_0.70s
_{Check Time}	_{12.84s (± 0.56%)}	_{12.83s (± 0.47%)}	_{-0.01s (- 0.07%)}	_12.73s	_12.94s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.28s (± 0.48%)}	_{15.27s (± 0.41%)}	_{-0.01s (- 0.07%)}	_15.16s	_15.37s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-206-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₃₃₇₀	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

Wenlu Wang (Kingwl) · 2021-06-25T13:43:33Z

Some tests failed. But seems not my fault.

Wenlu Wang (Kingwl) · 2021-06-25T13:44:24Z

TypeScript Bot (@typescript-bot) pack this.

TypeScript Bot (typescript-bot) · 2021-06-25T13:44:26Z

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 6234640. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-06-25T14:04:32Z

Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/105559/artifacts?artifactName=tgz&fileId=BA047F25FA4C0D5193B0BA0847043F33E9205E79E02B5C9EADF397ADE79219B402&fileName=/typescript-4.4.0-insiders.20210625.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.4.0-pr-43370-43".;

Alireza (sedghi) · 2022-08-17T16:09:33Z

Is there any way to disable this with a flag? Previously in typescript 4.5.x my esm build was

But from 4.6.x I have a static block

Which apparently terser has problem, and also consuming apps don't recognize this

Wenlu Wang (Kingwl) added 6 commits March 25, 2021 15:01

Class static block (#9)

dde4ca2

* Add types factory and parser * Add some case * Make class static block as a container * Update cases * Add visitor * Add emitter and more compile target * Check boundary of break and continue

Add basic transformer

188cf27

Fix emit behavior

e26d82a

Add more tests

7c50597

Add friend tests

6f4b7b3

Update baseline

3c0b7cf

TypeScript Bot (typescript-bot) assigned Ron Buckton (rbuckton) Mar 25, 2021

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 25, 2021

Wenlu Wang (Kingwl) marked this pull request as draft March 25, 2021 07:02

Ron Buckton (rbuckton) suggested changes Mar 26, 2021

View reviewed changes

Wenlu Wang (Kingwl) added 3 commits March 26, 2021 16:18

Fix cr issues

bafd15c

Accept baseline

c3a8b27

Add decorator and modifier check

4c19c80

Merge branch 'master' into proposal_class_static_block_support

b4e64c4

Add functional boundary check

3a61e56

Wenlu Wang (Kingwl) added 6 commits April 21, 2021 18:18

Merge branch 'master' into proposal_class_static_block_support

b826bcb

Merge branch 'master' into proposal_class_static_block_support

f31a962

Fix conflict

1bed545

Fix computed prop name within context

54bd285

Add more tests

efa72d9

Update baseline

561b9d6

Add more case

1f173a9

Ron Buckton (rbuckton) suggested changes Jun 24, 2021

View reviewed changes

Comment thread tests/baselines/reference/classStaticBlock4.errors.txt Outdated

Add tests and support for related services functionality

b409d8c

Wenlu Wang (Kingwl) added 2 commits June 24, 2021 11:16

Fix this reference in static block

aa28986

Split parser diagnostic and binder diagnostic

6234640

Ron Buckton (rbuckton) approved these changes Jun 25, 2021

View reviewed changes

Ron Buckton (rbuckton) merged commit 906cbd2 into microsoft:main Jun 25, 2021

SUZUKI Sosuke (sosukesuzuki) mentioned this pull request Jul 2, 2021

Support TypeScript 4.4 prettier/prettier#11143

Closed

SUZUKI Sosuke (sosukesuzuki) mentioned this pull request Jul 10, 2021

TypeScript 4.4 Syntax Support typescript-eslint/typescript-eslint#3606

Closed

Dan Freeman (dfreeman) mentioned this pull request Jul 20, 2021

Upgrade to TS 4.3 and play nicely with new flags typed-ember/glint#206

Merged

Hamed Araab (Hawmex) mentioned this pull request Aug 28, 2021

Support class static blocks evanw/esbuild#1558

Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025

Uh oh!

Conversation

Wenlu Wang (Kingwl) commented Mar 25, 2021

Uh oh!

Wenlu Wang (Kingwl) commented Mar 25, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ron Buckton (rbuckton) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wenlu Wang (Kingwl) commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ron Buckton (rbuckton) commented Mar 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ron Buckton (rbuckton) commented Mar 27, 2021

Uh oh!

Ron Buckton (rbuckton) commented Mar 27, 2021

Uh oh!

Wenlu Wang (Kingwl) commented Apr 16, 2021

Uh oh!

Wenlu Wang (Kingwl) commented Apr 16, 2021

Uh oh!

Ron Buckton (rbuckton) commented Jun 23, 2021

Uh oh!

Uh oh!

Wenlu Wang (Kingwl) commented Jun 24, 2021

Uh oh!

Ron Buckton (rbuckton) commented Jun 24, 2021

Uh oh!

Ron Buckton (rbuckton) commented Jun 24, 2021

Uh oh!

Wenlu Wang (Kingwl) commented Jun 25, 2021

Uh oh!

Ron Buckton (rbuckton) commented Jun 25, 2021

Uh oh!

Ron Buckton (rbuckton) left a comment

Choose a reason for hiding this comment

Uh oh!

Ron Buckton (rbuckton) commented Jun 25, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ron Buckton (rbuckton) commented Jun 25, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 25, 2021

Uh oh!

Wenlu Wang (Kingwl) commented Jun 25, 2021

Uh oh!

Wenlu Wang (Kingwl) commented Jun 25, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 25, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 25, 2021 •

edited

Loading

Wenlu Wang (Kingwl) commented Mar 26, 2021 •

edited

Loading

Ron Buckton (rbuckton) commented Mar 27, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 25, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 25, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 25, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 25, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 25, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 25, 2021 •

edited

Loading