fix: /// <reference path="..." static='true' />#427
Conversation
The second quote of the static attribute was incorrectly matched against the first quote of the path attribute.
|
Thanks for submitting this PR; two things:
|
|
I've already completed the CLA, I am (was) AdamFreidin on codeplex. I'll work on a unit test later today. Assuming you really think it's necessary to track that obviously poor regex-based XML-ish parsing needs a unit test to be incrementally improved. |
|
Sorry @sparecycles, my bad. so it is just the test then :) |
|
👍 |
|
So, I added a test but the baseline reference/ folder currently has files in it and after running jake runtests and jake baseline-accept, it gets folders (project/ and projectOutput/). Rewriting/moving all the baseline files seems like too large a change, what am I doing wrong? EDIT: here are the changes before running |
|
The test looks good. The projectoutput folder is a temp folder, you should not include it in your change. So either remove it after baseline-accept or delete it from local before accepting the baseline. |
jake runtests jake baseline-accept
|
I integrated the tests and baseline update. |
fix: /// <reference path="..." static='true' />
|
thanks |
|
What does |
|
nothing :); it is only for back compat. back in the 0.8.* days we used it to indicate to the LS that this is a lib file and should not be retypechecked on every change. this since has become unviable with reopening and merging of declarations across files. what we care about, is if a /// reference has a static field we read it correctly.. |
|
@mhegazy cool. Thanks! |
The second quote of the static attribute was incorrectly
matched against the first quote of the path attribute.