If import is used in the file, prefer that import specifier over calculating new one#42224
Merged
sheetalkamat merged 7 commits intomasterfrom Jan 8, 2021
Merged
If import is used in the file, prefer that import specifier over calculating new one#42224sheetalkamat merged 7 commits intomasterfrom
sheetalkamat merged 7 commits intomasterfrom
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
changed the title
typescript-bot
added
For Milestone Bug
…ulating new one Fixes #39117
sheetalkamat
force-pushed
the
projectRefDeclarationEmit
branch
from
0339f7e to
685f2b6
Compare
andrewbranch
reviewed
Jan 6, 2021
…ths even if they are from the existing file
robpalme
reviewed
Jan 6, 2021
Member
Author
|
@typescript-bot test this |
Collaborator
|
Heya @sheetalkamat, I've started to run the parallelized community code test suite on this PR at 71e42ba. You can monitor the build here. |
Collaborator
|
Heya @sheetalkamat, I've started to run the extended test suite on this PR at 71e42ba. You can monitor the build here. |
Collaborator
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
andrewbranch
approved these changes
Jan 8, 2021
Zzzen
pushed a commit
to Zzzen/TypeScript
that referenced
this pull request
Jan 16, 2021
…ulating new one (microsoft#42224) * Test case where the wrong path is emitted * If import is used in the file, prefer that import specifier over calculating new one Fixes microsoft#39117 * Update Baselines and/or Applied Lint Fixes * When non-relative path is used as user preference, ignore relative paths even if they are from the existing file * Fix test * Add comment Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39117