Skip to content

fix(35050): Decorator emit incorrect within try block#41951

Merged
rbuckton merged 3 commits intomicrosoft:mainfrom
a-tarasyuk:fix/35050
Jul 8, 2021
Merged

fix(35050): Decorator emit incorrect within try block#41951
rbuckton merged 3 commits intomicrosoft:mainfrom
a-tarasyuk:fix/35050

Conversation

@a-tarasyuk
Copy link
Copy Markdown
Contributor

Fixes #35050

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Dec 14, 2020
@rbuckton
Copy link
Copy Markdown
Contributor

rbuckton commented Jul 8, 2021

Class declarations are block scoped variables, so this could possibly introduce a collision if there is a let declaration in an outer scope. I may amend this PR slightly to only use getInternalName when we know this is being moved to an IIFE for ES5/3.

@a-tarasyuk
Copy link
Copy Markdown
Contributor Author

@rbuckton Thanks for the help.

@rbuckton rbuckton merged commit a15030f into microsoft:main Jul 8, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Decorator emit incorrect within try block

4 participants