Skip to content

Error if 'files' property is not an array#4064

Merged
RyanCavanaugh merged 1 commit into
microsoft:masterfrom
RyanCavanaugh:tsconfigFilesError
Jul 29, 2015
Merged

Error if 'files' property is not an array#4064
RyanCavanaugh merged 1 commit into
microsoft:masterfrom
RyanCavanaugh:tsconfigFilesError

Conversation

@RyanCavanaugh

@RyanCavanaugh RyanCavanaugh commented Jul 29, 2015

Copy link
Copy Markdown
Member

I wrote this

{
    "files": "tests.ts",
    "compilerOptions": {
        "module": "commonjs",
        "noImplicitAny": true
    }
}

and spent a long time trying to figure out what went wrong

@danquirk

danquirk commented Jul 29, 2015

Copy link
Copy Markdown
Member

👍

2 similar comments
@mhegazy

mhegazy commented Jul 29, 2015

Copy link
Copy Markdown
Contributor

👍

@DanielRosenwasser

DanielRosenwasser commented Jul 29, 2015

Copy link
Copy Markdown
Member

👍

RyanCavanaugh added a commit that referenced this pull request Jul 29, 2015
@RyanCavanaugh
Merge pull request #4064 from RyanCavanaugh/tsconfigFilesError
595a8d2 
Error if 'files' property is not an array
@RyanCavanaugh RyanCavanaugh merged commit 595a8d2 into microsoft:master Jul 29, 2015
@RyanCavanaugh RyanCavanaugh deleted the tsconfigFilesError branch July 29, 2015 06:45
@mihailik

mihailik commented Jul 29, 2015

Copy link
Copy Markdown
Contributor

The error text is confusing. Files is not a compiler option.

@RyanCavanaugh

RyanCavanaugh commented Jul 29, 2015

Copy link
Copy Markdown
Member Author

I guess I think of the whole thing as compiler options (I don't even understand why we put 'files' in a different nesting level from everything else). Would be happy to take a PR with a better error message.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RyanCavanaugh @danquirk @mhegazy @DanielRosenwasser @mihailik @msftclas